Bug/pagination enabled empty workpad#62050
Merged
maggieghamry merged 2 commits intoelastic:masterfrom Apr 13, 2020
Merged
Conversation
Added logic to hide pagination if no Canvas workpads exists, and disable the previous/next arrows if there is only one page, for both workapds and templates
…agination-enabled-empty-workpad
maggieghamry
added
bug
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
poffdeluxe
approved these changes
Apr 3, 2020
Contributor
poffdeluxe
left a comment
poffdeluxe
left a comment
There was a problem hiding this comment.
Changes look good to me. I did notice that when there are lots of workpads that fill the browser window, it seems like scrolling isn't enabled. I don't think your PR introduced this but did you notice the same thing?
Contributor
Author
|
@poffdeluxe my 3rd screenshot is what I see when there are more than 10 workpads; do you see something different (or should it look different)? |
maggieghamry
added a commit
to maggieghamry/kibana
that referenced
this pull request
Apr 13, 2020
Added logic to hide pagination if no Canvas workpads exists, and disable the previous/next arrows if there is only one page, for both workapds and templates
maggieghamry
added a commit
that referenced
this pull request
Apr 13, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 14, 2020
* master: (132 commits) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680) Use MapInput type from Maps plugin (elastic#61539) Update to pagination for workpad and templates (elastic#62050) [SIEM] Fix AlertsTable id (elastic#63368) Consistent terminology around cypress test data (elastic#63279) ...
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
Added logic to hide pagination if no Canvas workpads exists, and disable the previous/next arrows if there is only one page, for both workapds and templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57492
>when only 1 page of workpads exists<and>when only 1 page of templates existChecklist
Delete any items that are not applicable to this PR.
For maintainers