[Metrics UI] Refactor With* containers to hooks by simianhacker · Pull Request #59503 · elastic/kibana

simianhacker · 2020-03-06T01:02:09Z

Summary

This PR removes redux and refactors all the With* containers to use hooks. This PR also fixes #59395 by adding the time range to the metadata query (part of WithMetricsTime refactor). I also noticed a few bugs on the metric detail page:

Changing the time range via brushing the chart was broken
The refresh button was broken.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

Closes #60738

elasticmachine · 2020-03-06T01:02:11Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

…nd bad type

…ainers

… on metric detail page; fixes refresh button on metric detail page

…ainers

jasonrhodes

I'll take a look at this 👁

simianhacker · 2020-03-22T22:07:54Z

@elasticmachine merge upstream

jasonrhodes · 2020-03-18T20:52:04Z

test/functional/page_objects/common_page.ts

@@ -287,25 +287,11 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
          }


What's up with the changes in this file?

This is was a test specific hack that Spencer is going to be cleaning up.

jasonrhodes · 2020-03-18T20:52:45Z

test/typings/rison_node.d.ts


 declare module 'rison-node' {
-  export type RisonValue = null | boolean | number | string | RisonObject | RisonArray;
+  export type RisonValue = undefined | null | boolean | number | string | RisonObject | RisonArray;


ugh rison

How was this wrong before, do you understand what happened? Or is this just rison-whack-a-mole :D

rison-whack-a-mole ... undefined is totally valid for Rison values, whoever setup this up just never had a type with option values being set.

OK, I feel like we've edited various versions of this file in various places in Kibana at least 4-5 times since I started, let's just keep whacking this mole for now! 🔨 🔨 🔨

…ainers

simianhacker · 2020-03-30T19:42:20Z

@elasticmachine merge upstream

simianhacker · 2020-04-01T21:46:21Z

@elasticmachine merge upstream

simianhacker · 2020-04-08T13:58:41Z

@elasticmachine merge upstream

simianhacker · 2020-04-09T19:27:21Z

@elasticmachine merge upstream

simianhacker · 2020-04-13T20:15:55Z

@elasticmachine merge upstream

kibanamachine · 2020-04-13T21:58:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 128be61

History

💛 Build #38011 was flaky 29572d1
💚 Build #37279 succeeded d038e88
💚 Build #36353 succeeded d565f9b
💚 Build #35261 succeeded 1fac263
💚 Build #34001 succeeded f39feee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

phillipb

LGTM

* [Metrics UI] Refactor containers to hooks * clean up depends; move useInterval out of useWaffleTime; * converting WithWaffleFilters to useWaffleFilters * Removing WithWaffleOptions * Refactor WithWaffleViewState to useWaffleViewState * Removing obsolete files * Fixing race condition with complext state * Adding undefined to RisonValue; unwinding changes trying to work around bad type * Switching to context * Change assertion to ignore the length of the current URL * Fixing test frameork to accept urls longer then 230 characters * Fixes elastic#59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page * Fixing tests with adding timeRange Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [Metrics UI] Refactor containers to hooks * clean up depends; move useInterval out of useWaffleTime; * converting WithWaffleFilters to useWaffleFilters * Removing WithWaffleOptions * Refactor WithWaffleViewState to useWaffleViewState * Removing obsolete files * Fixing race condition with complext state * Adding undefined to RisonValue; unwinding changes trying to work around bad type * Switching to context * Change assertion to ignore the length of the current URL * Fixing test frameork to accept urls longer then 230 characters * Fixes #59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page * Fixing tests with adding timeRange Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

* [Metrics UI] Refactor containers to hooks * clean up depends; move useInterval out of useWaffleTime; * converting WithWaffleFilters to useWaffleFilters * Removing WithWaffleOptions * Refactor WithWaffleViewState to useWaffleViewState * Removing obsolete files * Fixing race condition with complext state * Adding undefined to RisonValue; unwinding changes trying to work around bad type * Switching to context * Change assertion to ignore the length of the current URL * Fixing test frameork to accept urls longer then 230 characters * Fixes #59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page * Fixing tests with adding timeRange Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

simianhacker added 7 commits March 5, 2020 08:42

[Metrics UI] Refactor containers to hooks

b1bdb90

clean up depends; move useInterval out of useWaffleTime;

9f60ea5

converting WithWaffleFilters to useWaffleFilters

d5dcec1

Removing WithWaffleOptions

c963028

Refactor WithWaffleViewState to useWaffleViewState

3c82d0a

Removing obsolete files

cb7f13f

Fixing race condition with complext state

fd1452a

simianhacker added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 6, 2020

simianhacker added 9 commits March 6, 2020 09:37

Adding undefined to RisonValue; unwinding changes trying to work arou…

c1a8713

…nd bad type

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

b64a837

…ainers

Switching to context

2b5c7ea

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

03a1e5f

…ainers

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

1814b28

…ainers

Change assertion to ignore the length of the current URL

83297b2

Fixing test frameork to accept urls longer then 230 characters

11e9853

Fixes elastic#59395; Refactor WithMetricsTime to hook; Fixes brushing…

3f5d6e1

… on metric detail page; fixes refresh button on metric detail page

Fixing tests with adding timeRange

57eb9e2

simianhacker marked this pull request as ready for review March 10, 2020 18:31

simianhacker requested a review from a team as a code owner March 10, 2020 18:31

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

c2d8345

…ainers

simianhacker mentioned this pull request Mar 12, 2020

[Metrics UI] Reorganize file layout for Metrics UI #60049

Merged

simianhacker added 3 commits March 12, 2020 15:13

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

178ae1a

…ainers

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

049b767

…ainers

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

f39feee

…ainers

jasonrhodes reviewed Mar 18, 2020

View reviewed changes

simianhacker mentioned this pull request Mar 22, 2020

[Metrics UI] Brushing the charts on the node details doesn't change the time interval #60738

Closed

Merge branch 'master' into refactor-containers

1fac263

jasonrhodes reviewed Mar 23, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into refactor-cont…

d565f9b

…ainers

Merge branch 'master' into refactor-containers

d038e88

Merge branch 'master' into refactor-containers

29572d1

Merge branch 'master' into refactor-containers

00d24d9

Merge branch 'master' into refactor-containers

1ba5834

phillipb self-requested a review April 9, 2020 20:08

Merge branch 'master' into refactor-containers

128be61

phillipb approved these changes Apr 14, 2020

View reviewed changes

simianhacker merged commit c2f2a79 into elastic:master Apr 14, 2020

simianhacker mentioned this pull request Apr 14, 2020

[7.x] [Metrics UI] Refactor With* containers to hooks (#59503) #63494

Merged

simianhacker added v7.8.0 and removed v7.7.0 labels Apr 14, 2020

simianhacker deleted the refactor-containers branch April 17, 2024 15:30

		@@ -287,25 +287,11 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
		}

Conversation

simianhacker commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Mar 6, 2020

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

simianhacker commented Mar 22, 2020

Uh oh!

jasonrhodes Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

simianhacker Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

jasonrhodes Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

simianhacker Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

jasonrhodes Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

simianhacker commented Mar 30, 2020

Uh oh!

simianhacker commented Apr 1, 2020

Uh oh!

simianhacker commented Apr 8, 2020

Uh oh!

simianhacker commented Apr 9, 2020

Uh oh!

simianhacker commented Apr 13, 2020

Uh oh!

kibanamachine commented Apr 13, 2020

💚 Build Succeeded

History

Uh oh!

phillipb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

simianhacker commented Mar 6, 2020 •

edited

Loading