Skip to content

[SIEM] Consistent terminology around cypress test data in README#63279

Merged
rylnd merged 1 commit intoelastic:masterfrom
rylnd:cypress_readme
Apr 13, 2020
Merged

[SIEM] Consistent terminology around cypress test data in README#63279
rylnd merged 1 commit intoelastic:masterfrom
rylnd:cypress_readme

Conversation

@rylnd
Copy link
Contributor

@rylnd rylnd commented Apr 10, 2020

Summary

Followup to this conversation.

  • Uses "data" or "test data" when referring to the general idea
  • Uses "archive" when referring to the specific data/implementation
  • Adds a few grammar/spelling tweaks

Checklist

  • Documentation was added for features that require explanation or tutorials

For maintainers

* Uses "data" or "test data" when referring to the general idea
* Uses "archive" when referring to the specific data/implementation
* Adds a few grammar/spelling tweaks
@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 10, 2020
@rylnd rylnd requested review from MadameSheema and spong April 10, 2020 19:38
@rylnd rylnd requested a review from a team as a code owner April 10, 2020 19:38
@rylnd rylnd self-assigned this Apr 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the standardization/consistency updates here! 🙂

@rylnd rylnd merged commit 5559b09 into elastic:master Apr 13, 2020
@rylnd rylnd deleted the cypress_readme branch April 13, 2020 17:24
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 14, 2020
* master: (132 commits)
  document code splitting for client code (elastic#62593)
  Escape single quotes surrounded by double quotes (elastic#63229)
  [Endpoint] Update cli mapping to match endpoint package (elastic#63372)
  update in-app links to metricbeat configuration docs (elastic#63295)
  investigation notes field (documentation / metadata) (elastic#63386)
  [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326)
  [Alerting] set correct parameter for unauthented email action (elastic#63086)
  [Telemetry] force staging urls in tests (elastic#63356)
  Migrate legacy maps service to NP & update refs (elastic#60942)
  Fix task manager query to return tasks to retry (elastic#63360)
  [Endpoint] Policy list support for URL pagination state (elastic#63291)
  [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891)
  [DOCS] Add ILM tutorial (elastic#59502)
  [Maps] Add SOURCE_TYPES enumeration (elastic#62975)
  [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966)
  Move away from npStart for embeddables in canvas (elastic#62680)
  Use MapInput type from Maps plugin (elastic#61539)
  Update to pagination for workpad and templates (elastic#62050)
  [SIEM] Fix AlertsTable id (elastic#63368)
  Consistent terminology around cypress test data (elastic#63279)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 15, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

rylnd added a commit that referenced this pull request Apr 15, 2020
* Uses "data" or "test data" when referring to the general idea
* Uses "archive" when referring to the specific data/implementation
* Adds a few grammar/spelling tweaks
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 15, 2020
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
* Uses "data" or "test data" when referring to the general idea
* Uses "archive" when referring to the specific data/implementation
* Adds a few grammar/spelling tweaks
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants