[Uptime] Remove pings graphql by justinkambic · Pull Request #59392 · elastic/kibana

justinkambic · 2020-03-05T00:13:24Z

Summary

As a part of #58020, this patch seeks to migrate our Pings List component from GraphQL-dependent arch to REST + Redux.

Code is functional but still WIP.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-03-05T00:13:27Z

Pinging @elastic/uptime (Team:uptime)

justinkambic · 2020-04-10T16:31:18Z

it's broken for me on my local, doesn't returns anything

I made the mistake of pushing some commits right after asking for review without checking them, if you re-pull it should work again.

justinkambic · 2020-04-10T19:26:04Z

@shahzad31 this should be ready for re-review.

shahzad31 · 2020-04-13T11:19:46Z

it's still broken for me with 500 Internal server error.

shahzad31 · 2020-04-13T11:39:34Z

x-pack/plugins/uptime/server/lib/requests/get_latest_monitor.ts

+  const decoded = PingType.decode({ ...source, timestamp: source['@timestamp'] });
+  if (isRight(decoded)) {
+    return decoded.right;
+  }
+  throw new Error(JSON.stringify(PathReporter.report(decoded)));


i believe, it doesn't serve any purpose to do runtime validation both on client and server side. what do you think?

shahzad31 · 2020-04-13T11:42:49Z

x-pack/plugins/uptime/server/rest_api/pings/get_pings.ts

+    const { from, to, ...optional } = request.query;
+    const params = GetPingsParamsType.decode({ dateRange: { from, to }, ...optional });
+    if (isLeft(params)) {
+      // eslint-disable-next-line no-console
+      console.error(new Error(PathReporter.report(params).join(';')));
+      return response.badRequest({ body: { message: 'Received invalid request parameters.' } });
+    }


this is also unnecessary, since kibana route schema validation does it auto for all APIs.

👍 I only find it nicer to have typing on the parameters but I agree it's redundant. Wish Kibana schema caused the params to be typed instead of any.

I've already removed it in any case.

…mestamp.

kibanamachine · 2020-04-13T22:21:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 46f856e

History

💔 Build #40489 failed c1aea4a
💚 Build #40221 succeeded 1062e41
💔 Build #40161 failed 55ac2aa
💔 Build #40132 failed adf02e3
💔 Build #40136 failed b0ca803

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31

LGTM !!

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

@timestamp

* WIP replacing GQL with redux/rest. * Finish implementing migration. * Introduce new connected component for ping list. * Replace GraphQL type with io-ts. * Update some broken tests. * Add test for new helper function. * Write test snapshots. * Migrate api tests from graphql to rest. * Update fixtures that rely on pings. * Move ping types to runtime_types folder with rest of io-ts files. * Update Ping type location and imports, type checking. * Remove reliance on fixtures for ping functional API tests. * Fix broken unit tests. * Fix broken types. * Remove local state storage from parent components. * Add functional test to cover Ping List functionality. * Fix monitor page functional test that was broken by merge conflicts. * Fix broken tests. * Fix broken API test. * Replace a test with a describe block that will pre-navigate all tests. * Delete unused reducer keys. * Re-introduce loading to ping list reducer. * Inroduce code that will cause PingList to re-fetch when refresh button is pressed. * Update expanded rows to support multiple concurrent expanded rows. * Modify pingList reducer to have singular optional error field. * Delete unnecessary helper code. * Delete unused interface. * Add runtime_type to parse getPings params, fix pagination index. * Add dedicated monitor type to runtime_types. * Fix broken tests. * Fix broken tests. * Rename '@timestamp' property to 'timestamp' on Ping type. * Fix broken type and key pings list table on document ID instead of timestamp. * Fix broken unit tests. * Fix broken tests and types. * Fix broken functional test.

@timestamp

* WIP replacing GQL with redux/rest. * Finish implementing migration. * Introduce new connected component for ping list. * Replace GraphQL type with io-ts. * Update some broken tests. * Add test for new helper function. * Write test snapshots. * Migrate api tests from graphql to rest. * Update fixtures that rely on pings. * Move ping types to runtime_types folder with rest of io-ts files. * Update Ping type location and imports, type checking. * Remove reliance on fixtures for ping functional API tests. * Fix broken unit tests. * Fix broken types. * Remove local state storage from parent components. * Add functional test to cover Ping List functionality. * Fix monitor page functional test that was broken by merge conflicts. * Fix broken tests. * Fix broken API test. * Replace a test with a describe block that will pre-navigate all tests. * Delete unused reducer keys. * Re-introduce loading to ping list reducer. * Inroduce code that will cause PingList to re-fetch when refresh button is pressed. * Update expanded rows to support multiple concurrent expanded rows. * Modify pingList reducer to have singular optional error field. * Delete unnecessary helper code. * Delete unused interface. * Add runtime_type to parse getPings params, fix pagination index. * Add dedicated monitor type to runtime_types. * Fix broken tests. * Fix broken tests. * Rename '@timestamp' property to 'timestamp' on Ping type. * Fix broken type and key pings list table on document ID instead of timestamp. * Fix broken unit tests. * Fix broken tests and types. * Fix broken functional test.

@timestamp

* WIP replacing GQL with redux/rest. * Finish implementing migration. * Introduce new connected component for ping list. * Replace GraphQL type with io-ts. * Update some broken tests. * Add test for new helper function. * Write test snapshots. * Migrate api tests from graphql to rest. * Update fixtures that rely on pings. * Move ping types to runtime_types folder with rest of io-ts files. * Update Ping type location and imports, type checking. * Remove reliance on fixtures for ping functional API tests. * Fix broken unit tests. * Fix broken types. * Remove local state storage from parent components. * Add functional test to cover Ping List functionality. * Fix monitor page functional test that was broken by merge conflicts. * Fix broken tests. * Fix broken API test. * Replace a test with a describe block that will pre-navigate all tests. * Delete unused reducer keys. * Re-introduce loading to ping list reducer. * Inroduce code that will cause PingList to re-fetch when refresh button is pressed. * Update expanded rows to support multiple concurrent expanded rows. * Modify pingList reducer to have singular optional error field. * Delete unnecessary helper code. * Delete unused interface. * Add runtime_type to parse getPings params, fix pagination index. * Add dedicated monitor type to runtime_types. * Fix broken tests. * Fix broken tests. * Rename '@timestamp' property to 'timestamp' on Ping type. * Fix broken type and key pings list table on document ID instead of timestamp. * Fix broken unit tests. * Fix broken tests and types. * Fix broken functional test.

justinkambic · 2020-04-15T19:58:34Z

Backported to:
7.x/7.8.0 868099e
#63625

justinkambic added 2 commits March 4, 2020 16:39

WIP replacing GQL with redux/rest.

53a351e

Finish implementing migration.

e26f6fb

justinkambic added technical debt Improvement of the software architecture and operational architecture v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Mar 5, 2020

justinkambic self-assigned this Mar 5, 2020

andrewvc mentioned this pull request Mar 5, 2020

[Uptime] Convert remaining GQL endpoints to REST #58020

Closed

4 tasks

justinkambic added 20 commits March 5, 2020 08:50

Merge branch 'master' into uptime_remove-pings-graphql

0f9caf6

Merge branch 'master' into uptime_remove-pings-graphql

ecbe20a

Introduce new connected component for ping list.

48a9990

Merge branch 'master' into uptime_remove-pings-graphql

0bae48a

Replace GraphQL type with io-ts.

76a0158

Merge branch 'master' into uptime_remove-pings-graphql

b7fbc2b

Update some broken tests.

aee6023

Merge branch 'master' into uptime_remove-pings-graphql

451c5a1

Add test for new helper function.

0370e86

Write test snapshots.

1a23bac

Merge branch 'master' into uptime_remove-pings-graphql

5e86c9f

Migrate api tests from graphql to rest.

999cc07

Update fixtures that rely on pings.

69190d1

Merge branch 'master' into uptime_remove-pings-graphql

4635af5

Move ping types to runtime_types folder with rest of io-ts files.

2cd661c

Update Ping type location and imports, type checking.

db88cd1

Remove reliance on fixtures for ping functional API tests.

4937eef

Fix broken unit tests.

d4b53c6

Fix broken types.

8df46a8

Merge branch 'master' into uptime_remove-pings-graphql

d913fd1

justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Mar 26, 2020

justinkambic added 4 commits April 9, 2020 18:35

Modify pingList reducer to have singular optional error field.

0995904

Delete unnecessary helper code.

adf02e3

Delete unused interface.

b0ca803

Add runtime_type to parse getPings params, fix pagination index.

1df28d6

justinkambic mentioned this pull request Apr 10, 2020

[Tech debt] Improve runtime type validation of Ping Histogram elastic/uptime#168

Open

Add dedicated monitor type to runtime_types.

55ac2aa

justinkambic added 4 commits April 10, 2020 12:33

Merge branch 'master' into uptime_remove-pings-graphql

a641bcf

Fix broken tests.

7426fc7

Fix broken tests.

59bc38f

Rename '@timestamp' property to 'timestamp' on Ping type.

1062e41

shahzad31 reviewed Apr 13, 2020

View reviewed changes

justinkambic added 5 commits April 13, 2020 13:28

Fix broken type and key pings list table on document ID instead of ti…

70ecdfa

…mestamp.

Fix broken unit tests.

e7904dc

Merge branch 'master' into uptime_remove-pings-graphql

1418a6d

Fix broken tests and types.

c1aea4a

Fix broken functional test.

46f856e

shahzad31 approved these changes Apr 14, 2020

View reviewed changes

justinkambic merged commit e6095fc into elastic:master Apr 14, 2020

justinkambic mentioned this pull request Apr 15, 2020

[7.x] [Uptime] Remove pings graphql (#59392) #63625

Merged

justinkambic deleted the uptime_remove-pings-graphql branch April 15, 2020 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Remove pings graphql#59392

[Uptime] Remove pings graphql#59392
justinkambic merged 60 commits intoelastic:masterfrom
justinkambic:uptime_remove-pings-graphql

justinkambic commented Mar 5, 2020

Uh oh!

elasticmachine commented Mar 5, 2020

Uh oh!

justinkambic commented Apr 10, 2020

Uh oh!

justinkambic commented Apr 10, 2020

Uh oh!

shahzad31 commented Apr 13, 2020

Uh oh!

shahzad31 Apr 13, 2020

Uh oh!

shahzad31 Apr 13, 2020

Uh oh!

justinkambic Apr 14, 2020

Uh oh!

kibanamachine commented Apr 13, 2020

Uh oh!

shahzad31 left a comment

Uh oh!

justinkambic commented Apr 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

justinkambic commented Mar 5, 2020

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 5, 2020

Uh oh!

justinkambic commented Apr 10, 2020

Uh oh!

justinkambic commented Apr 10, 2020

Uh oh!

shahzad31 commented Apr 13, 2020

Uh oh!

shahzad31 Apr 13, 2020

Choose a reason for hiding this comment

Uh oh!

shahzad31 Apr 13, 2020

Choose a reason for hiding this comment

Uh oh!

justinkambic Apr 14, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 13, 2020

💚 Build Succeeded

History

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Apr 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants