update in-app links to metricbeat configuration docs by graphaelli · Pull Request #63295 · elastic/kibana

graphaelli · 2020-04-10T21:32:05Z

for apm-server, kibana, and beats

Summary

Documentation links for migration to external metricbeat monitoring were 404ing for apm-server, beats, and kibana.

For APM server, we should link to https://www.elastic.co/guide/en/apm/server/current/monitoring-metricbeat-collection.html but keeping this change small and we'll follow up with that cc @bmorelli25.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

for apm-server, kibana, and beats

bmorelli25 · 2020-04-10T22:42:44Z

Thanks for fixing these Gil. I wonder why these 404s aren't being picked up by the docs build anymore? AFAIK, links from Kibana to the documentation should be tested in the elasticsearch-ci/docs check. I think this is the code: https://github.com/elastic/docs/blob/0cee4e4715554515b2e297fe1113708ac03c9cda/build_docs.pl#L334-L399

graphaelli · 2020-04-13T14:26:13Z

Thanks for opening that follow up, I'm glad to see there is some automation around checking these.

graphaelli · 2020-04-13T14:29:37Z

@elastic/stack-monitoring-ui The logstash links are incorrect as well - is https://www.elastic.co/guide/en/logstash/current/monitoring-with-metricbeat.html the right place?

chrisronline · 2020-04-13T14:37:37Z

Yes, great finds @graphaelli!

chrisronline · 2020-04-13T14:50:45Z

@graphaelli PR looks great so far. If you could get update that logstash link, that'd be great

bmorelli25 · 2020-04-13T15:47:49Z

These links are also broken in Kibana v7.6 and v7.5. I requested redirects (https://github.com/elastic/website-www.elastic.co/issues/5916) to fix those versions of Kibana. Will this change make it in to 7.7? Or do we need redirects there as well?

graphaelli · 2020-04-13T18:54:20Z

@bmorelli25 Great call on those redirects. Let's do the same for 7.7 and target this change for 7.7.1+

chrisronline

LGTM!

bmorelli25 · 2020-04-13T19:19:35Z

Redirects are live for 7.6 and 7.5 documentation.

Opened https://github.com/elastic/website-www.elastic.co/issues/5918 to track 7.7 redirects.

kibanamachine · 2020-04-13T23:17:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fdc65fa

History

💔 Build #40483 failed 3ec5e4f
💔 Build #40408 failed 5e953e4
💔 Build #40255 failed 1eac7d3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (132 commits) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680) Use MapInput type from Maps plugin (elastic#61539) Update to pagination for workpad and templates (elastic#62050) [SIEM] Fix AlertsTable id (elastic#63368) Consistent terminology around cypress test data (elastic#63279) ...

* master: document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) [Maps] fix bug where toggling Scaling type does not re-fetch data (elastic#63326) [Alerting] set correct parameter for unauthented email action (elastic#63086) [Telemetry] force staging urls in tests (elastic#63356) Migrate legacy maps service to NP & update refs (elastic#60942) Fix task manager query to return tasks to retry (elastic#63360) [Endpoint] Policy list support for URL pagination state (elastic#63291) [Canvas] Migrate saved object mappings and migrations to Kibana Platform (elastic#58891) [DOCS] Add ILM tutorial (elastic#59502) [Maps] Add SOURCE_TYPES enumeration (elastic#62975) [Maps] update geospatial filters to use geo_shape query for geo_point fields (elastic#62966) Move away from npStart for embeddables in canvas (elastic#62680)

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

update in-app links to metricbeat configuration docs

1eac7d3

for apm-server, kibana, and beats

graphaelli added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring labels Apr 10, 2020

graphaelli requested a review from a team April 10, 2020 21:32

graphaelli added the v7.7.0 label Apr 10, 2020

bmorelli25 mentioned this pull request Apr 10, 2020

Kibana link checking is broken elastic/docs#1805

Closed

graphaelli added 2 commits April 13, 2020 10:24

revert es link change

fa3fa57

Merge branch 'master' into fix-metricbeat-monitoring-links

5e953e4

graphaelli added v7.7.1 and removed v7.7.0 labels Apr 13, 2020

update logstash metricbeat monitoring doc link

3ec5e4f

chrisronline approved these changes Apr 13, 2020

View reviewed changes

fix test expectations

fdc65fa

graphaelli merged commit 5bc539c into elastic:master Apr 14, 2020

graphaelli deleted the fix-metricbeat-monitoring-links branch April 14, 2020 02:06

This was referenced Apr 14, 2020

[7.x] update in-app links to metricbeat configuration docs (#63295) #63433

Merged

[7.7] update in-app links to metricbeat configuration docs (#63295) #63434

Merged

graphaelli added a commit to graphaelli/kibana that referenced this pull request Apr 14, 2020

update in-app links to metricbeat configuration docs (elastic#63295)

394abf5

graphaelli added a commit that referenced this pull request Apr 15, 2020

update in-app links to metricbeat configuration docs (#63295) (#63433)

2f12e1d

graphaelli added a commit that referenced this pull request Apr 15, 2020

update in-app links to metricbeat configuration docs (#63295) (#63434)

fe7859b

wayneseymour pushed a commit that referenced this pull request Apr 15, 2020

update in-app links to metricbeat configuration docs (#63295)

77b7caa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update in-app links to metricbeat configuration docs#63295

update in-app links to metricbeat configuration docs#63295
graphaelli merged 5 commits intoelastic:masterfrom
graphaelli:fix-metricbeat-monitoring-links

graphaelli commented Apr 10, 2020 •

edited

Loading

Uh oh!

bmorelli25 commented Apr 10, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

chrisronline commented Apr 13, 2020

Uh oh!

chrisronline commented Apr 13, 2020

Uh oh!

bmorelli25 commented Apr 13, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

chrisronline left a comment

Uh oh!

bmorelli25 commented Apr 13, 2020

Uh oh!

kibanamachine commented Apr 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

graphaelli commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

bmorelli25 commented Apr 10, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

chrisronline commented Apr 13, 2020

Uh oh!

chrisronline commented Apr 13, 2020

Uh oh!

bmorelli25 commented Apr 13, 2020

Uh oh!

graphaelli commented Apr 13, 2020

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

bmorelli25 commented Apr 13, 2020

Uh oh!

kibanamachine commented Apr 13, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

graphaelli commented Apr 10, 2020 •

edited

Loading