[data.search.aggs] Remove service getters from agg types (AggConfig part)#62548
Merged
VladLasitsa merged 10 commits intoelastic:masterfrom Apr 15, 2020
Merged
[data.search.aggs] Remove service getters from agg types (AggConfig part)#62548VladLasitsa merged 10 commits intoelastic:masterfrom
VladLasitsa merged 10 commits intoelastic:masterfrom
Conversation
VladLasitsa
force-pushed
the
#60333_agg_config
branch
from
fd858d9 to
497dfa2
Compare
VladLasitsa
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukeelmers
reviewed
Apr 8, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
haven't done a full review yet, just added an initial comment
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@lukeelmers, Could you please review again? |
lukeelmers
approved these changes
Apr 14, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Two nits, otherwise code LGTM!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Apr 15, 2020
…art) (elastic#62548) * removed getFieldFormats from aggConfig * made new properties is private * Fixed ci * Fixed tests * Fixes clone method * move filedFotmats inside opt fro AggConfigs * Added readonly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 15, 2020
* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...
alexwizp
pushed a commit
that referenced
this pull request
Apr 15, 2020
…art) (#62548) (#63550) * removed getFieldFormats from aggConfig * made new properties is private * Fixed ci * Fixed tests * Fixes clone method * move filedFotmats inside opt fro AggConfigs * Added readonly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
…art) (#62548) * removed getFieldFormats from aggConfig * made new properties is private * Fixed ci * Fixed tests * Fixes clone method * move filedFotmats inside opt fro AggConfigs * Added readonly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #60333
Checklist
Delete any items that are not applicable to this PR.
For maintainers