Disable adding conditions when in alert management context.#63514
Merged
phillipb merged 4 commits intoelastic:masterfrom Apr 14, 2020
Merged
Disable adding conditions when in alert management context.#63514phillipb merged 4 commits intoelastic:masterfrom
phillipb merged 4 commits intoelastic:masterfrom
Conversation
phillipb
added
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
phillipb
changed the title
…e-alert-management-screen-better
phillipb
added
the
release_note:skip
x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 15, 2020
* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 15, 2020
…63514) * Disable adding conditions when in alert manament context. * Fix typo * Change id for i18n string
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 15, 2020
…63514) * Disable adding conditions when in alert manament context. * Fix typo * Change id for i18n string
phillipb
added a commit
that referenced
this pull request
Apr 15, 2020
phillipb
added a commit
that referenced
this pull request
Apr 15, 2020
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Disable adding conditions when in alert manament context. * Fix typo * Change id for i18n string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds better handling for metric threshold alerts on the kibana alert management screen. Currently, there is an issue fetching metric field names. To work around this issue, we've disabled editing the metric name, and adding an alert condition. There is also now a callout with a link to redirect users to metrics explorer for creating new Metric Threshold alerts. This will NOT affect adding conditions from metrics explorer.
In 7.8, we'll support this much better. We need to port our source configuration over from graphql to a standard rest api. Once that's done, we will then be able to fetch the metric fields from anywhere in kibana.
Checklist
Delete any items that are not applicable to this PR.