[UII] Fix integration card row height calculation#264212
Merged
jen-huang merged 3 commits intoelastic:mainfrom Apr 18, 2026
Merged
[UII] Fix integration card row height calculation#264212jen-huang merged 3 commits intoelastic:mainfrom
jen-huang merged 3 commits intoelastic:mainfrom
Conversation
jen-huang
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
ApprovabilityVerdict: Would Approve Minor UI bug fix for integration card row height calculation. Changes are limited to layout adjustments (recalculating row heights, removing spacers/padding) with no business logic impact. The author owns all modified files. Macroscope would have approved this PR. A repo admin can enable approvability here. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @jen-huang |
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24611738026 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 18, 2026
## Summary Resolves elastic#259200. This PR re-computes card row height when list of card changes. I changed dependency array back to `list` because `list.length` does not capture all list changes, for example the row heights were not being recomputed when sorting is changed from `A-Z` to `Z-A` (the same condensing issue appears prior to these changes). PR also removes some unnecessary padding around the sidebar and card list, so that margins are even around the page and between elements. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 6bf3385)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 18, 2026
…64270) # Backport This will backport the following commits from `main` to `9.4`: - [[UII] Fix integration card row height calculation (#264212)](#264212) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2026-04-18T19:04:13Z","message":"[UII] Fix integration card row height calculation (#264212)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/259200.\n\nThis PR re-computes card row height when list of card changes. I changed\ndependency array back to `list` because `list.length` does not capture\nall list changes, for example the row heights were not being recomputed\nwhen sorting is changed from `A-Z` to `Z-A` (the same condensing issue\nappears prior to these changes).\n\nPR also removes some unnecessary padding around the sidebar and card\nlist, so that margins are even around the page and between elements.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"6bf3385ba8bd09939e67a846c4131299f52e6f93","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:version","v9.4.0","v9.5.0"],"title":"[UII] Fix integration card row height calculation","number":264212,"url":"https://github.com/elastic/kibana/pull/264212","mergeCommit":{"message":"[UII] Fix integration card row height calculation (#264212)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/259200.\n\nThis PR re-computes card row height when list of card changes. I changed\ndependency array back to `list` because `list.length` does not capture\nall list changes, for example the row heights were not being recomputed\nwhen sorting is changed from `A-Z` to `Z-A` (the same condensing issue\nappears prior to these changes).\n\nPR also removes some unnecessary padding around the sidebar and card\nlist, so that margins are even around the page and between elements.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"6bf3385ba8bd09939e67a846c4131299f52e6f93"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/264212","number":264212,"mergeCommit":{"message":"[UII] Fix integration card row height calculation (#264212)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/259200.\n\nThis PR re-computes card row height when list of card changes. I changed\ndependency array back to `list` because `list.length` does not capture\nall list changes, for example the row heights were not being recomputed\nwhen sorting is changed from `A-Z` to `Z-A` (the same condensing issue\nappears prior to these changes).\n\nPR also removes some unnecessary padding around the sidebar and card\nlist, so that margins are even around the page and between elements.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"6bf3385ba8bd09939e67a846c4131299f52e6f93"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Apr 19, 2026
* main: (114 commits) Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint (elastic#263334) init on install (elastic#263732) [One Workflow] fail-fast TaskRecovery for interrupted runs (elastic#261275) [Entity Store] Reset state error after successful task run (elastic#263087) [api-docs] 2026-04-19 Daily api_docs build (elastic#264280) [UII] Fix integration card row height calculation (elastic#264212) [scout] migrate FTR logstash api tests (elastic#262953) [StorageIndexAdapter] Set auto_expand_replicas to fix yellow health on single-node ES clusters (elastic#263096) [api-docs] 2026-04-18 Daily api_docs build (elastic#264260) [Scout] Update test config manifests (elastic#264257) [Security Solution][Detection Engine] enables AI rule creation feature flag (elastic#264036) [dashboards as code] only validate id on PUT route when creating new dashboard (elastic#264161) chore(NA): bump version to 9.5.0 (elastic#262165) skip failing test suite (elastic#263649) skip failing test suite (elastic#264236) [Discover] Convert remaining Enzyme tests to RTL (elastic#259676) auto-implement: Labels in model endpoints table of the model details flyout look misaligned (elastic#263770) [ci] Promote ES docker image after verification (elastic#263890) [Observability:Onboarding] Remove suppress global announcements that was breaking ensemble tests (elastic#264169) [Cases][AttachmentV2] Migrate persistable state part 2 - ML and AIOps charts (elastic#262597) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #259200.
This PR re-computes card row height when list of card changes. I changed dependency array back to
listbecauselist.lengthdoes not capture all list changes, for example the row heights were not being recomputed when sorting is changed fromA-ZtoZ-A(the same condensing issue appears prior to these changes).PR also removes some unnecessary padding around the sidebar and card list, so that margins are even around the page and between elements.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.