init on install by chennn1990 · Pull Request #263732 · elastic/kibana

chennn1990 · 2026-04-16T11:10:14Z

Install now runs entity maintainer initialization whenever a real install happens (assetManager.init followed by entityMaintainersClient.init), so maintainer tasks are scheduled as part of the install path instead of only via a separate init call.

macroscopeapp · 2026-04-16T11:11:10Z

Catch flakiness early (recommended)

Recommended before merge: run the flaky test runner against this PR to catch flakiness early.

Trigger a run with the Flaky Test Runner UI or post this comment on the PR:

/flaky scoutConfig:x-pack/solutions/security/plugins/entity_store/test/scout/api/playwright.config.ts:30

This check is experimental. Share your feedback in the #appex-qa channel.

^{Posted via Macroscope — Flaky Test Runner nudge}

macroscopeapp

Scout Test Review

🔴 Blocker

apiTest.only left in committed code — this will skip every other test in the suite when the file runs.

^{Posted via Macroscope — Scout Test Review}

uri-weisman · 2026-04-16T11:20:55Z

@coderabbitai full review

coderabbitai · 2026-04-16T11:21:01Z

✅ Actions performed

Full review triggered.

uri-weisman · 2026-04-16T11:29:50Z

If we are in a non default space and entity store is running, we'll not init the entity maintainers framework in case of a new maintainer was introduced.

…thub.com/chennn1990/kibana into entity-store/init-maintainers-on-install

coderabbitai · 2026-04-16T11:51:03Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-04-16T11:53:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a95fa88-895b-4e7f-8e93-a53b9ee2036a

📥 Commits

Reviewing files that changed from the base of the PR and between 1176416 and 7faec77.

📒 Files selected for processing (4)

x-pack/solutions/security/plugins/entity_store/public/hooks/useInstallEntityStoreV2.test.tsx
x-pack/solutions/security/plugins/entity_store/public/hooks/useInstallEntityStoreV2.tsx
x-pack/solutions/security/plugins/entity_store/server/routes/apis/install/index.ts
x-pack/solutions/security/plugins/entity_store/test/scout/api/tests/install_update.spec.ts

📝 Walkthrough

Walkthrough

The changes refactor Entity Store V2 installation to shift entity maintainers initialization from the client-side hook to the server-side install route handler. The useInstallEntityStoreV2 hook no longer calls ENTITY_MAINTAINERS_INIT directly; instead, the install route now calls entityMaintainersClient.init() after asset initialization completes. Control flow logic in non-default spaces was adjusted to check for v1 installation only when v2 is not already present. Test expectations were updated to verify the new HTTP call sequencing and that entity maintainers are initialized server-side with taskStatus === 'started'.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-04-16T12:21:03Z

✅ Actions performed

Full review triggered.

…aintainer After PR #263732 (init on install), entity maintainers are initialized during the Entity Store install flow. The CSV upload test relied on maintainers not being initialized, causing a race condition where the automated-resolution maintainer links entities before the test can assert. Stop the maintainer explicitly in the before hook with a try/catch for backward compatibility.

macroscopeapp

👍 Positive reinforcement — The new maintainers verification block in the install happy-path test is well-structured: it validates the response body (not just the status code), reuses INTERNAL_HEADERS and ENTITY_STORE_ROUTES from the shared constants file, and properly types the response. The apiTest.only blocker from the prior review has been fixed. Nice work!

^{Posted via Macroscope — Scout Test Review}

macroscopeapp · 2026-04-19T07:21:48Z

      const uninstall = await apiClient.post(ENTITY_STORE_ROUTES.public.UNINSTALL, {
        headers: defaultHeaders,


⚪ Nit — Validate the response body

expect(maintainers.every(…)).toBe(true) reduces the whole array to a single boolean, so a failure says "expected false to be true" with no indication of which maintainer has a wrong status. Asserting per-element gives a much better diagnostic:

Suggested change

const uninstall = await apiClient.post(ENTITY_STORE_ROUTES.public.UNINSTALL, {

headers: defaultHeaders,

expect(maintainers.length).toBeGreaterThan(0);

for (const m of maintainers) {

expect(m.taskStatus).toBe('started');

}

^{Posted via Macroscope — Scout Test Review}

elasticmachine · 2026-04-19T11:03:03Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: f3c459f

Failed CI Steps

History

cc @chennn1990

ymao1

Entity analytics changes LGTM. Code review of test changes only. Could we run the flaky test runner on these tests?

kibanamachine · 2026-04-19T14:27:32Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/24631353870

chennn1990 · 2026-04-19T14:34:50Z

Entity analytics changes LGTM. Code review of test changes only. Could we run the flaky test runner on these tests?

@ymao1 yes, green run

Install now runs entity maintainer initialization whenever a real install happens (assetManager.init followed by entityMaintainersClient.init), so maintainer tasks are scheduled as part of the install path instead of only via a separate init call. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ed3bbba)

kibanamachine · 2026-04-19T14:35:52Z

💚 All backports created successfully

Status	Branch	Result
✅	9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* main: (114 commits) Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint (elastic#263334) init on install (elastic#263732) [One Workflow] fail-fast TaskRecovery for interrupted runs (elastic#261275) [Entity Store] Reset state error after successful task run (elastic#263087) [api-docs] 2026-04-19 Daily api_docs build (elastic#264280) [UII] Fix integration card row height calculation (elastic#264212) [scout] migrate FTR logstash api tests (elastic#262953) [StorageIndexAdapter] Set auto_expand_replicas to fix yellow health on single-node ES clusters (elastic#263096) [api-docs] 2026-04-18 Daily api_docs build (elastic#264260) [Scout] Update test config manifests (elastic#264257) [Security Solution][Detection Engine] enables AI rule creation feature flag (elastic#264036) [dashboards as code] only validate id on PUT route when creating new dashboard (elastic#264161) chore(NA): bump version to 9.5.0 (elastic#262165) skip failing test suite (elastic#263649) skip failing test suite (elastic#264236) [Discover] Convert remaining Enzyme tests to RTL (elastic#259676) auto-implement: Labels in model endpoints table of the model details flyout look misaligned (elastic#263770) [ci] Promote ES docker image after verification (elastic#263890) [Observability:Onboarding] Remove suppress global announcements that was breaking ensemble tests (elastic#264169) [Cases][AttachmentV2] Migrate persistable state part 2 - ML and AIOps charts (elastic#262597) ...

kibanamachine · 2026-04-20T14:49:25Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @chennn1990

kibanamachine · 2026-04-21T14:49:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @chennn1990

# Backport This will backport the following commits from `main` to `9.4`: - [init on install (#263732)](#263732)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Chen Ashuri <chen.ashuri@elastic.co>

init on install

176cf11

chennn1990 self-assigned this Apr 16, 2026

chennn1990 requested a review from a team as a code owner April 16, 2026 11:10

chennn1990 added the release_note:skip Skip the PR/issue when compiling release notes label Apr 16, 2026

chennn1990 linked an issue Apr 16, 2026 that may be closed by this pull request

Entity maintainers are not initialized when enabling Entity Store in non-default Kibana space #263728

Closed

macroscopeapp Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread x-pack/solutions/security/plugins/entity_store/test/scout/api/tests/install_update.spec.ts Outdated

uri-weisman added backport:version Backport to applied version labels v9.4.0 labels Apr 16, 2026

remove only

52beff2

uri-weisman requested changes Apr 16, 2026

View reviewed changes

kibanamachine and others added 3 commits April 16, 2026 11:48

Changes from node scripts/eslint_all_files --no-cache --fix

fb6636c

fix non default space init maintainers on cv2 installed

a624f44

Merge branch 'entity-store/init-maintainers-on-install' of https://gi…

7faec77

…thub.com/chennn1990/kibana into entity-store/init-maintainers-on-install

uri-weisman reviewed Apr 16, 2026

View reviewed changes

Comment thread x-pack/solutions/security/plugins/entity_store/server/routes/apis/install/index.ts

uri-weisman approved these changes Apr 16, 2026

View reviewed changes

chennn1990 added 2 commits April 16, 2026 17:08

Merge branch 'main' into entity-store/init-maintainers-on-install

106e36e

Merge branch 'main' into entity-store/init-maintainers-on-install

251316a

maxcold mentioned this pull request Apr 17, 2026

[Entity Analytics] Fix CSV upload test to stop automated-resolution maintainer #264061

Closed

9 tasks

chennn1990 added 2 commits April 19, 2026 10:11

Merge branch 'main' into entity-store/init-maintainers-on-install

6dd06a9

stop resolution maintainer

be18d03

chennn1990 requested review from a team as code owners April 19, 2026 07:19

chennn1990 requested a review from ymao1 April 19, 2026 07:19

macroscopeapp Bot reviewed Apr 19, 2026

View reviewed changes

stop risk-score for testing

f3c459f

add stopMaintainer abillity

28c66c6

chennn1990 enabled auto-merge (squash) April 19, 2026 12:36

ymao1 approved these changes Apr 19, 2026

View reviewed changes

chennn1990 merged commit ed3bbba into elastic:main Apr 19, 2026
20 checks passed

kibanamachine added the v9.5.0 label Apr 19, 2026

kibanamachine mentioned this pull request Apr 19, 2026

[9.4] init on install (#263732) #264289

Merged

kibanamachine mentioned this pull request Apr 20, 2026

chore: remove trigger unsupported ftr tests #264105

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 20, 2026

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2026

		const uninstall = await apiClient.post(ENTITY_STORE_ROUTES.public.UNINSTALL, {
		headers: defaultHeaders,

-      const uninstall = await apiClient.post(ENTITY_STORE_ROUTES.public.UNINSTALL, {
-        headers: defaultHeaders,
+      expect(maintainers.length).toBeGreaterThan(0);
+      for (const m of maintainers) {
+        expect(m.taskStatus).toBe('started');
+      }

Conversation

chennn1990 commented Apr 16, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot commented Apr 16, 2026

Catch flakiness early (recommended)

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Scout Test Review

🔴 Blocker

Uh oh!

Uh oh!

uri-weisman commented Apr 16, 2026

Uh oh!

coderabbitai Bot commented Apr 16, 2026

Uh oh!

uri-weisman Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Apr 16, 2026

Uh oh!

coderabbitai Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

coderabbitai Bot commented Apr 16, 2026

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Apr 19, 2026

Uh oh!

chennn1990 commented Apr 19, 2026

Uh oh!

kibanamachine commented Apr 19, 2026

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Apr 20, 2026

Uh oh!

kibanamachine commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chennn1990 commented Apr 16, 2026 •

edited by kibanamachine

Loading

coderabbitai Bot commented Apr 16, 2026 •

edited

Loading

elasticmachine commented Apr 19, 2026 •

edited

Loading