Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint by yuliia-fryshko · Pull Request #263334 · elastic/kibana

yuliia-fryshko · 2026-04-15T09:34:00Z

Closes https://github.com/elastic/obs-ai-team/issues/564

Replaced actionsClient.get() with getConnectorByIdWithoutClientRequest() from the inference plugin to resolve connector info for analytics. The old method only worked for traditional action connectors, not inference endpoints, causing the connector to be undefined and the EBT schema validation to fail.

Test Plan:

Open Observability AI Assistant;
Ask any question, like "Do I have any alerts?"
3.Check that in the logs there is no errors like
"message": "Failed to validate payload coming from \"Event Type 'observability_ai_assistant_tool_call'\":\n\t- [connector]: {\"expected\":\"{ connectorId: string, name: string, type: string, modelFamily: string, modelProvider: string, modelId?: string }\",\"actual\":\"undefined\",\"value\":\"undefined\"}"}

…an inference endpoint

elasticmachine · 2026-04-15T09:34:08Z

Pinging @elastic/obs-ai-team (Team:obs-ai)

github-actions · 2026-04-15T09:34:13Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

viduni94 · 2026-04-15T16:38:34Z

  InferenceClient,
 } from '@kbn/inference-common';
 import { ToolChoiceType } from '@kbn/inference-common';
+import { getConnectorByIdWithoutClientRequest } from '@kbn/inference-plugin/server/util/get_connector_by_id';


I don't think we should do a deep import like this to a inference plugin server util.
The getConnectorByIdWithoutClientRequest is exposed via the inference plugin's start contract (InferenceServerStart). We should add a dependancy to the start contract (if it doesn't exist already) and use this function via that:

await inference.getConnectorByIdWithoutClientRequest(..)

Thanks, Viduni! I replaced the deep import from @kbn/inference-plugin/server/util/get_connector_by_id with a type import of InferenceServerStart from @kbn/inference-plugin/server

viduni94 · 2026-04-15T16:41:10Z

-          scopes,
-        });
+        const connectorInfo = getInferenceConnectorInfo(connector);
+        if (connectorInfo) {


Why are we adding this check? Isn't connectorInfo returned even when inference endpoints are used?

We pass connector? as optional. That’s why, when it’s undefined, the inference connector returns undefined as well .

Hmmm, I don't get it.. Shouldn't there be a valid connector to reach this point?
If the connector didn't exist, the chat() calls would fail long before any tool execution happens.
By adding this condition it masks a scenario that shouldn't happen silently and we wouldn't catch any regressions in the future like we did with this case after the inference feature registry changes.

The better approach is: since the connector must exist for the conversation to work, if getConnectorById fails it's an unexpected error worth logging, and the analytics event should still be reported (the toolName and scopes data is valuable regardless).

Therefore, I think this guard should be removed and the original unconditional reporting should be restored (The related test for this says "handles missing connector gracefully") . The real fix is already done via getConnectorById which correctly resolves inference endpoints, so connector won't be undefined in a normal operation.

Does that make sense?

Yes, I agree that it would be better to remove this case, as it could hide some broken scenarios. I also believe that if there is no connector, it should fail earlier.

…er/service/client/operators/continue_conversation.ts Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

viduni94 · 2026-04-17T13:44:08Z

  simulateFunctionCalling: boolean;
  analytics: AnalyticsServiceStart;
-  connector?: Connector;
+  connector?: InferenceConnectorType;


Is this correct?
Or should it be InferenceConnector?

viduni94 · 2026-04-17T14:07:11Z

      const connector$ = defer(() =>
        from(
-          this.dependencies.actionsClient.get({
-            id: connectorId,
-            throwIfSystemAction: true,
-          })
+          this.dependencies.inference.getConnectorByIdWithoutClientRequest(
+            connectorId,
+            this.dependencies.actionsClient,
+            this.dependencies.esClient.asInternalUser
+          )
        ).pipe(
          catchError((error) => {
            this.dependencies.logger.debug(
              `Failed to fetch connector for analytics: ${error.message}`
            );
            return of(undefined);
          }),
          shareReplay()
        )
      );


After adding https://github.com/elastic/kibana/pull/263334/changes#r3100903510 you could do:

const connector$ = defer(() => from(this.dependencies.getConnectorById(connectorId)).pipe( catchError((error) => { this.dependencies.logger.debug( `Failed to fetch connector for analytics: ${error.message}` ); return of(undefined); }), shareReplay() ) );

viduni94 · 2026-04-17T14:15:42Z

-          scopes,
-        });
+        const connectorInfo = getInferenceConnectorInfo(connector);
+        if (connectorInfo) {


Hmmm, I don't get it.. Shouldn't there be a valid connector to reach this point?
If the connector didn't exist, the chat() calls would fail long before any tool execution happens.
By adding this condition it masks a scenario that shouldn't happen silently and we wouldn't catch any regressions in the future like we did with this case after the inference feature registry changes.

The better approach is: since the connector must exist for the conversation to work, if getConnectorById fails it's an unexpected error worth logging, and the analytics event should still be reported (the toolName and scopes data is valuable regardless).

Therefore, I think this guard should be removed and the original unconditional reporting should be restored (The related test for this says "handles missing connector gracefully") . The real fix is already done via getConnectorById which correctly resolves inference endpoints, so connector won't be undefined in a normal operation.

Does that make sense?

Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

viduni94 · 2026-04-17T16:17:39Z

-        scopes: ['all'],
-      })
-    );
+    expect(mockAnalytics.reportEvent).not.toHaveBeenCalled();


This test should be restored to the previous

elastic-vault-github-plugin-prod · 2026-04-18T00:50:09Z

Run Metadata

Triggered by: Issue #220
Elasticsearch image tag: 9.4.0-SNAPSHOT
Kibana image: docker.elastic.co/kibana-ci/kibana-serverless:pr-263334-787c7fad8ccc
Date: 2026-04-18
PR: elastic/kibana#263334 — Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint
Mode: PR-targeted (journeys generated from PR diff)
Journeys executed: 8
Passed: 8
Errored: 0
Findings: 0 bugs, 0 warnings, 0 info

Findings

No findings -- all journeys completed without issues.

Screenshots

Screenshots are available in the workflow artifacts.

Workflow run: https://github.com/elastic/kibana-exploratory-testing/actions/runs/24592831729

kibanamachine · 2026-04-19T15:14:35Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/24632273392

…an inference endpoint (elastic#263334) Closes elastic/obs-ai-team#564 Replaced `actionsClient.get()` with `getConnectorByIdWithoutClientRequest()` from the inference plugin to resolve connector info for analytics. The old method only worked for traditional action connectors, not inference endpoints, causing the connector to be undefined and the EBT schema validation to fail. **Test Plan:** 1. Open Observability AI Assistant; 2. Ask any question, like "Do I have any alerts?" 3.Check that in the logs there is no errors like `"message": "Failed to validate payload coming from \"Event Type 'observability_ai_assistant_tool_call'\":\n\t- [connector]: {\"expected\":\"{ connectorId: string, name: string, type: string, modelFamily: string, modelProvider: string, modelId?: string }\",\"actual\":\"undefined\",\"value\":\"undefined\"}"}` --------- Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d0e1774)

kibanamachine · 2026-04-19T15:22:41Z

💚 All backports created successfully

Status	Branch	Result
✅	9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* main: (114 commits) Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint (elastic#263334) init on install (elastic#263732) [One Workflow] fail-fast TaskRecovery for interrupted runs (elastic#261275) [Entity Store] Reset state error after successful task run (elastic#263087) [api-docs] 2026-04-19 Daily api_docs build (elastic#264280) [UII] Fix integration card row height calculation (elastic#264212) [scout] migrate FTR logstash api tests (elastic#262953) [StorageIndexAdapter] Set auto_expand_replicas to fix yellow health on single-node ES clusters (elastic#263096) [api-docs] 2026-04-18 Daily api_docs build (elastic#264260) [Scout] Update test config manifests (elastic#264257) [Security Solution][Detection Engine] enables AI rule creation feature flag (elastic#264036) [dashboards as code] only validate id on PUT route when creating new dashboard (elastic#264161) chore(NA): bump version to 9.5.0 (elastic#262165) skip failing test suite (elastic#263649) skip failing test suite (elastic#264236) [Discover] Convert remaining Enzyme tests to RTL (elastic#259676) auto-implement: Labels in model endpoints table of the model details flyout look misaligned (elastic#263770) [ci] Promote ES docker image after verification (elastic#263890) [Observability:Onboarding] Remove suppress global announcements that was breaking ensemble tests (elastic#264169) [Cases][AttachmentV2] Migrate persistable state part 2 - ML and AIOps charts (elastic#262597) ...

…or is an inference endpoint (#263334) (#264292) # Backport This will backport the following commits from `main` to `9.4`: - [Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint (#263334)](#263334)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Yuliia Fryshko <yuliia.fryshko@elastic.co> Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

Fix observability_ai_assistant_tool_call EBT error when connector is …

022fa76

…an inference endpoint

yuliia-fryshko self-assigned this Apr 15, 2026

yuliia-fryshko added the release_note:skip Skip the PR/issue when compiling release notes label Apr 15, 2026

yuliia-fryshko requested a review from a team as a code owner April 15, 2026 09:34

yuliia-fryshko added backport:version Backport to applied version labels v9.4.0 labels Apr 15, 2026

botelastic Bot added ci:project-deploy-observability Create an Observability project Team:obs-ai Observability AI team labels Apr 15, 2026

yuliia-fryshko added 2 commits April 15, 2026 11:34

Merge branch 'main' into fix-observability-ai-assistant-tool-call-ebt

a4f6ca8

Merge branch 'main' into fix-observability-ai-assistant-tool-call-ebt

80b8fef

viduni94 reviewed Apr 15, 2026

View reviewed changes

yuliia-fryshko and others added 4 commits April 17, 2026 11:51

Update x-pack/platform/plugins/shared/observability_ai_assistant/serv…

2b3fe3a

…er/service/client/operators/continue_conversation.ts Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

Changes from node scripts/eslint_all_files --no-cache --fix

19f6dd2

fixed review comments

a3696f2

removed typo

023e4fc

viduni94 reviewed Apr 17, 2026

View reviewed changes

yuliia-fryshko and others added 2 commits April 17, 2026 17:32

Remove unneeded condition

a06aa07

Apply suggestion from @viduni94

22fad1b

Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

macroscopeapp Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread ...s/shared/observability_ai_assistant/server/service/client/operators/continue_conversation.ts

fixed review comments

28da89b

viduni94 reviewed Apr 17, 2026

View reviewed changes

viduni94 approved these changes Apr 17, 2026

View reviewed changes

yuliia-fryshko added 4 commits April 17, 2026 19:06

reverted test

8813e09

Merge branch 'main' into fix-observability-ai-assistant-tool-call-ebt

c40517f

fix test

35143de

Merge branch 'main' into fix-observability-ai-assistant-tool-call-ebt

787c7fa

This comment was marked as outdated.

Sign in to view

yuliia-fryshko merged commit d0e1774 into elastic:main Apr 19, 2026
18 checks passed

kibanamachine added the v9.5.0 label Apr 19, 2026

kibanamachine mentioned this pull request Apr 19, 2026

[9.4] Fix observability_ai_assistant_tool_call EBT error when connector is an inference endpoint (#263334) #264292

Merged

kibanamachine mentioned this pull request Apr 20, 2026

chore: remove trigger unsupported ftr tests #264105

Merged

Conversation

yuliia-fryshko commented Apr 15, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

🤖 GitHub comments

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

viduni94 Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

viduni94 Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

elastic-vault-github-plugin-prod Bot commented Apr 18, 2026

Run Metadata

Findings

Screenshots

Uh oh!

Uh oh!

kibanamachine commented Apr 19, 2026

Uh oh!

kibanamachine commented Apr 19, 2026

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuliia-fryshko commented Apr 15, 2026 •

edited by kibanamachine

Loading

viduni94 Apr 17, 2026 •

edited

Loading

viduni94 Apr 17, 2026 •

edited

Loading