Skip to content

[UII] Fix integration card row height calculation #264212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jen-huang merged 3 commits into from
Apr 18, 2026
Merged

[UII] Fix integration card row height calculation #264212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f96f13f
Recompute row heights on card list change
jen-huang Apr 17, 2026
464011f
Change dependency array back to `list`
jen-huang Apr 17, 2026
9834259
Remove extra padding to bring sidebar and cards into alignment
jen-huang Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...fleet/public/applications/integrations/sections/epm/components/package_list_grid/grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ export const GridColumn = ({
})
);

// Reset the row measurement cache when the list changes
// Reset the row measurement cache, update position, and recompute row height when the list changes
useEffect(() => {
rowMeasurementCache?.current?.clearAll();

windowScrollerRef.current?.updatePosition();
}, [list.length, columnCount, isLoading]);
listRef.current?.recomputeRowHeights(0);
}, [list, columnCount, isLoading]);

// Use to work on small screen when categories are loaded
useEffect(() => {
Expand Down
1 change: 0 additions & 1 deletion ...pplications/integrations/sections/epm/screens/browse_integrations/components/side_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ export const Sidebar: React.FC<SidebarProps> = ({
<StickySidebar>
{CreateIntegrationCardButton && !isLoadingCreatedIntegrations && (
<>
<EuiSpacer size="s" />
{hasCreatedIntegrations ? (
<EuiLink
color="text"
Expand Down
10 changes: 1 addition & 9 deletions ...fleet/public/applications/integrations/sections/epm/screens/browse_integrations/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import React, { useCallback, useMemo } from 'react';
import { EuiFlexItem, EuiFlexGroup, EuiSpacer, useEuiTheme } from '@elastic/eui';
import { useLocation, useHistory } from 'react-router-dom';

import { css } from '@emotion/react';

import { useBreadcrumbs, useStartServices } from '../../../../hooks';
import { NoEprCallout } from '../../components/no_epr_callout';
import { categoryExists } from '../home';
Expand Down Expand Up @@ -125,13 +123,7 @@ export const BrowseIntegrationsPage: React.FC<{ prereleaseIntegrationsEnabled: b
onManageIntegrationsClick={onManageIntegrationsClick}
/>
<EuiFlexItem grow={5}>
<EuiFlexGroup
direction="column"
gutterSize="none"
css={css`
padding: 16px 8px;
`}
>
<EuiFlexGroup direction="column" gutterSize="none">
{!isManageIntegrationsView && (
<SearchAndFiltersBar
categories={mainCategories}
Expand Down
Loading