Skip to content

[ES|QL] Esql indentation shortcut on the editor#247234

Merged
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-indentation-shortcut
Dec 22, 2025
Merged

[ES|QL] Esql indentation shortcut on the editor#247234
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-indentation-shortcut

Conversation

@momovdg
Copy link
Contributor

@momovdg momovdg commented Dec 22, 2025 •
edited
Loading

resolves #188772

Summary

We are enhancing the editor with a new keyboard shortcut to prettify the query.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@momovdg momovdg self-assigned this Dec 22, 2025
@momovdg momovdg added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 labels Dec 22, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 22, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/solutions/security/test/cloud_security_posture_functional/config.ts / Cloud Security Posture Security Alerts Page - Graph visualization ECS fields only expanded flyout - entity enrichment for multiple generic targets - single target field
  • [job] [logs] x-pack/solutions/security/test/cloud_security_posture_functional/config.ts / Cloud Security Posture Security Alerts Page - Graph visualization ECS fields only expanded flyout - entity enrichment for multiple generic targets - single target field
  • [job] [logs] FTR Configs #88 / discover/esql discover esql view sorting should sort correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 721.8KB 722.2KB +392.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/esql-editor 11 13 +2

Total ESLint disabled count

id before after diff
@kbn/esql-editor 11 13 +2

History

cc @momovdg

@momovdg momovdg marked this pull request as ready for review December 22, 2025 13:51
@momovdg momovdg requested a review from a team as a code owner December 22, 2025 13:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 22, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula
stratoula approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@stratoula stratoula added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 22, 2025
@momovdg momovdg merged commit ba3dfa4 into elastic:main Dec 22, 2025
20 checks passed
@momovdg momovdg deleted the esql-indentation-shortcut branch December 22, 2025 14:55
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 22, 2025
@mbondyra
Merge commit '51756d2722200a991607658d48ecda50aeb04a7d' into dashboar…
7f313c1 
…d_step_back

* commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits)
  [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487)
  [Synthetics] Fix useSyntheticsRules test (elastic#247259)
  [ES|QL] Fix index editor flaky test (elastic#247233)
  [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236)
  [Console] Update console definitions (main) (elastic#247214)
  [ES|QL] Esql indentation shortcut on the editor (elastic#247234)
  [Streams] Use original request for rules client when in default space (elastic#247014)
  Consolidate and improve unflattenObject (elastic#246725)
  [scout] use svl mode to run api-int tests (elastic#247223)
  SIEM Readiness V2 (elastic#245776)
  [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872)
  [Streams] Add abort support and silent mode for stream description generation (elastic#247082)
  [SLO] Add environment context to SLO feedback button (elastic#247221)
  Ignore the reason and retry systematically (elastic#246830)
  Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221)
  [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919)
  [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060)
  [ML] Data frame analytics: Updates page headers (elastic#247097)
  [ES|QL] Build function arguments suggestions from hints (elastic#246736)
  Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210)
  ...
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
@momovdg @CAWilson94
[ES|QL] Esql indentation shortcut on the editor (elastic#247234)
b58a498 
resolves elastic#188772

## Summary

We are enhancing the editor with a new keyboard shortcut to prettify the
query.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
@momovdg @dej611
[ES|QL] Esql indentation shortcut on the editor (elastic#247234)
c75ea03 
resolves elastic#188772

## Summary

We are enhancing the editor with a new keyboard shortcut to prettify the
query.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
@florent-leborgne florent-leborgne mentioned this pull request Feb 3, 2026
Closed
Copilot AI mentioned this pull request Feb 20, 2026
Merged
florent-leborgne added a commit to elastic/docs-content that referenced this pull request Feb 20, 2026
@florent-leborgne
Document ES|QL prettify keyboard shortcut (#5239)
00dd581 
The ES|QL editor gained a keyboard shortcut for prettifying queries that
was missing from the docs. This updates the ES|QL keyboard shortcuts
section to include the new shortcut.

- **Docs update**
- Added `cmd+i` / `ctrl+i` entry for “Prettify query” in the ES|QL
keyboard shortcuts table
- Linked the “Prettify query” shortcut to the query formatting section
on the same page
  - Noted the shortcut applies to stack 9.4+

Example:

```markdown
| {kbd}`cmd+i` | {kbd}`ctrl+i` | [Prettify query](#_make_your_query_readable) {applies_to}`stack: ga 9.4+` |
```

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>[ES|QL] Keyboard shortcut for prettify</issue_title>
> <issue_description>PR: elastic/kibana#247234
> 
> Not much to say, just document the shortcut in
https://www.elastic.co/docs/explore-analyze/query-filter/languages/esql-kibana#keyboard-shortcuts
> 
> Serverless: released early Jan
> Stack: 9.4</issue_description>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes #4964

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: florent-leborgne <10208282+florent-leborgne@users.noreply.github.com>
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@momovdg momovdg

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ES|QL] Add shortcut for toggling 'break on pipes'

3 participants

@momovdg @elasticmachine @stratoula