[Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button#246919
Merged
rStelmach merged 9 commits intoelastic:mainfrom Dec 22, 2025
Merged
Conversation
rStelmach
added
release_note:skip
Contributor
|
Pinging @elastic/obs-onboarding-team (Team:obs-onboarding) |
couvq
approved these changes
Dec 18, 2025
| // Data may not be routed yet, refresh and try again | ||
| await page.reload(); | ||
| await pageObjects.discover.waitUntilSearchingHasFinished(); | ||
| await expandButton.waitFor({ state: 'visible', timeout: 30_000 }); |
Contributor
There was a problem hiding this comment.
nit: should this be a common function inside of the page objects class?
Contributor
Author
There was a problem hiding this comment.
Sounds good, might be useful
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
elastic-vault-github-plugin-prod
bot
requested review from
ashokaditya and
parkiino
fake-haris
reviewed
Dec 19, 2025
...k/platform/plugins/shared/streams_app/test/scout/ui/tests/discover_integration_wired.spec.ts
Outdated
Show resolved
Hide resolved
fake-haris
reviewed
Dec 22, 2025
src/platform/packages/shared/kbn-scout/src/playwright/page_objects/discover_app.ts
Outdated
Show resolved
Hide resolved
fake-haris
reviewed
Dec 22, 2025
...k/platform/plugins/shared/streams_app/test/scout/ui/tests/discover_integration_wired.spec.ts
Outdated
Show resolved
Hide resolved
fake-haris
approved these changes
Dec 22, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 22, 2025
…d_step_back * commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits) [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487) [Synthetics] Fix useSyntheticsRules test (elastic#247259) [ES|QL] Fix index editor flaky test (elastic#247233) [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236) [Console] Update console definitions (main) (elastic#247214) [ES|QL] Esql indentation shortcut on the editor (elastic#247234) [Streams] Use original request for rules client when in default space (elastic#247014) Consolidate and improve unflattenObject (elastic#246725) [scout] use svl mode to run api-int tests (elastic#247223) SIEM Readiness V2 (elastic#245776) [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872) [Streams] Add abort support and silent mode for stream description generation (elastic#247082) [SLO] Add environment context to SLO feedback button (elastic#247221) Ignore the reason and retry systematically (elastic#246830) Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221) [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919) [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060) [ML] Data frame analytics: Updates page headers (elastic#247097) [ES|QL] Build function arguments suggestions from hints (elastic#246736) Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210) ...
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 6, 2026
…pand button (elastic#246919) closes: [elastic#246874](elastic#246874) [elastic#246886](elastic#246886) ## Summary Fixes the flakiness in the Discover integration tests by adding proper waits for rows to render before we try to click them. For wired streams, I also added a page reload retry to handle the delay in data routing. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Jan 8, 2026
…pand button (elastic#246919) closes: [elastic#246874](elastic#246874) [elastic#246886](elastic#246886) ## Summary Fixes the flakiness in the Discover integration tests by adding proper waits for rows to render before we try to click them. For wired streams, I also added a page reload retry to handle the delay in data routing. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes:
#246874
#246886
Summary
Fixes the flakiness in the Discover integration tests by adding proper waits for rows to render before we try to click them. For wired streams, I also added a page reload retry to handle the delay in data routing.