Conversation
…nSh/kibana into siem-readiness-with-author
|
Pinging @elastic/contextual-security-apps (Team:Cloud Security) |
| <p> | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.siemReadiness.coverage.dataCoverage.warningDescription" | ||
| defaultMessage="Some log categories are missing integrations, limiting your visibility and detection coverage. Create a case to install the missing {count, plural, one {integration} other {integrations}} or view missing integrations to restore full visibility. Learn more about installing integrations in our {docs}." |
There was a problem hiding this comment.
| defaultMessage="Some log categories are missing integrations, limiting your visibility and detection coverage. Create a case to install the missing {count, plural, one {integration} other {integrations}} or view missing integrations to restore full visibility. Learn more about installing integrations in our {docs}." | |
| defaultMessage="Some log categories are missing integrations, limiting your visibility and detection coverage. Create a case to install the missing integrations for {count, plural, one {# category} other {# categories}} or view missing integrations to restore full visibility. Learn more about installing integrations in our {docs}." |
to fix the number counter
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
cc @JordanSh |
| export const DataCoveragePanel: React.FC = () => { | ||
| const basePath = useBasePath(); | ||
| const { getReadinessCategories } = useSiemReadinessApi(); | ||
| const { openNewCaseFlyout } = useSiemReadinessCases(); |
There was a problem hiding this comment.
considering other panels will also have Create Case option, won't it be better to have all the Create Case related stuff in 1 file and just export it
There was a problem hiding this comment.
since each component that shows this "create case button" needs to pass some kind of specific data in order to populate the flyout fields properly, it ends up a bunch of getter components with very random arguments. I considered this approach but found it a bit too messy, we can reconsider later in development after we will have a few more of those and we can try to see if we have some common fields that we can reduce into
|
@elasticmachine merge upstream |
…d_step_back * commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits) [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487) [Synthetics] Fix useSyntheticsRules test (elastic#247259) [ES|QL] Fix index editor flaky test (elastic#247233) [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236) [Console] Update console definitions (main) (elastic#247214) [ES|QL] Esql indentation shortcut on the editor (elastic#247234) [Streams] Use original request for rules client when in default space (elastic#247014) Consolidate and improve unflattenObject (elastic#246725) [scout] use svl mode to run api-int tests (elastic#247223) SIEM Readiness V2 (elastic#245776) [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872) [Streams] Add abort support and silent mode for stream description generation (elastic#247082) [SLO] Add environment context to SLO feedback button (elastic#247221) Ignore the reason and retry systematically (elastic#246830) Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221) [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919) [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060) [ML] Data frame analytics: Updates page headers (elastic#247097) [ES|QL] Build function arguments suggestions from hints (elastic#246736) Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210) ...
Resolves #242654
Resolves #242657
Resolves #242668
Resolves #242864
Summary
This pull request refactors and simplifies the SIEM readiness package to focus on API endpoints related to readiness categories and installed integrations, removing legacy readiness task logic and related types. It also updates the constants and types to reflect the new data structures and removes outdated tests.
API and Data Model Refactor:
readiness_tasks.tsfile and related exports inindex.ts. The code now focuses on readiness categories and integrations instead of individual tasks.GET_SIEM_READINESS_CATEGORIES_API_PATHfor fetching readiness categories.IndexInfo,CategoryGroup, andCategoriesResponseintypes.ts.Hooks and Query Updates:
useSiemReadinessApi, which now exposes queries for readiness categories and installed integrations, removing mutation and query logic for readiness tasks.