Skip to content

[Streams] Add abort support and silent mode for stream description generation#247082

Merged
cesco-f merged 2 commits intoelastic:mainfrom
cesco-f:generate-description
Dec 22, 2025
Merged

[Streams] Add abort support and silent mode for stream description generation#247082
cesco-f merged 2 commits intoelastic:mainfrom
cesco-f:generate-description

Conversation

@cesco-f
Copy link
Contributor

@cesco-f cesco-f commented Dec 19, 2025

Summary

This PR improves the stream description generation feature by adding abort capabilities and silent mode support.

Changes

Silent description generation during significant events flow

When generating significant events without features selected, we automatically generate a stream description in the background. This PR:

  • Adds a silent option to useStreamDescriptionApi hook to suppress toasts when generating description silently
  • Ensures aborting significant events generation also aborts the background description generation

Abort support for description generation in Advanced tab

Users can now stop the description generation in the Advanced tab:

  • The "Generate description" button toggles to a "Stop" button with loading spinner while generating
  • Clicking "Stop" aborts the generation request
  • If aborted from empty state, the UI stays in empty state (doesn't switch to editor)

Before:

Screen.Recording.2025-12-19.at.14.13.49.mov

After:

Screen.Recording.2025-12-19.at.14.12.01.mov

@cesco-f cesco-f requested a review from a team as a code owner December 19, 2025 13:19
@cesco-f cesco-f added the backport:skip This PR does not require backporting label Dec 19, 2025
@cesco-f cesco-f requested a review from a team as a code owner December 19, 2025 13:19
@cesco-f cesco-f added the Feature:Streams This is the label for the Streams Project label Dec 19, 2025
@github-actions github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Dec 19, 2025
@cesco-f cesco-f added backport:version Backport to applied version labels v9.3.0 and removed backport:skip This PR does not require backporting labels Dec 22, 2025
Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesco-f cesco-f merged commit 0199260 into elastic:main Dec 22, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/20433257046

@cesco-f cesco-f deleted the generate-description branch December 22, 2025 13:27
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 22, 2025
…neration (elastic#247082)

## Summary

This PR improves the stream description generation feature by adding
abort capabilities and silent mode support.

## Changes

### Silent description generation during significant events flow

When generating significant events without features selected, we
automatically generate a stream description in the background. This PR:

- Adds a `silent` option to `useStreamDescriptionApi` hook to suppress
toasts when generating description silently
- Ensures aborting significant events generation also aborts the
background description generation

### Abort support for description generation in Advanced tab

Users can now stop the description generation in the Advanced tab:

- The "Generate description" button toggles to a "Stop" button with
loading spinner while generating
- Clicking "Stop" aborts the generation request
- If aborted from empty state, the UI stays in empty state (doesn't
switch to editor)

Before:

https://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6

After:

https://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c
(cherry picked from commit 0199260)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 22, 2025
…d_step_back

* commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits)
  [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487)
  [Synthetics] Fix useSyntheticsRules test (elastic#247259)
  [ES|QL] Fix index editor flaky test (elastic#247233)
  [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236)
  [Console] Update console definitions (main) (elastic#247214)
  [ES|QL] Esql indentation shortcut on the editor (elastic#247234)
  [Streams] Use original request for rules client when in default space (elastic#247014)
  Consolidate and improve unflattenObject (elastic#246725)
  [scout] use svl mode to run api-int tests (elastic#247223)
  SIEM Readiness V2 (elastic#245776)
  [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872)
  [Streams] Add abort support and silent mode for stream description generation (elastic#247082)
  [SLO] Add environment context to SLO feedback button (elastic#247221)
  Ignore the reason and retry systematically (elastic#246830)
  Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221)
  [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919)
  [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060)
  [ML] Data frame analytics: Updates page headers (elastic#247097)
  [ES|QL] Build function arguments suggestions from hints (elastic#246736)
  Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 23, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @cesco-f

kibanamachine added a commit that referenced this pull request Dec 23, 2025
…ion generation (#247082) (#247261)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Streams] Add abort support and silent mode for stream description
generation (#247082)](#247082)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-12-22T13:26:05Z","message":"[Streams]
Add abort support and silent mode for stream description generation
(#247082)\n\n## Summary\n\nThis PR improves the stream description
generation feature by adding\nabort capabilities and silent mode
support.\n\n## Changes\n\n### Silent description generation during
significant events flow\n\nWhen generating significant events without
features selected, we\nautomatically generate a stream description in
the background. This PR:\n\n- Adds a `silent` option to
`useStreamDescriptionApi` hook to suppress\ntoasts when generating
description silently\n- Ensures aborting significant events generation
also aborts the\nbackground description generation\n\n### Abort support
for description generation in Advanced tab\n\nUsers can now stop the
description generation in the Advanced tab:\n\n- The \"Generate
description\" button toggles to a \"Stop\" button with\nloading spinner
while generating\n- Clicking \"Stop\" aborts the generation request\n-
If aborted from empty state, the UI stays in empty state
(doesn't\nswitch to
editor)\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6\n\nAfter:\n\n\n\nhttps://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c","sha":"01992606eb2c787954b524771c95ea1c7963af50","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:version","Feature:Streams","v9.3.0","v9.4.0","author:actionable-obs"],"title":"[Streams]
Add abort support and silent mode for stream description
generation","number":247082,"url":"https://github.com/elastic/kibana/pull/247082","mergeCommit":{"message":"[Streams]
Add abort support and silent mode for stream description generation
(#247082)\n\n## Summary\n\nThis PR improves the stream description
generation feature by adding\nabort capabilities and silent mode
support.\n\n## Changes\n\n### Silent description generation during
significant events flow\n\nWhen generating significant events without
features selected, we\nautomatically generate a stream description in
the background. This PR:\n\n- Adds a `silent` option to
`useStreamDescriptionApi` hook to suppress\ntoasts when generating
description silently\n- Ensures aborting significant events generation
also aborts the\nbackground description generation\n\n### Abort support
for description generation in Advanced tab\n\nUsers can now stop the
description generation in the Advanced tab:\n\n- The \"Generate
description\" button toggles to a \"Stop\" button with\nloading spinner
while generating\n- Clicking \"Stop\" aborts the generation request\n-
If aborted from empty state, the UI stays in empty state
(doesn't\nswitch to
editor)\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6\n\nAfter:\n\n\n\nhttps://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c","sha":"01992606eb2c787954b524771c95ea1c7963af50"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247082","number":247082,"mergeCommit":{"message":"[Streams]
Add abort support and silent mode for stream description generation
(#247082)\n\n## Summary\n\nThis PR improves the stream description
generation feature by adding\nabort capabilities and silent mode
support.\n\n## Changes\n\n### Silent description generation during
significant events flow\n\nWhen generating significant events without
features selected, we\nautomatically generate a stream description in
the background. This PR:\n\n- Adds a `silent` option to
`useStreamDescriptionApi` hook to suppress\ntoasts when generating
description silently\n- Ensures aborting significant events generation
also aborts the\nbackground description generation\n\n### Abort support
for description generation in Advanced tab\n\nUsers can now stop the
description generation in the Advanced tab:\n\n- The \"Generate
description\" button toggles to a \"Stop\" button with\nloading spinner
while generating\n- Clicking \"Stop\" aborts the generation request\n-
If aborted from empty state, the UI stays in empty state
(doesn't\nswitch to
editor)\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6\n\nAfter:\n\n\n\nhttps://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c","sha":"01992606eb2c787954b524771c95ea1c7963af50"}}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 23, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
…neration (elastic#247082)

## Summary

This PR improves the stream description generation feature by adding
abort capabilities and silent mode support.

## Changes

### Silent description generation during significant events flow

When generating significant events without features selected, we
automatically generate a stream description in the background. This PR:

- Adds a `silent` option to `useStreamDescriptionApi` hook to suppress
toasts when generating description silently
- Ensures aborting significant events generation also aborts the
background description generation

### Abort support for description generation in Advanced tab

Users can now stop the description generation in the Advanced tab:

- The "Generate description" button toggles to a "Stop" button with
loading spinner while generating
- Clicking "Stop" aborts the generation request
- If aborted from empty state, the UI stays in empty state (doesn't
switch to editor)

Before:


https://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6

After:



https://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
…neration (elastic#247082)

## Summary

This PR improves the stream description generation feature by adding
abort capabilities and silent mode support.

## Changes

### Silent description generation during significant events flow

When generating significant events without features selected, we
automatically generate a stream description in the background. This PR:

- Adds a `silent` option to `useStreamDescriptionApi` hook to suppress
toasts when generating description silently
- Ensures aborting significant events generation also aborts the
background description generation

### Abort support for description generation in Advanced tab

Users can now stop the description generation in the Advanced tab:

- The "Generate description" button toggles to a "Stop" button with
loading spinner while generating
- Clicking "Stop" aborts the generation request
- If aborted from empty state, the UI stays in empty state (doesn't
switch to editor)

Before:


https://github.com/user-attachments/assets/380d1746-8584-4ff4-b8d6-2b9b6fac9fc6

After:



https://github.com/user-attachments/assets/2f59b8ea-6930-4432-be83-f6c92793a69c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:actionable-obs PRs authored by the actionable obs team backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:enhancement v9.3.0 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants