Skip to content

[ES|QL] Fix index editor flaky test#247233

Merged
sddonne merged 2 commits intoelastic:mainfrom
sddonne:fix-flacky-test
Dec 22, 2025
Merged

[ES|QL] Fix index editor flaky test#247233
sddonne merged 2 commits intoelastic:mainfrom
sddonne:fix-flacky-test

Conversation

@sddonne
Copy link
Contributor

@sddonne sddonne commented Dec 22, 2025

Closes #241110

Summary

Setting a value was failing some times to clear the value the input already had, generating wrong results.

Checklist

@sddonne sddonne requested a review from a team as a code owner December 22, 2025 10:34
@sddonne sddonne added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 labels Dec 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@sddonne sddonne changed the title fix: input not being correctly cleared sometimes [ES|QL] Fix index editor flaky test Dec 22, 2025
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@stratoula
Copy link
Contributor

@sddonne you can also try to check with the flaky runner (100 times for example)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10202

[❌] src/platform/test/functional/apps/discover/esql/config.ts: 74/100 tests passed.

see run history

@sddonne
Copy link
Contributor Author

sddonne commented Dec 22, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10202

[❌] src/platform/test/functional/apps/discover/esql/config.ts: 74/100 tests passed.

see run history

The test failing was not the one fixed in this PR, so will proceed to merge.

@sddonne sddonne enabled auto-merge (squash) December 22, 2025 14:42
@sddonne sddonne merged commit 547e9a0 into elastic:main Dec 22, 2025
13 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 22, 2025
…d_step_back

* commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits)
  [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487)
  [Synthetics] Fix useSyntheticsRules test (elastic#247259)
  [ES|QL] Fix index editor flaky test (elastic#247233)
  [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236)
  [Console] Update console definitions (main) (elastic#247214)
  [ES|QL] Esql indentation shortcut on the editor (elastic#247234)
  [Streams] Use original request for rules client when in default space (elastic#247014)
  Consolidate and improve unflattenObject (elastic#246725)
  [scout] use svl mode to run api-int tests (elastic#247223)
  SIEM Readiness V2 (elastic#245776)
  [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872)
  [Streams] Add abort support and silent mode for stream description generation (elastic#247082)
  [SLO] Add environment context to SLO feedback button (elastic#247221)
  Ignore the reason and retry systematically (elastic#246830)
  Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221)
  [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919)
  [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060)
  [ML] Data frame analytics: Updates page headers (elastic#247097)
  [ES|QL] Build function arguments suggestions from hints (elastic#246736)
  Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210)
  ...
@sddonne sddonne added v9.3.0 backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting labels Jan 2, 2026
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/20653998921

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/20653998930

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2026
Closes elastic#241110
## Summary
Setting a value was failing some times to clear the value the input
already had, generating wrong results.

### Checklist
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 547e9a0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2026
Closes elastic#241110
## Summary
Setting a value was failing some times to clear the value the input
already had, generating wrong results.

### Checklist
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 547e9a0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2026
# Backport

This will backport the following commits from `main` to `9.3`:
- [[ES|QL] Fix index editor flaky test
(#247233)](#247233)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sebastian Delle
Donne","email":"sebastian.delledonne@elastic.co"},"sourceCommit":{"committedDate":"2025-12-22T15:25:00Z","message":"[ES|QL]
Fix index editor flaky test (#247233)\n\nCloses
https://github.com/elastic/kibana/issues/241110\n## Summary\nSetting a
value was failing some times to clear the value the input\nalready had,
generating wrong results.\n\n### Checklist\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests
changed","sha":"547e9a039d695d43e49bbaf6e3a9c7e5dc08fba3","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.3.0","v9.4.0"],"title":"[ES|QL]
Fix index editor flaky
test","number":247233,"url":"https://github.com/elastic/kibana/pull/247233","mergeCommit":{"message":"[ES|QL]
Fix index editor flaky test (#247233)\n\nCloses
https://github.com/elastic/kibana/issues/241110\n## Summary\nSetting a
value was failing some times to clear the value the input\nalready had,
generating wrong results.\n\n### Checklist\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests
changed","sha":"547e9a039d695d43e49bbaf6e3a9c7e5dc08fba3"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247233","number":247233,"mergeCommit":{"message":"[ES|QL]
Fix index editor flaky test (#247233)\n\nCloses
https://github.com/elastic/kibana/issues/241110\n## Summary\nSetting a
value was failing some times to clear the value the input\nalready had,
generating wrong results.\n\n### Checklist\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests
changed","sha":"547e9a039d695d43e49bbaf6e3a9c7e5dc08fba3"}}]}]
BACKPORT-->

---------

Co-authored-by: Sebastian Delle Donne <sebastian.delledonne@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
Closes elastic#241110
## Summary
Setting a value was failing some times to clear the value the input
already had, generating wrong results.

### Checklist
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
Closes elastic#241110
## Summary
Setting a value was failing some times to clear the value the input
already had, generating wrong results.

### Checklist
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.3.0 v9.4.0

Projects

None yet

4 participants