[ES|QL] Build function arguments suggestions from hints by sddonne · Pull Request #246736 · elastic/kibana

sddonne · 2025-12-17T15:09:12Z

Summary

For some special function arguments ES is now providing information about how to resolve them. For instance, functions that accepts inference endpoints.

This PR adds support for the inference_endpoint hint, and an easy way to extend it to other hints.

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/autocomplete.ts

elasticmachine · 2025-12-19T12:36:06Z

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula

This looks great and is very close to what I had in mind, thanks for trying this approach!

stratoula · 2025-12-22T06:48:31Z

src/platform/packages/shared/kbn-esql-language/src/commands/definitions/generated/settings.ts

  serverlessOnly: true,
  preview: true,
-  snapshotOnly: true,
+  snapshotOnly: false,


Change it to true because we dont want to suggest it yet at kibana

changed, 0714374

stratoula · 2025-12-22T06:52:27Z

...hared/kbn-esql-language/src/commands/definitions/utils/autocomplete/parameters_from_hints.ts

+ * custom autocompletion handlers.
+ *
+ * For each hint we need to provide:
+ * - a suggestionResolver to generate the autocomplettion items to shown for that param.


Suggested change

* - a suggestionResolver to generate the autocomplettion items to shown for that param.

* - a suggestionResolver to generate the autocompletion items for this param.

stratoula · 2025-12-22T06:52:52Z

...hared/kbn-esql-language/src/commands/definitions/utils/autocomplete/parameters_from_hints.ts

+ *
+ * Important!
+ * Be mindful while implementing context resolvers, context is shared by the command and all functions used within it.
+ * If the data you need is already present, don't overwrite it, preffer merging it.


Suggested change

* If the data you need is already present, don't overwrite it, preffer merging it.

* If the data you need is already present, don't overwrite it, prefer merging it.

stratoula · 2025-12-22T06:59:51Z

...esql-language/src/language/autocomplete/__tests__/autocomplete.parameters_with_hints.test.ts

I really like this test

stratoula · 2025-12-22T07:00:22Z

...esql-language/src/language/autocomplete/__tests__/autocomplete.parameters_with_hints.test.ts

+  'entityType'
+);
+
+describe('function parameters built from hints', () => {


nit (the built is confusing me)

Suggested change

describe('function parameters built from hints', () => {

describe('function parameters autocomplete from hints', () => {

elasticmachine · 2025-12-22T11:42:47Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: b208d47

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #48 / Dataset Quality Dataset quality alerting "before all" hook in "Dataset quality alerting"
[job] [logs] Scout: [ platform / streams_app ] plugin / should handle network failures during a processor creation
[job] [logs] Scout: [ platform / streams_app ] plugin / stateful - Stream data processing - error handling and recovery - should handle network failures during a processor creation
[job] [logs] Jest Integration Tests #9 / Uprade package install version with package installed with a previous format install version should upgrade package install version for outdated packages

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedSearch`	587	588	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/esql-language`	614	619	+5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	4.3MB	4.3MB	+2.0KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/esql-language`	816	821	+5

History

💛 Build #375683 was flaky 8cc768d
💛 Build #375508 was flaky 3e6bcf2

…d_step_back * commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits) [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487) [Synthetics] Fix useSyntheticsRules test (elastic#247259) [ES|QL] Fix index editor flaky test (elastic#247233) [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236) [Console] Update console definitions (main) (elastic#247214) [ES|QL] Esql indentation shortcut on the editor (elastic#247234) [Streams] Use original request for rules client when in default space (elastic#247014) Consolidate and improve unflattenObject (elastic#246725) [scout] use svl mode to run api-int tests (elastic#247223) SIEM Readiness V2 (elastic#245776) [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872) [Streams] Add abort support and silent mode for stream description generation (elastic#247082) [SLO] Add environment context to SLO feedback button (elastic#247221) Ignore the reason and retry systematically (elastic#246830) Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221) [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919) [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060) [ML] Data frame analytics: Updates page headers (elastic#247097) [ES|QL] Build function arguments suggestions from hints (elastic#246736) Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210) ...

Closes elastic#237794 ## Summary For some special function arguments ES is now providing information about how to resolve them. For instance, functions that accepts inference endpoints. <img width="1169" height="301" alt="image" src="https://github.com/user-attachments/assets/9d3e212c-11dd-4a84-abfc-324587ea7c50" /> <img width="1163" height="261" alt="image" src="https://github.com/user-attachments/assets/9900a836-f82c-4d03-9126-bd63156fd2b6" /> This PR adds support for the `inference_endpoint` hint, and an easy way to extend it to other hints. --------- Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>

sddonne added 8 commits December 15, 2025 15:55

fix rerank not fetching inference endpoints

7d982a6

suggest inference endpoint in TEXT_EMBEDDING function

2e0ce65

add test

f84d936

clean

78e02b4

make hints unique

8a71197

clean

4da15db

simplify hint resolving

6249586

early population of context for paramenters suggestions

ae07e86

sddonne commented Dec 17, 2025

View reviewed changes

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/autocomplete.ts Outdated Show resolved Hide resolved

sddonne mentioned this pull request Dec 17, 2025

[ES|QL] Build function arguments suggestions from hints #246495

Closed

sddonne added 11 commits December 18, 2025 10:55

smarter merge of context

aed7447

clean

68cbf07

clean

6824170

clean map

67a221e

add tests

7ece930

merge with main

f8d363e

add generic test

4909a34

throw if not found

786df0a

clean async functions

9301d7f

better doc

449ab38

add switch breaks

3e6bcf2

sddonne changed the title ~~[ES|QL] Parameters from hints - V2~~ [ES|QL] Build function arguments suggestions from hints Dec 19, 2025

sddonne added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 19, 2025

sddonne marked this pull request as ready for review December 19, 2025 12:36

sddonne requested a review from a team as a code owner December 19, 2025 12:36

sddonne and others added 2 commits December 19, 2025 17:24

merge with main

8cc768d

Merge branch 'main' into hints-2

143db7a

stratoula approved these changes Dec 22, 2025

View reviewed changes

sddonne added 4 commits December 22, 2025 09:19

solve comments

0714374

Merge branch 'hints-2' of https://github.com/sddonne/kibana into hints-2

ba9e60d

Merge branch 'main' into hints-2

31e9142

Merge branch 'main' into hints-2

b208d47

sddonne enabled auto-merge (squash) December 22, 2025 10:30

sddonne merged commit d8d8d55 into elastic:main Dec 22, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Build function arguments suggestions from hints#246736

[ES|QL] Build function arguments suggestions from hints#246736
sddonne merged 25 commits intoelastic:mainfrom
sddonne:hints-2

sddonne commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

elasticmachine commented Dec 19, 2025

Uh oh!

stratoula left a comment

Uh oh!

stratoula Dec 22, 2025

Uh oh!

sddonne Dec 22, 2025

Uh oh!

stratoula Dec 22, 2025

Uh oh!

stratoula Dec 22, 2025

Uh oh!

stratoula Dec 22, 2025

Uh oh!

stratoula Dec 22, 2025

Uh oh!

Uh oh!

elasticmachine commented Dec 22, 2025

API count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* - a suggestionResolver to generate the autocomplettion items to shown for that param.
	* - a suggestionResolver to generate the autocompletion items for this param.

	* If the data you need is already present, don't overwrite it, preffer merging it.
	* If the data you need is already present, don't overwrite it, prefer merging it.

	describe('function parameters built from hints', () => {
	describe('function parameters autocomplete from hints', () => {

Conversation

sddonne commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Uh oh!

elasticmachine commented Dec 19, 2025

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

sddonne Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

stratoula Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

stratoula Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

stratoula Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

stratoula Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Dec 22, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Page load bundle

API count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sddonne commented Dec 17, 2025 •

edited

Loading