[TSVB/SCSS] Migrate _markdown_editor.scss file#220903
Merged
mariairiartef merged 3 commits intoelastic:mainfrom May 29, 2025
Merged
[TSVB/SCSS] Migrate _markdown_editor.scss file#220903mariairiartef merged 3 commits intoelastic:mainfrom
_markdown_editor.scss file#220903mariairiartef merged 3 commits intoelastic:mainfrom
Conversation
mariairiartef
added
Feature:TSVB
mariairiartef
changed the title
_markdown_editor.scss file
16 tasks
mariairiartef
added
technical debt
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
approved these changes
May 27, 2025
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Style changes LGTM, thanks for applying the missing noVariables style. I believe it was just a wrongly named className that caused that.
ryankeairns
approved these changes
May 27, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15324001868 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced May 29, 2025
This was referenced May 29, 2025
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
mariairiartef
added a commit
to mariairiartef/kibana
that referenced
this pull request
Jun 3, 2025
## Summary Part of elastic#220095 Migrates `_markdown_editor.scss` file Note: the `tvbMarkdownEditor__noVariables` styles weren't applied. #### Before <img width="2560" alt="Screenshot 2025-05-19 at 14 57 44" src="https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284" /> #### After applying the style <img width="2560" alt="Screenshot 2025-05-19 at 15 00 17" src="https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83" /> ### Considerations For details on considerations, read [this](elastic#220095 (comment)). ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 27634da) # Conflicts: # src/platform/plugins/private/vis_types/timeseries/public/application/components/_markdown_editor.scss
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mariairiartef
added a commit
that referenced
this pull request
Jun 3, 2025
…22360) # Backport This will backport the following commits from `main` to `8.19`: - [[TSVB/SCSS] Migrate `_markdown_editor.scss` file (#220903)](#220903) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-29T12:37:27Z","message":"[TSVB/SCSS] Migrate `_markdown_editor.scss` file (#220903)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/220095\n\nMigrates `_markdown_editor.scss` file\n\nNote: the `tvbMarkdownEditor__noVariables` styles weren't applied.\n\n#### Before\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 14 57 44\"\nsrc=\"https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284\"\n/>\n\n#### After applying the style\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 15 00 17\"\nsrc=\"https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83\"\n/>\n\n### Considerations\n\nFor details on considerations, read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"27634da2148cb5faf53a3dc235700be175d152c9","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","technical debt","Team:Visualizations","release_note:skip","backport missing","backport:version","v9.1.0","v8.19.0","scss-removal"],"title":"[TSVB/SCSS] Migrate `_markdown_editor.scss` file","number":220903,"url":"https://github.com/elastic/kibana/pull/220903","mergeCommit":{"message":"[TSVB/SCSS] Migrate `_markdown_editor.scss` file (#220903)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/220095\n\nMigrates `_markdown_editor.scss` file\n\nNote: the `tvbMarkdownEditor__noVariables` styles weren't applied.\n\n#### Before\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 14 57 44\"\nsrc=\"https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284\"\n/>\n\n#### After applying the style\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 15 00 17\"\nsrc=\"https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83\"\n/>\n\n### Considerations\n\nFor details on considerations, read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"27634da2148cb5faf53a3dc235700be175d152c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220903","number":220903,"mergeCommit":{"message":"[TSVB/SCSS] Migrate `_markdown_editor.scss` file (#220903)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/220095\n\nMigrates `_markdown_editor.scss` file\n\nNote: the `tvbMarkdownEditor__noVariables` styles weren't applied.\n\n#### Before\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 14 57 44\"\nsrc=\"https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284\"\n/>\n\n#### After applying the style\n<img width=\"2560\" alt=\"Screenshot 2025-05-19 at 15 00 17\"\nsrc=\"https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83\"\n/>\n\n### Considerations\n\nFor details on considerations, read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"27634da2148cb5faf53a3dc235700be175d152c9"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary Part of elastic#220095 Migrates `_markdown_editor.scss` file Note: the `tvbMarkdownEditor__noVariables` styles weren't applied. #### Before <img width="2560" alt="Screenshot 2025-05-19 at 14 57 44" src="https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284" /> #### After applying the style <img width="2560" alt="Screenshot 2025-05-19 at 15 00 17" src="https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83" /> ### Considerations For details on considerations, read [this](elastic#220095 (comment)). ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary Part of elastic#220095 Migrates `_markdown_editor.scss` file Note: the `tvbMarkdownEditor__noVariables` styles weren't applied. #### Before <img width="2560" alt="Screenshot 2025-05-19 at 14 57 44" src="https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284" /> #### After applying the style <img width="2560" alt="Screenshot 2025-05-19 at 15 00 17" src="https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83" /> ### Considerations For details on considerations, read [this](elastic#220095 (comment)). ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #220095
Migrates
_markdown_editor.scssfileNote: the
tvbMarkdownEditor__noVariablesstyles weren't applied.Before
After applying the style
Considerations
For details on considerations, read this.
Checklist
release_note:*label is applied per the guidelines