Skip to content

[TSVB/SCSS] Migrate _markdown.scss file#221297

Merged
mariairiartef merged 5 commits intoelastic:mainfrom
mariairiartef:tsvb/scss-js/markdown
May 29, 2025
Merged

[TSVB/SCSS] Migrate _markdown.scss file#221297
mariairiartef merged 5 commits intoelastic:mainfrom
mariairiartef:tsvb/scss-js/markdown

Conversation

@mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented May 22, 2025 •
edited by kibanamachine
Loading

Summary

Part of #220095

Migrates _markdown.scss file.

Considerations

For details on considerations, read this.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@mariairiartef mariairiartef self-assigned this May 22, 2025
@mariairiartef mariairiartef added Feature:TSVB TSVB (Time Series Visual Builder) technical debt Improvement of the software architecture and operational architecture Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting scss-removal labels May 22, 2025
@mariairiartef mariairiartef mentioned this pull request May 21, 2025
Closed
16 tasks
@mariairiartef mariairiartef added backport:version Backport to applied version labels v9.1.0 v8.19.0 and removed backport:skip This PR does not require backporting labels May 27, 2025
@mariairiartef mariairiartef marked this pull request as ready for review May 27, 2025 10:16
@mariairiartef mariairiartef requested review from a team as code owners May 27, 2025 10:16
@elasticmachine
Copy link
Contributor

elasticmachine commented May 27, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mariairiartef mariairiartef enabled auto-merge (squash) May 29, 2025 10:52
@mariairiartef mariairiartef merged commit 9ebe47c into elastic:main May 29, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented May 29, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15324072110

@elasticmachine
Copy link
Contributor

elasticmachine commented May 29, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 476 471 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 450.4KB 448.4KB -2.1KB

History

cc @mariairiartef

@kibanamachine
Copy link
Contributor

kibanamachine commented May 29, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [TSVB/SCSS] Migrate _last_value_mode_popover.scss file (#221092)
- [TSVB/SCSS] Migrate _vis_types.scss file (#221095)
- [TSVB/SCSS] Migrate _markdown_editor.scss file (#220903)
- [TSVB/SCSS] Migrate _series_editor.scss file (#220991)
- [TSVB/SCSS] Migrate _annotations_editor.scss file (#220900)
- [Synthetics] Migrate synthetics alerting API tests to deployment agnostic solution (#221139)
- [Discover] Show ES|QL request URL in Inpector flyout (#221816)
- [Streams] Grok UI integration with enrichment page (#219146)
- Add windsurf to gitignore (#221801)
- [Alerting] Add snapshot telemetry for _ignored fields (#221480)

Manual backport

To create the backport manually run:

node scripts/backport --pr 221297

Questions ?

Please refer to the Backport tool documentation

This was referenced May 29, 2025
Merged
Merged
This was referenced May 29, 2025
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 2, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 221297 locally
cc: @mariairiartef

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 221297 locally
cc: @mariairiartef

mariairiartef added a commit to mariairiartef/kibana that referenced this pull request Jun 3, 2025
@mariairiartef
[TSVB/SCSS] Migrate _markdown.scss file (elastic#221297)
38e9301 
## Summary

Part of elastic#220095

Migrates `_markdown.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

### Checklist

- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 9ebe47c)

# Conflicts:
#	src/platform/plugins/private/vis_types/timeseries/public/application/components/vis_types/markdown/_markdown.scss
@mariairiartef
Copy link
Contributor Author

mariairiartef commented Jun 3, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@mariairiartef mariairiartef mentioned this pull request Jun 3, 2025
Merged
mariairiartef added a commit that referenced this pull request Jun 3, 2025
@mariairiartef
[8.19] [TSVB/SCSS] Migrate _markdown.scss file (#221297) (#222353)
c614023 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[TSVB/SCSS] Migrate `_markdown.scss` file
(#221297)](#221297)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maria
Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-29T12:41:23Z","message":"[TSVB/SCSS]
Migrate `_markdown.scss` file (#221297)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`_markdown.scss` file.\n\n### Considerations\n\nFor details on
considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n###
Checklist\n\n- [ ] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9ebe47c80928cdea35197794ed29edd32565b4be","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","technical
debt","Team:Visualizations","release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0","scss-removal"],"title":"[TSVB/SCSS]
Migrate `_markdown.scss`
file","number":221297,"url":"https://github.com/elastic/kibana/pull/221297","mergeCommit":{"message":"[TSVB/SCSS]
Migrate `_markdown.scss` file (#221297)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`_markdown.scss` file.\n\n### Considerations\n\nFor details on
considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n###
Checklist\n\n- [ ] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9ebe47c80928cdea35197794ed29edd32565b4be"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221297","number":221297,"mergeCommit":{"message":"[TSVB/SCSS]
Migrate `_markdown.scss` file (#221297)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`_markdown.scss` file.\n\n### Considerations\n\nFor details on
considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n###
Checklist\n\n- [ ] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9ebe47c80928cdea35197794ed29edd32565b4be"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2025
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
@mariairiartef @zacharyparikh
[TSVB/SCSS] Migrate _markdown.scss file (elastic#221297)
893939f 
## Summary

Part of elastic#220095

Migrates `_markdown.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

### Checklist

- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
@mariairiartef @nickpeihl
[TSVB/SCSS] Migrate _markdown.scss file (elastic#221297)
681b7ad 
## Summary

Part of elastic#220095

Migrates `_markdown.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

### Checklist

- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

@mariairiartef mariairiartef

Labels

backport:version Backport to applied version labels Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes scss-removal Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// technical debt Improvement of the software architecture and operational architecture v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mariairiartef @elasticmachine @kibanamachine @ryankeairns @nickofthyme