Update aria label for the discuss forum link#221936
Merged
gbamparop merged 1 commit intoelastic:mainfrom May 29, 2025
Merged
Conversation
gbamparop
added
release_note:skip
tonyghiani
approved these changes
May 29, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15327552066 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
### Summary - Updates aria label for the discuss forum link in onboarding so the start of the link text is announced the same in the reader - Tested with VoiceOver in Mac ### VoiceOver text announcement: **Before** <img width="620" alt="image" src="https://github.com/user-attachments/assets/c1de61db-c17a-4915-8f67-734aeff07beb" /> **After** <img width="634" alt="image" src="https://github.com/user-attachments/assets/677a620d-949b-49a0-9b5c-4fca9528c41f" /> Closes elastic#220812
gbamparop
added a commit
that referenced
this pull request
Jun 5, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Update aria label for the discuss forum link (#221936)](#221936) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T15:34:33Z","message":"Update aria label for the discuss forum link (#221936)\n\n### Summary\n- Updates aria label for the discuss forum link in onboarding so the\nstart of the link text is announced the same in the reader\n- Tested with VoiceOver in Mac\n\n### VoiceOver text announcement:\n**Before**\n<img width=\"620\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1de61db-c17a-4915-8f67-734aeff07beb\"\n/>\n\n**After**\n<img width=\"634\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/677a620d-949b-49a0-9b5c-4fca9528c41f\"\n/>\n\n\nCloses https://github.com/elastic/kibana/issues/220812","sha":"6c47a74e9bb48c0d0ca886faf5ef6d64cbf5e609","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","backport:version","v9.1.0","v8.19.0"],"title":"Update aria label for the discuss forum link","number":221936,"url":"https://github.com/elastic/kibana/pull/221936","mergeCommit":{"message":"Update aria label for the discuss forum link (#221936)\n\n### Summary\n- Updates aria label for the discuss forum link in onboarding so the\nstart of the link text is announced the same in the reader\n- Tested with VoiceOver in Mac\n\n### VoiceOver text announcement:\n**Before**\n<img width=\"620\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1de61db-c17a-4915-8f67-734aeff07beb\"\n/>\n\n**After**\n<img width=\"634\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/677a620d-949b-49a0-9b5c-4fca9528c41f\"\n/>\n\n\nCloses https://github.com/elastic/kibana/issues/220812","sha":"6c47a74e9bb48c0d0ca886faf5ef6d64cbf5e609"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221936","number":221936,"mergeCommit":{"message":"Update aria label for the discuss forum link (#221936)\n\n### Summary\n- Updates aria label for the discuss forum link in onboarding so the\nstart of the link text is announced the same in the reader\n- Tested with VoiceOver in Mac\n\n### VoiceOver text announcement:\n**Before**\n<img width=\"620\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1de61db-c17a-4915-8f67-734aeff07beb\"\n/>\n\n**After**\n<img width=\"634\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/677a620d-949b-49a0-9b5c-4fca9528c41f\"\n/>\n\n\nCloses https://github.com/elastic/kibana/issues/220812","sha":"6c47a74e9bb48c0d0ca886faf5ef6d64cbf5e609"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
### Summary - Updates aria label for the discuss forum link in onboarding so the start of the link text is announced the same in the reader - Tested with VoiceOver in Mac ### VoiceOver text announcement: **Before** <img width="620" alt="image" src="https://github.com/user-attachments/assets/c1de61db-c17a-4915-8f67-734aeff07beb" /> **After** <img width="634" alt="image" src="https://github.com/user-attachments/assets/677a620d-949b-49a0-9b5c-4fca9528c41f" /> Closes elastic#220812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoiceOver text announcement:
Before
After
Closes #220812