[Lens] Optimize unnecessary re-renders#220366
Merged
dej611 merged 16 commits intoelastic:mainfrom May 28, 2025
Merged
Conversation
dej611
added
the
Team:Visualizations
dej611
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
reviewed
May 7, 2025
...platform/plugins/shared/chart_expressions/expression_metric/public/components/metric_vis.tsx
Outdated
Show resolved
Hide resolved
...red/chart_expressions/expression_partition_vis/public/components/partition_vis_component.tsx
Outdated
Show resolved
Hide resolved
...red/chart_expressions/expression_partition_vis/public/components/partition_vis_component.tsx
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/app_plugin/lens_top_nav.tsx
Outdated
Show resolved
Hide resolved
...tform/plugins/shared/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx
Show resolved
Hide resolved
markov00
approved these changes
May 27, 2025
dej611
added
backport:version
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @dej611 |
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15299639145 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dej611
added a commit
to dej611/kibana
that referenced
this pull request
May 28, 2025
## Summary After a conversation with @markov00 I've ran an investigation of unwanted re-render due to an abuse of `useEffect`, which can be easily converted into `useMemo` calls. (cherry picked from commit d859fc0) # Conflicts: # x-pack/platform/plugins/shared/lens/public/editor_frame_service/editor_frame/editor_frame.test.tsx
1 task
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary After a conversation with @markov00 I've ran an investigation of unwanted re-render due to an abuse of `useEffect`, which can be easily converted into `useMemo` calls.
This was referenced May 29, 2025
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
dej611
added a commit
that referenced
this pull request
Jun 3, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Lens] Optimize unnecessary re-renders (#220366)](#220366) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-28T12:04:03Z","message":"[Lens] Optimize unnecessary re-renders (#220366)\n\n## Summary\n\nAfter a conversation with @markov00 I've ran an investigation of\nunwanted re-render due to an abuse of `useEffect`, which can be easily\nconverted into `useMemo` calls.","sha":"d859fc004663158cebedef1c5f401172b4be37e0","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0"],"title":"[Lens] Optimize unnecessary re-renders","number":220366,"url":"https://github.com/elastic/kibana/pull/220366","mergeCommit":{"message":"[Lens] Optimize unnecessary re-renders (#220366)\n\n## Summary\n\nAfter a conversation with @markov00 I've ran an investigation of\nunwanted re-render due to an abuse of `useEffect`, which can be easily\nconverted into `useMemo` calls.","sha":"d859fc004663158cebedef1c5f401172b4be37e0"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220366","number":220366,"mergeCommit":{"message":"[Lens] Optimize unnecessary re-renders (#220366)\n\n## Summary\n\nAfter a conversation with @markov00 I've ran an investigation of\nunwanted re-render due to an abuse of `useEffect`, which can be easily\nconverted into `useMemo` calls.","sha":"d859fc004663158cebedef1c5f401172b4be37e0"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary After a conversation with @markov00 I've ran an investigation of unwanted re-render due to an abuse of `useEffect`, which can be easily converted into `useMemo` calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a conversation with @markov00 I've ran an investigation of unwanted re-render due to an abuse of
useEffect, which can be easily converted intouseMemocalls.