Skip to content

[8.19] [TSVB/SCSS] Migrate _markdown_editor.scss file (#220903)#222360

Merged
mariairiartef merged 1 commit intoelastic:8.19from
mariairiartef:backport/8.19/pr-220903
Jun 3, 2025
Merged

[8.19] [TSVB/SCSS] Migrate _markdown_editor.scss file (#220903)#222360
mariairiartef merged 1 commit intoelastic:8.19from
mariairiartef:backport/8.19/pr-220903

Conversation

@mariairiartef
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Part of elastic#220095

Migrates `_markdown_editor.scss` file

Note: the `tvbMarkdownEditor__noVariables` styles weren't applied.

#### Before
<img width="2560" alt="Screenshot 2025-05-19 at 14 57 44"
src="https://github.com/user-attachments/assets/ba3a7737-770d-4e3b-a911-171b2e92a284"
/>

#### After applying the style
<img width="2560" alt="Screenshot 2025-05-19 at 15 00 17"
src="https://github.com/user-attachments/assets/dc94bb64-c053-47dc-aad1-243b02290a83"
/>

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

## Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 27634da)

# Conflicts:
#	src/platform/plugins/private/vis_types/timeseries/public/application/components/_markdown_editor.scss
@mariairiartef mariairiartef added the backport This PR is a backport of another PR label Jun 3, 2025
@mariairiartef mariairiartef enabled auto-merge (squash) June 3, 2025 13:30
@mariairiartef mariairiartef merged commit 94e5fbe into elastic:8.19 Jun 3, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / Alerting builtin alertTypes circuit_breakers index threshold rule that hits max alerts circuit breaker persist existing alerts to next execution if circuit breaker is hit

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 477 472 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 465.0KB 463.7KB -1.3KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants