Skip to content

[Dashboards] Fix panel actions hidden behind top nav in maximize mode#216290

Merged
mbondyra merged 1 commit intoelastic:mainfrom
mbondyra:dashboard_fix_actions_in_expanded
Mar 28, 2025
Merged

[Dashboards] Fix panel actions hidden behind top nav in maximize mode#216290
mbondyra merged 1 commit intoelastic:mainfrom
mbondyra:dashboard_fix_actions_in_expanded

Conversation

@mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Mar 28, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #216289

@mbondyra mbondyra added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Mar 28, 2025
@mbondyra mbondyra marked this pull request as ready for review March 28, 2025 12:44
@mbondyra mbondyra requested a review from a team as a code owner March 28, 2025 12:44
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 28, 2025

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 28, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
presentationPanel 37.5KB 37.6KB +54.0B

@mbondyra mbondyra changed the title [Dashboards] Fix Ppanel actions hidden behind top nav in maximize mode [Dashboards] Fix panel actions hidden behind top nav in maximize mode Mar 28, 2025
Heenawter
Heenawter approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test + code review - straight forward change. Thanks for jumping on this so quickly!! 🙇

@mbondyra mbondyra merged commit f699e4e into elastic:main Mar 28, 2025
24 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 28, 2025

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14133308027

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 28, 2025
@mbondyra
[Dashboards] Fix panel actions hidden behind top nav in maximize mode (…
8265137 
…elastic#216290)

## Summary

Fixes elastic#216289

(cherry picked from commit f699e4e)
@kibanamachine kibanamachine mentioned this pull request Mar 28, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 28, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.18 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.18:
- [Fleet] disable unenroll action on agentless agents (#216299)
- [Security Solution][THI] - unskip tests (#213472)
- [Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)
✅ 8.x
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Solution Side Nav] Misc UI fixes (#216109)
- [docs] Remove reliance on temporary redirects (#216315)
- [Fleet] disable unenroll action on agentless agents (#216299)
- [Security Solution][THI] - unskip tests (#213472)
- [OBX-UX-MGTM] Add stale alert insight (#215332)
- chore(deps): upgrade vega from 5.31.0 to 5.33.0 (#216284)
- Update task state version after execution. (#215559)
- [Dashboard] Fix explicitInput removal (#215580)

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 216290

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 28, 2025
@kibanamachine @mbondyra
[8.x] [Dashboards] Fix panel actions hidden behind top nav in maximiz…
8ebe81d 
…e mode (#216290) (#216345)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboards] Fix panel actions hidden behind top nav in maximize mode
(#216290)](#216290)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-28T16:18:07Z","message":"[Dashboards]
Fix panel actions hidden behind top nav in maximize mode (#216290)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/216289","sha":"f699e4ec2097ecaf0bc1f099cfd65092dfc316b4","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Dashboards]
Fix panel actions hidden behind top nav in maximize
mode","number":216290,"url":"https://github.com/elastic/kibana/pull/216290","mergeCommit":{"message":"[Dashboards]
Fix panel actions hidden behind top nav in maximize mode (#216290)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/216289","sha":"f699e4ec2097ecaf0bc1f099cfd65092dfc316b4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216290","number":216290,"mergeCommit":{"message":"[Dashboards]
Fix panel actions hidden behind top nav in maximize mode (#216290)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/216289","sha":"f699e4ec2097ecaf0bc1f099cfd65092dfc316b4"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 31, 2025
Merged
@mbondyra
Copy link
Contributor Author

mbondyra commented Mar 31, 2025

The code was only shipped to 9.1/8.19, so the failed backports are ok 😀

@mbondyra mbondyra deleted the dashboard_fix_actions_in_expanded branch March 31, 2025 12:24
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@mbondyra @cqliu1
[Dashboards] Fix panel actions hidden behind top nav in maximize mode (…
8cc24c6 
…elastic#216290)

## Summary

Fixes elastic#216289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dashboards] Panel actions hidden behind top nav in maximize mode

4 participants

@mbondyra @elasticmachine @kibanamachine @Heenawter