Skip to content

[OBX-UX-MGTM] Add stale alert insight #215332

Merged
fkanout merged 15 commits intoelastic:mainfrom
fkanout:213003-poc-stale-alert-insight
Mar 28, 2025
Merged

[OBX-UX-MGTM] Add stale alert insight #215332
fkanout merged 15 commits intoelastic:mainfrom
fkanout:213003-poc-stale-alert-insight

Conversation

@fkanout
Copy link
Contributor

@fkanout fkanout commented Mar 20, 2025 •
edited by kibanamachine
Loading

Summary

If fixes #213003 by adding a stale alert insight to the alert details page

The heuristics to show the stale alert callout are:

  1. The alert has been active for more than 5 days
    2. The alert has no cases associated with it
    3. The rule is snoozed with no notifications

Callout stale alert - First Iteration Preview

Screenshot 2025-03-28 at 13 11 21
Screen.Recording.2025-03-20.at.13.11.06.mov

@fkanout fkanout added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.1.0 labels Mar 20, 2025
@fkanout fkanout self-assigned this Mar 20, 2025
@jasonrhodes
Copy link
Member

jasonrhodes commented Mar 20, 2025

This is looking good, can we add "EBT" (event-based telemetry) for the appearance of the callout, as well as for clicks on each of the actions?

@fkanout
Copy link
Contributor Author

fkanout commented Mar 21, 2025

This is looking good, can we add "EBT" (event-based telemetry) for the appearance of the callout, as well as for clicks on each of the actions?

@jasonrhodes, it's the case for the clicks on each of the actions (Edit rule, Mark as untracked), It will report EBT on the click event using data-test-subj.
I'm checking how to report the callout render.

@fkanout
Copy link
Contributor Author

fkanout commented Mar 24, 2025

This is looking good, can we add "EBT" (event-based telemetry) for the appearance of the callout, as well as for clicks on each of the actions?

@jasonrhodes, it's the case for the clicks on each of the actions (Edit rule, Mark as untracked), It will report EBT on the click event using data-test-subj. I'm checking how to report the callout render.

I added teckEvent when the callout appears.

@fkanout fkanout requested a review from benakansara March 24, 2025 09:32
@fkanout fkanout marked this pull request as ready for review March 24, 2025 09:36
@fkanout fkanout requested review from a team as code owners March 24, 2025 09:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 24, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

cauemarcondes
cauemarcondes approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs shared changes LGTM

benakansara
benakansara approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think we need to update the copy and stale criteria (to only check number of days) as per #213003 (comment)

@maciejforcone
Copy link

maciejforcone commented Mar 27, 2025

@fkanout please change "Edit rule" to secondary button style, just like in the mockup:

image

@fkanout fkanout enabled auto-merge (squash) March 28, 2025 13:40
@fkanout fkanout merged commit 4bbfc85 into elastic:main Mar 28, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 28, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14132343260

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 28, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 1317 1318 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +2.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
observability 48 49 +1

Total ESLint disabled count

id before after diff
observability 49 50 +1

History

cc @fkanout

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 28, 2025
@fkanout
[OBX-UX-MGTM] Add stale alert insight (elastic#215332)
66cfedd 
## Summary

If fixes elastic#213003 by adding a
stale alert insight to the alert details page

 ### The heuristics to show the stale alert callout are:
 1. The alert has been active for more than 5 days
<del> 2. The alert has no cases associated with it</d>
<del> 3. The rule is snoozed with no notifications</d>

### Callout stale alert - First Iteration Preview
<img width="1193" alt="Screenshot 2025-03-28 at 13 11 21"
src="https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075"
/>

https://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8

---------

(cherry picked from commit 4bbfc85)
@kibanamachine kibanamachine mentioned this pull request Mar 28, 2025
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 28, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Mar 28, 2025
Merged
Merged
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@fkanout @cqliu1
[OBX-UX-MGTM] Add stale alert insight (elastic#215332)
7483c5d 
## Summary

If fixes elastic#213003 by adding a
stale alert insight to the alert details page

 ### The heuristics to show the stale alert callout are:
 1. The alert has been active for more than 5 days
<del> 2. The alert has no cases associated with it</d>
<del> 3. The rule is snoozed with no notifications</d>

### Callout stale alert - First Iteration Preview
<img width="1193" alt="Screenshot 2025-03-28 at 13 11 21"
src="https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075"
/>






https://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8

---------
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 1, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215332 locally

@benakansara benakansara added backport:skip This PR does not require backporting and removed backport:prev-minor labels Apr 2, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 2, 2025
@benakansara
Copy link
Contributor

benakansara commented Apr 2, 2025

added backport:skip label since we don't want to backport it

@mgiota
Copy link
Contributor

mgiota commented May 26, 2025

@jasonrhodes @benakansara I am confused a bit here regarding skipping this backport. I am trying to backport this PR and I have a few conflicts to resolve. One of them was in kibana/x-pack/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx regarding Stale alerts. The recent guidance I got was that everything goes to 8.19 and 9.1 right now. Shall we backport this PR then?

@benakansara
Copy link
Contributor

benakansara commented May 26, 2025 •
edited
Loading

@mgiota We had originally backport:prev-minor on the PR which triggered backport to 9.0 which we don't want, so I added backport:skip (to stop getting notifications about missing backport). We should backport it to 8.19 though.

@benakansara benakansara added backport:version Backport to applied version labels v8.19.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This PR does not require backporting auto-backport Deprecated - use backport:version if exact versions are needed labels May 26, 2025
@benakansara benakansara mentioned this pull request May 26, 2025
Merged
@benakansara
Copy link
Contributor

benakansara commented May 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

benakansara pushed a commit to benakansara/kibana that referenced this pull request May 26, 2025
@fkanout
[OBX-UX-MGTM] Add stale alert insight (elastic#215332)
6b14dc6 
## Summary

If fixes elastic#213003 by adding a
stale alert insight to the alert details page

 ### The heuristics to show the stale alert callout are:
 1. The alert has been active for more than 5 days
<del> 2. The alert has no cases associated with it</d>
<del> 3. The rule is snoozed with no notifications</d>

### Callout stale alert - First Iteration Preview
<img width="1193" alt="Screenshot 2025-03-28 at 13 11 21"
src="https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075"
/>

https://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8

---------

(cherry picked from commit 4bbfc85)
benakansara added a commit that referenced this pull request May 26, 2025
@benakansara @fkanout
[8.19] [OBX-UX-MGTM] Add stale alert insight (#215332) (#221489)
1d03078 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[OBX-UX-MGTM] Add stale alert insight
(#215332)](#215332)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Faisal
Kanout","email":"faisal.kanout@elastic.co"},"sourceCommit":{"committedDate":"2025-03-28T15:26:19Z","message":"[OBX-UX-MGTM]
Add stale alert insight (#215332)\n\n## Summary\n\nIf fixes
#213003 by adding a\nstale alert
insight to the alert details page\n\n ### The heuristics to show the
stale alert callout are:\n 1. The alert has been active for more than 5
days\n<del> 2. The alert has no cases associated with it</d>\n<del> 3.
The rule is snoozed with no notifications</d>\n\n### Callout stale alert
- First Iteration Preview\n<img width=\"1193\" alt=\"Screenshot
2025-03-28 at 13 11
21\"\nsrc=\"https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075\"\n/>\n\n\n\n\n\n\nhttps://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8\n\n---------","sha":"4bbfc85ebdc63663af7473fd7ce1e4f8d3911ee5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[OBX-UX-MGTM]
Add stale alert insight
","number":215332,"url":"https://github.com/elastic/kibana/pull/215332","mergeCommit":{"message":"[OBX-UX-MGTM]
Add stale alert insight (#215332)\n\n## Summary\n\nIf fixes
#213003 by adding a\nstale alert
insight to the alert details page\n\n ### The heuristics to show the
stale alert callout are:\n 1. The alert has been active for more than 5
days\n<del> 2. The alert has no cases associated with it</d>\n<del> 3.
The rule is snoozed with no notifications</d>\n\n### Callout stale alert
- First Iteration Preview\n<img width=\"1193\" alt=\"Screenshot
2025-03-28 at 13 11
21\"\nsrc=\"https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075\"\n/>\n\n\n\n\n\n\nhttps://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8\n\n---------","sha":"4bbfc85ebdc63663af7473fd7ce1e4f8d3911ee5"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215332","number":215332,"mergeCommit":{"message":"[OBX-UX-MGTM]
Add stale alert insight (#215332)\n\n## Summary\n\nIf fixes
#213003 by adding a\nstale alert
insight to the alert details page\n\n ### The heuristics to show the
stale alert callout are:\n 1. The alert has been active for more than 5
days\n<del> 2. The alert has no cases associated with it</d>\n<del> 3.
The rule is snoozed with no notifications</d>\n\n### Callout stale alert
- First Iteration Preview\n<img width=\"1193\" alt=\"Screenshot
2025-03-28 at 13 11
21\"\nsrc=\"https://github.com/user-attachments/assets/638e4926-483b-4728-8580-50ea8872a075\"\n/>\n\n\n\n\n\n\nhttps://github.com/user-attachments/assets/55717eff-27e9-43a3-95c7-7d41b74f1ff8\n\n---------","sha":"4bbfc85ebdc63663af7473fd7ce1e4f8d3911ee5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@benakansara benakansara benakansara approved these changes

Assignees

@fkanout fkanout

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Incident Management] [Alert details] Stale alert

8 participants

@fkanout @jasonrhodes @elasticmachine @maciejforcone @kibanamachine @benakansara @mgiota @cauemarcondes