[Lens] fix toEsql test use all-year UTC timezone#216425
Merged
stratoula merged 1 commit intoelastic:mainfrom Mar 31, 2025
Merged
[Lens] fix toEsql test use all-year UTC timezone#216425stratoula merged 1 commit intoelastic:mainfrom
stratoula merged 1 commit intoelastic:mainfrom
Conversation
markov00
added
test
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
Force merging as it unlocks main |
markov00
added
backport:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
## Summary The test should verify if a timezone that falls under UTC offset can correctly transform a formBased lens configuation to an ESQL query. Unfortunately the choosen timezone (Europe/London) falls under UTC only when not in DST. I've selected one of the few countries that falls under UTC all year round to have this test pass correctly independently on when it is executed.
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Apr 28, 2025
## Summary The test should verify if a timezone that falls under UTC offset can correctly transform a formBased lens configuation to an ESQL query. Unfortunately the choosen timezone (Europe/London) falls under UTC only when not in DST. I've selected one of the few countries that falls under UTC all year round to have this test pass correctly independently on when it is executed. (cherry picked from commit 7bea047)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test should verify if a timezone that falls under UTC offset can correctly transform a formBased lens configuation to an ESQL query.
Unfortunately the choosen timezone (Europe/London) falls under UTC only when not in DST.
I've selected one of the few countries that falls under UTC all year round to have this test pass correctly independently on when it is executed.