[Dataset Quality] Fix brittle test which was failing in the midnight job#216260
Merged
achyutjhunjhunwala merged 4 commits intoelastic:mainfrom Mar 28, 2025
Merged
Conversation
…ing present in the index name
achyutjhunjhunwala
added
bug
achyutjhunjhunwala
added
backport:version
yngrdyn
reviewed
Mar 28, 2025
...st/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_fields.ts
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 28, 2025
...st/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_fields.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/14132078669 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 28, 2025
…job (elastic#216260) This PR fixes a bug where the test would run at midnight and due to the odd timing, the index which gets created is asserted for a different date than expected. With this fix, we don't check the complete index name now by replacing the date assertion part with startWith and endsWith assertions. (cherry picked from commit 0f0ee3a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 28, 2025
…job (elastic#216260) This PR fixes a bug where the test would run at midnight and due to the odd timing, the index which gets created is asserted for a different date than expected. With this fix, we don't check the complete index name now by replacing the date assertion part with startWith and endsWith assertions. (cherry picked from commit 0f0ee3a)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 28, 2025
…dnight job (#216260) (#216318) # Backport This will backport the following commits from `main` to `8.18`: - [[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)](#216260) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2025-03-28T15:13:05Z","message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-major","Feature:Dataset Health","v9.1.0","Team:Obs UX Logs"],"title":"[Dataset Quality] Fix brittle test which was failing in the midnight job","number":216260,"url":"https://github.com/elastic/kibana/pull/216260","mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216260","number":216260,"mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 28, 2025
…night job (#216260) (#216320) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)](#216260) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2025-03-28T15:13:05Z","message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-major","Feature:Dataset Health","v9.1.0","Team:Obs UX Logs"],"title":"[Dataset Quality] Fix brittle test which was failing in the midnight job","number":216260,"url":"https://github.com/elastic/kibana/pull/216260","mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216260","number":216260,"mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…job (elastic#216260) This PR fixes a bug where the test would run at midnight and due to the odd timing, the index which gets created is asserted for a different date than expected. With this fix, we don't check the complete index name now by replacing the date assertion part with startWith and endsWith assertions.
gbamparop
added
Team:obs-onboarding
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the test would run at midnight and due to the odd timing, the index which gets created is asserted for a different date than expected.
With this fix, we don't check the complete index name now by replacing the date assertion part with startWith and endsWith assertions.