[Solution Side Nav] Misc UI fixes#216109
Merged
tsullivan merged 5 commits intoelastic:mainfrom Mar 28, 2025
Merged
Conversation
tsullivan
added
Team:SharedUX
tsullivan
force-pushed
the
sidenav/misc-panel-fixes-ii
branch
from
ce92569 to
3838f7b
Compare
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
2 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @tsullivan |
Dosant
approved these changes
Mar 28, 2025
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
thanks for splitting by commits 👍
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14133202034 |
tsullivan
added
v9.0.0
v8.19.0
backport:version
Contributor
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14133219828 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
Part of elastic/kibana-team#1439 Pulled from elastic#210893 elastic#215969 ## Summary 1. Allow item in the secondary panel to use the `renderItem` field 2. Fix handling of `defaultIsCollapsed` for items in the secondary panel 3. Allow secondary panel to contain a mix of ungrouped items as well as sub-groups of items  4. Fix the flagging of the "active" parent in the main nav panel, based on the current URL  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 4, 2025
Part of elastic/kibana-team#1439 Pulled from elastic#210893 elastic#215969 ## Summary 1. Allow item in the secondary panel to use the `renderItem` field 2. Fix handling of `defaultIsCollapsed` for items in the secondary panel 3. Allow secondary panel to contain a mix of ungrouped items as well as sub-groups of items  4. Fix the flagging of the "active" parent in the main nav panel, based on the current URL  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 05a8703) # Conflicts: # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 4, 2025
Part of elastic/kibana-team#1439 Pulled from elastic#210893 elastic#215969 ## Summary 1. Allow item in the secondary panel to use the `renderItem` field 2. Fix handling of `defaultIsCollapsed` for items in the secondary panel 3. Allow secondary panel to contain a mix of ungrouped items as well as sub-groups of items  4. Fix the flagging of the "active" parent in the main nav panel, based on the current URL  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 05a8703) # Conflicts: # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx
tsullivan
added a commit
that referenced
this pull request
Apr 4, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Solution Side Nav] Misc UI fixes (#216109)](#216109) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-28T16:12:12Z","message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team:SharedUX","backport:version","v9.1.0","v8.19.0"],"title":"[Solution Side Nav] Misc UI fixes","number":216109,"url":"https://github.com/elastic/kibana/pull/216109","mergeCommit":{"message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216109","number":216109,"mergeCommit":{"message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
tsullivan
added a commit
that referenced
this pull request
Apr 4, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Solution Side Nav] Misc UI fixes (#216109)](#216109) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-28T16:12:12Z","message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team:SharedUX","backport:version","v9.1.0","v8.19.0"],"title":"[Solution Side Nav] Misc UI fixes","number":216109,"url":"https://github.com/elastic/kibana/pull/216109","mergeCommit":{"message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216109","number":216109,"mergeCommit":{"message":"[Solution Side Nav] Misc UI fixes (#216109)\n\nPart of https://github.com/elastic/kibana-team/issues/1439\nPulled from https://github.com/elastic/kibana/pull/210893\nhttps://github.com/elastic/kibana/pull/215969\n\n## Summary\n\n1. Allow item in the secondary panel to use the `renderItem` field\n2. Fix handling of `defaultIsCollapsed` for items in the secondary panel\n3. Allow secondary panel to contain a mix of ungrouped items as well as\nsub-groups of items\n\n\n\n\n4. Fix the flagging of the \"active\" parent in the main nav panel, based\non the current URL\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"05a8703d48b551f51248319a045cdf9786584df1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/elastic/kibana-team/issues/1439
Pulled from #210893 #215969
Summary
renderItemfielddefaultIsCollapsedfor items in the secondary panelChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.