Update task state version after execution.#215559
Merged
ersin-erdal merged 2 commits intoelastic:mainfrom Mar 27, 2025
Merged
Conversation
ersin-erdal
added
release_note:fix
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @ersin-erdal |
Contributor
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14118946198 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 28, 2025
This PR fixes the missing stateVersion update in the `partialUpdate` method. [update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62) method already uses the validated task that already has the stateVersion field. but the `partialUpdate` misses it. (cherry picked from commit 6373b0c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 28, 2025
This PR fixes the missing stateVersion update in the `partialUpdate` method. [update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62) method already uses the validated task that already has the stateVersion field. but the `partialUpdate` misses it. (cherry picked from commit 6373b0c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Mar 28, 2025
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
This PR fixes the missing stateVersion update in the `partialUpdate` method. [update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62) method already uses the validated task that already has the stateVersion field. but the `partialUpdate` misses it.
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Apr 2, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Update task state version after execution. (#215559)](#215559) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-27T23:58:41Z","message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v9.0.0","backport:version","v9.1.0","v8.19.0"],"title":"Update task state version after execution.","number":215559,"url":"https://github.com/elastic/kibana/pull/215559","mergeCommit":{"message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215559","number":215559,"mergeCommit":{"message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 2, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Update task state version after execution. (#215559)](#215559) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-27T23:58:41Z","message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v9.0.0","backport:version","v9.1.0","v8.19.0"],"title":"Update task state version after execution.","number":215559,"url":"https://github.com/elastic/kibana/pull/215559","mergeCommit":{"message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215559","number":215559,"mergeCommit":{"message":"Update task state version after execution. (#215559)\n\nThis PR fixes the missing stateVersion update in the `partialUpdate`\nmethod.\n\n\n[update](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/task_manager/server/buffered_task_store.ts#L62)\nmethod already uses the validated task that already has the stateVersion\nfield.\n\nbut the `partialUpdate` misses it.","sha":"6373b0c65a084088f4ac455c59bdc11e72b1b5d7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing stateVersion update in the
partialUpdatemethod.update method already uses the validated task that already has the stateVersion field.
but the
partialUpdatemisses it.