Skip to content

Upgrade EUI to v99.4.0 #212974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 5 commits into from
Mar 5, 2025
Merged

Upgrade EUI to v99.4.0 #212974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccc4179
update `@elastic/eui` to 99.4.0-borealis.0
tkajtoch Mar 3, 2025
b403c8b
fix: add type cast to resolve `never` type due to type complexity
tkajtoch Mar 3, 2025
24153f5
test: update snapshots changed due to the `EuiComboBox` accessibility…
tkajtoch Mar 3, 2025
8c6fa4a
test: fix "allows the user to expand/collapse selector" to check numb…
tkajtoch Mar 3, 2025
22a78d0
Merge branch 'main' into feat/eui-99.4.0
elasticmachine Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"@elastic/ecs": "^8.11.5",
"@elastic/elasticsearch": "9.0.0-alpha.3",
"@elastic/ems-client": "8.6.3",
"@elastic/eui": "99.3.0-borealis.0",
"@elastic/eui": "99.4.0-borealis.0",
"@elastic/eui-theme-borealis": "0.0.11",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "^1.2.3",
Expand Down
5 changes: 5 additions & 0 deletions ...ackages/chrome/browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const LICENSE_OVERRIDES = {
'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/ems-client@8.6.3': ['Elastic License 2.0'],
'@elastic/eui@99.3.0-borealis.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'@elastic/eui@99.4.0-borealis.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'@elastic/eui-theme-borealis@0.0.11': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary
Expand Down
3 changes: 3 additions & 0 deletions .../public/share/share_context_menu/__snapshots__/screen_capture_panel_content.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion ...m/packages/shared/shared-ux/chrome/navigation/src/ui/components/navigation_section_ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,9 @@ export const NavigationSectionUI: FC<Props> = React.memo(({ navNode: _navNode })
}, [topLevelItems, serializeAccordionItems]);

if (!isEuiCollapsibleNavItemProps(props)) {
throw new Error(`Invalid EuiCollapsibleNavItem props for node ${props.id}`);
throw new Error(
`Invalid EuiCollapsibleNavItem props for node ${(props as EuiCollapsibleNavSubItemProps).id}`
Copy link
Member Author

@tkajtoch tkajtoch Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the updated types in https://github.com/elastic/eui/pull/8332/files#diff-86282e52a76bc99796d93869317a478caec87064dc42551ac89ca2fc2950a2d5 TS has a hard time getting the right type here resulting in props being of type never after the isEuiCollapsibleNavItemProps check.

We'll be reassessing EUI's more complex types to get rid of this and similar issues.

);
}

if (!isVisible) {
Expand Down
4 changes: 4 additions & 0 deletions ...tysolution-autocomplete/src/es_field_selector/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions ...urity/plugins/cloud_defend/public/components/control_general_view_selector/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,12 +667,11 @@ describe('<ControlGeneralViewSelector />', () => {
const selector = getByTestId('cloud-defend-selector');

// should start as closed.
// there are two mock selectors, and the last one will auto open
Copy link
Member Author

@tkajtoch tkajtoch Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrect. The old length of 2 was not a result of 2 selectors being rendered but each EuiAccordionTrigger rendering two collapse/expand buttons - one button icon for the arrow and one as a wrapper for the buttonContent. This was recently fixed in elastic/eui#8342 by adding aria-hidden to the button icon making it ignored by RTL

expect(
await within(selector).findAllByRole('button', {
expanded: false,
})
).toHaveLength(2);
).toHaveLength(1);
expect(
within(selector).queryByRole('button', {
expanded: true,
Expand All @@ -696,7 +695,7 @@ describe('<ControlGeneralViewSelector />', () => {
await within(selector).findAllByRole('button', {
expanded: true,
})
).toHaveLength(2);
).toHaveLength(1);

expect(queryByTestId('cloud-defend-conditions-count')).not.toBeInTheDocument();
});
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2292,10 +2292,10 @@
chroma-js "^2.4.2"
lodash "^4.17.21"

"@elastic/eui@99.3.0-borealis.0":
version "99.3.0-borealis.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-99.3.0-borealis.0.tgz#e8c26a9d160783682bcdeea65846d8295e7cd391"
integrity sha512-T88s2vQHEHy6g/mA8K2cDr3IUKFGZcdNHFIRUqJwYjBW6JwHyLkrFZuFweK88IyJv1F8vsTv1RlCeeta/AZlLA==
"@elastic/eui@99.4.0-borealis.0":
version "99.4.0-borealis.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-99.4.0-borealis.0.tgz#8637698371fa3c6827da4f7cb689d3cd39de3841"
integrity sha512-ws2OVe67WrO9CBkembcqBXFh3Lo10HRvk19MZZL22RoZ3dyGlNr0WTxvZpLPEykycOaOCnf3hAo9p8V16wPWvw==
dependencies:
"@elastic/eui-theme-common" "0.0.10"
"@elastic/prismjs-esql" "^1.0.0"
Expand Down