Merged
Conversation
The platform plugin builds were used at a time when functional tests were, at times, run from source. This is mostly no longer a requirement. There are two remaining cypress scripts that I updated to use the build instead.
Contributor
Author
|
buildkite test this |
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
Author
|
buildkite test this |
Contributor
Author
|
buildkite test this |
Contributor
Author
|
buildkite test this |
Contributor
Author
|
Build testing the defend workflows changes: https://buildkite.com/elastic/kibana-pull-request/builds/247852 |
This reverts commit 94d2d6d.
jbudz
added
Team:Operations
Contributor
Author
|
buildkite test this |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
requested review from
a team,
pzl and
szwarckonrad
and removed request for
a team
pzl
approved these changes
Nov 5, 2024
szwarckonrad
approved these changes
Nov 5, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11710943161 |
Contributor
Author
|
I'm going to leave the backport unresolved for a while to monitor for issues. This expectation has been built in to most of our test pipelines for years, there's a decent chance I missed something and will need to revert. |
Contributor
💔 All backports failedManual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 7, 2024
The platform plugin builds were used when functional tests were, at times, run from source. This is mostly no longer a requirement. There are two remaining cypress scripts that I updated to use the build instead. With the time saved I'm dropping the number of vCPUs from 16 to 8. These are mostly underutilized by this step, with the exception of the distribution plugin build.
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
3 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
6 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
jbudz
added a commit
that referenced
this pull request
Nov 25, 2024
kibanamachine
removed
the
backport missing
pheyos
added a commit
that referenced
this pull request
Jan 8, 2025
…205896) ## Summary This PR fixes the performance test pipelines by removing the bits that rely on the plugins build. ### Details * The plugin build has been removed with #197125. Since the performance pipelines are running against a Kibana build (and not against sources), they should not need the plugin build. * The `performance-data-set-extraction` pipeline started to fail immediately after the plugin build has been removed * This failure went unnoticed since the `scalability-benchmarking` pipeline continued to work by using the last uploaded artifacts from the `performance-data-set-extraction` pipeline, which were available for another month. Once the old artifacts were no longer available, the `scalability-benchmarking` pipeline also started to fail.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205896) ## Summary This PR fixes the performance test pipelines by removing the bits that rely on the plugins build. ### Details * The plugin build has been removed with elastic#197125. Since the performance pipelines are running against a Kibana build (and not against sources), they should not need the plugin build. * The `performance-data-set-extraction` pipeline started to fail immediately after the plugin build has been removed * This failure went unnoticed since the `scalability-benchmarking` pipeline continued to work by using the last uploaded artifacts from the `performance-data-set-extraction` pipeline, which were available for another month. Once the old artifacts were no longer available, the `scalability-benchmarking` pipeline also started to fail. (cherry picked from commit 9bdc995)
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…nes (#205896) (#205930) # Backport This will backport the following commits from `main` to `8.x`: - [Remove usage of Kibana plugins build in performance test pipelines (#205896)](#205896) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"robert.oskamp@elastic.co"},"sourceCommit":{"committedDate":"2025-01-08T16:15:33Z","message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"Remove usage of Kibana plugins build in performance test pipelines","number":205896,"url":"https://github.com/elastic/kibana/pull/205896","mergeCommit":{"message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205896","number":205896,"mergeCommit":{"message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…lastic#205896) ## Summary This PR fixes the performance test pipelines by removing the bits that rely on the plugins build. ### Details * The plugin build has been removed with elastic#197125. Since the performance pipelines are running against a Kibana build (and not against sources), they should not need the plugin build. * The `performance-data-set-extraction` pipeline started to fail immediately after the plugin build has been removed * This failure went unnoticed since the `scalability-benchmarking` pipeline continued to work by using the last uploaded artifacts from the `performance-data-set-extraction` pipeline, which were available for another month. Once the old artifacts were no longer available, the `scalability-benchmarking` pipeline also started to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform plugin builds were used when functional tests were, at times, run from source.
This is mostly no longer a requirement. There are two remaining cypress scripts that I updated to use the build instead.
With the time saved I'm dropping the number of vCPUs from 16 to 8. These are mostly underutilized by this step, with the exception of the distribution plugin build.