Pass bulkPartialUpdate errors to taskStore.errors#198606
Merged
ersin-erdal merged 6 commits intoelastic:mainfrom Nov 6, 2024
Merged
Pass bulkPartialUpdate errors to taskStore.errors#198606ersin-erdal merged 6 commits intoelastic:mainfrom
ersin-erdal merged 6 commits intoelastic:mainfrom
Conversation
ersin-erdal
added
Team:ResponseOps
# Conflicts: # x-pack/plugins/task_manager/server/lib/create_managed_configuration.ts
pmuellr
requested changes
Oct 31, 2024
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, besides the comment I made about the optional message parameter
| type, | ||
| }: { | ||
| statusCode: number; | ||
| message?: string; |
Contributor
There was a problem hiding this comment.
I don't think this should be optioonal. No idea what Error() does :-)
I think the potential undefined comes from the task_store usage, accessing item.update.error.reason, which is optional. Let's use a message like bulk update failed with unknown reason
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
approved these changes
Nov 5, 2024
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, left a nit comment ...
| } | ||
|
|
||
| export function getBulkUpdateStatusCode(error: Error | BulkUpdateError): number | undefined { | ||
| if (Boolean(error && error instanceof BulkUpdateError)) { |
Contributor
There was a problem hiding this comment.
nit: I think this has the same result, with no cast :-)
if (!(error instanceof BulkUpdateError)) return;
return error.statusCode;
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11709378310 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
Resolves: elastic#198428 (cherry picked from commit 9f4d88e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
…99205) # Backport This will backport the following commits from `main` to `8.x`: - [Pass bulkPartialUpdate errors to taskStore.errors (#198606)](#198606) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-06T18:09:00Z","message":"Pass bulkPartialUpdate errors to taskStore.errors (#198606)\n\nResolves: #198428","sha":"9f4d88e4b5e491e53aa4cc0b2f6394f5a26e8d9c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"title":"Pass bulkPartialUpdate errors to taskStore.errors","number":198606,"url":"https://github.com/elastic/kibana/pull/198606","mergeCommit":{"message":"Pass bulkPartialUpdate errors to taskStore.errors (#198606)\n\nResolves: #198428","sha":"9f4d88e4b5e491e53aa4cc0b2f6394f5a26e8d9c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198606","number":198606,"mergeCommit":{"message":"Pass bulkPartialUpdate errors to taskStore.errors (#198606)\n\nResolves: #198428","sha":"9f4d88e4b5e491e53aa4cc0b2f6394f5a26e8d9c"}}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #198428