[SecuritySolution] Check user permissions before initialising entity engine by machadoum · Pull Request #198661 · elastic/kibana

machadoum · 2024-11-01T12:05:23Z

Summary

Create privileges API for the Entity Store
Create missing privileges callout
Add missing Entity Store privileges callout to Entity Store
Add missing Entity Store privileges callout to Dashboard

Nov-04-2024.15-56-55.mp4

Update:

I added a "Line clamp" and "Read More" button as requested by Mark:

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

elasticmachine · 2024-11-04T15:16:56Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2024-11-04T15:16:57Z

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

machadoum · 2024-11-04T15:23:11Z

Discussion Topic: I am checking privileges for all security solution indices. Is that the best approach?

hop-dev · 2024-11-04T15:31:46Z

@machadoum My initial feedback from just looking at the screenshots is that maybe we should not show all the missing privileges by default if there are a lot, we could have a "see more" to reveal all the permissions issues after the first 5 or so maybe?

machadoum · 2024-11-05T08:31:46Z

@machadoum My initial feedback from just looking at the screenshots is that maybe we should not show all the missing privileges by default if there are a lot, we could have a "see more" to reveal all the permissions issues after the first 5 or so maybe?

@hop-dev Is there another place in Kibana using this pattern? Or do you think we should introduce it?
We could create a generic component that works like this: https://jsfiddle.net/ExplosionPIlls/6sj4e/

I found one place using this pattern inside Security Solution. I will reuse it.

...on/public/entity_analytics/components/entity_store/components/missing_privileges_callout.tsx

tiansivive

a few comments, no blockers but worth discussing a bit imo

tiansivive · 2024-11-05T14:04:17Z

...on/public/entity_analytics/components/entity_store/components/missing_privileges_callout.tsx

+        data-test-subj={`callout-${id}`}
+        data-test-messages={`[${id}]`}
+      >
+        <LineClamp maxHeight="100%" lineClampHeight={4.4}>


maybe extract these magic values?

or is this component copy pasta?

maxHeight is 100% because I don't wanna the container to have a scroll bar.
But lineClampHeight was trial and error. The LineClamp component doesn't work well with non-text content, so I used decimals to compensate.

I will add `lineClampHeight' to a constant and add comments.

tiansivive · 2024-11-05T14:07:55Z

x-pack/plugins/security_solution/common/api/entity_analytics/common/common.schema.yaml

-                      type: boolean
-                    manage_transform:
-                      type: boolean
+                  additionalProperties:


this is outside the scope of this ticket but it's weird to me that we're using OpenAPI to type the privileges object, when we already have TS types for it on kibana side, right?

Yeah, but from what I know, we can't reuse TS types inside OpenAPi schemas. 😞

elasticmachine · 2024-11-05T14:43:54Z

💔 Build Failed

Buildkite Build
Commit: 6997f3d

Failed CI Steps

Check Types

History

cc @machadoum

logeekal

@elastic/security-threat-hunting-investigations code review looks good 🚀 .

Thanks.

tiansivive

Thanks!
I'm approving this PR as I think we can afford to merge this as is.
However, I noticed some inconsistencies.

For example, if we dont have risk score privileges, we also dont have enough privileges for enabling the store. Yet, we can open the modal and the risk score toggle will still be enabled, whilst the entity store one will show the missing privileges callout.

machadoum · 2024-11-06T09:37:52Z

@tiansivive Good call.

I create a follow-up issue to kick-start the discussion. https://github.com/elastic/security-team/issues/11065

kibanamachine · 2024-11-06T10:23:50Z

Starting backport for target branches: 8.18

https://github.com/elastic/kibana/actions/runs/11701634666

kibanamachine · 2024-11-06T10:28:26Z

💔 All backports failed

Status	Branch	Result
❌	8.18	The branch "8.18" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 198661

Questions ?

Please refer to the Backport tool documentation

machadoum · 2024-11-06T15:25:35Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…engine (elastic#198661) ## Summary * Create privileges API for the Entity Store * Create missing privileges callout * Add missing Entity Store privileges callout to Entity Store * Add missing Entity Store privileges callout to Dashboard ![Screenshot 2024-11-04 at 15 57 15](https://github.com/user-attachments/assets/ed013571-4f0d-4605-bd2a-faa5ad3ac3e6) ![Screenshot 2024-11-04 at 16 16 03](https://github.com/user-attachments/assets/4cf6cf7d-a8c1-4c96-8fd1-2bf8be9f785e) https://github.com/user-attachments/assets/30cdb096-24cd-4a1c-a20b-abbbece865d7 ### Update: I added a "Line clamp" and "Read More" button as requested by Mark: ![Screenshot 2024-11-05 at 13 15 51](https://github.com/user-attachments/assets/42fbec93-e258-49af-8acc-ae18314be442) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) (cherry picked from commit 0e3b83b)

kibanamachine · 2024-11-07T10:48:53Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

machadoum force-pushed the siem-ea-10926 branch from 5360934 to 919e657 Compare November 1, 2024 13:13

machadoum added 3 commits November 1, 2024 14:15

Create privileges API for the Entity Store

63b9346

Add entity store priveleges callout to Entity Store page

18cf5fa

Add Entity Store privileges check to Dashboard

65f119b

machadoum force-pushed the siem-ea-10926 branch from 919e657 to 65f119b Compare November 4, 2024 14:58

machadoum self-assigned this Nov 4, 2024

Self code-review

686d467

machadoum marked this pull request as ready for review November 4, 2024 15:16

machadoum requested review from a team as code owners November 4, 2024 15:16

machadoum requested a review from tiansivive November 4, 2024 15:16

machadoum changed the title ~~WIP~~ [SecuritySolution] Check user permissions before initialising entity engine Nov 4, 2024

Merge branch 'main' into siem-ea-10926

b5c049b

machadoum commented Nov 5, 2024

View reviewed changes

...on/public/entity_analytics/components/entity_store/components/missing_privileges_callout.tsx Outdated Show resolved Hide resolved

machadoum added 4 commits November 5, 2024 11:08

Add LineClamp to privileges callout

d3e0c49

Fix type

89dfa05

Fix i18n

43d7a75

Fix i18n

6129833

tiansivive reviewed Nov 5, 2024

View reviewed changes

Fix tests

6997f3d

Make LineClamp component more generic

c252a80

machadoum requested a review from a team as a code owner November 5, 2024 14:46

logeekal approved these changes Nov 5, 2024

View reviewed changes

machadoum added v8.18.0 and removed v8.17.0 labels Nov 6, 2024

tiansivive approved these changes Nov 6, 2024

View reviewed changes

machadoum merged commit 0e3b83b into elastic:main Nov 6, 2024

kibanamachine added the v9.0.0 label Nov 6, 2024

machadoum mentioned this pull request Nov 6, 2024

[8.x] [SecuritySolution] Check user permissions before initialising entity engine (#198661) #199162

Merged

This was referenced Nov 6, 2024

[SecuritySolution][SIEM migrations] Implement background task API #197997

Merged

[ci] Remove plugin build #197125

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 7, 2024

kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 7, 2024

Conversation

machadoum commented Nov 1, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Update:

Checklist

Uh oh!

elasticmachine commented Nov 4, 2024

Uh oh!

elasticmachine commented Nov 4, 2024

Uh oh!

machadoum commented Nov 4, 2024

Uh oh!

hop-dev commented Nov 4, 2024

Uh oh!

machadoum commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tiansivive left a comment

Choose a reason for hiding this comment

Uh oh!

tiansivive Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

tiansivive Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

machadoum Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

tiansivive Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

machadoum Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

logeekal left a comment

Choose a reason for hiding this comment

Uh oh!

tiansivive left a comment

Choose a reason for hiding this comment

Uh oh!

machadoum commented Nov 6, 2024

Uh oh!

kibanamachine commented Nov 6, 2024

Uh oh!

kibanamachine commented Nov 6, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

machadoum commented Nov 6, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

machadoum commented Nov 1, 2024 •

edited by kibanamachine

Loading

machadoum commented Nov 5, 2024 •

edited

Loading

elasticmachine commented Nov 5, 2024 •

edited

Loading