[Search] Move ConnectorDefinition types and consts#197676
[Search] Move ConnectorDefinition types and consts#197676navarone-feekery merged 16 commits intoelastic:mainfrom navarone-feekery:move-connector-definition
ConnectorDefinition types and consts#197676Conversation
navarone-feekery
added
release_note:skip
|
@elasticmachine merge upstream |
sphilipse
left a comment
sphilipse
left a comment
There was a problem hiding this comment.
Overall code looks good but we probably should just rename the keys rather than delete the translations outright
|
@elasticmachine merge upstream |
|
This PR moves a lot of search-connector plugin code to a shared search-connectors package. That code has to be re-imported into search-connectors plugin, which increased the bundle size. I tried to reduce the package size through optimizing the largest offender |
|
Starting backport for target branches: 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11707016546 |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
## Summary - Move types and consts for `ConnectorClientSideDefinition` and `ConnectorServerSideDefinition` to the shared `kbn-search-connectors` package - Update ESS references to these values to use it from the package - Remove them from the connectors plugin (cherry picked from commit 8ed8cc9)
## Summary - Move types and consts for `ConnectorClientSideDefinition` and `ConnectorServerSideDefinition` to the shared `kbn-search-connectors` package - Update ESS references to these values to use it from the package - Remove them from the connectors plugin (cherry picked from commit 8ed8cc9)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…197676) (#199167) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] Move `ConnectorDefinition` types and consts (#197676)](#197676) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"13634519+navarone-feekery@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-06T15:45:22Z","message":"[Search] Move `ConnectorDefinition` types and consts (#197676)\n\n## Summary\r\n\r\n- Move types and consts for `ConnectorClientSideDefinition` and\r\n`ConnectorServerSideDefinition` to the shared `kbn-search-connectors`\r\npackage\r\n- Update ESS references to these values to use it from the package\r\n- Remove them from the connectors plugin","sha":"8ed8cc964e2ec557ea7173cc8cecf17b7f69d0d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.17.0"],"title":"[Search] Move `ConnectorDefinition` types and consts","number":197676,"url":"https://github.com/elastic/kibana/pull/197676","mergeCommit":{"message":"[Search] Move `ConnectorDefinition` types and consts (#197676)\n\n## Summary\r\n\r\n- Move types and consts for `ConnectorClientSideDefinition` and\r\n`ConnectorServerSideDefinition` to the shared `kbn-search-connectors`\r\npackage\r\n- Update ESS references to these values to use it from the package\r\n- Remove them from the connectors plugin","sha":"8ed8cc964e2ec557ea7173cc8cecf17b7f69d0d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197676","number":197676,"mergeCommit":{"message":"[Search] Move `ConnectorDefinition` types and consts (#197676)\n\n## Summary\r\n\r\n- Move types and consts for `ConnectorClientSideDefinition` and\r\n`ConnectorServerSideDefinition` to the shared `kbn-search-connectors`\r\npackage\r\n- Update ESS references to these values to use it from the package\r\n- Remove them from the connectors plugin","sha":"8ed8cc964e2ec557ea7173cc8cecf17b7f69d0d3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Navarone Feekery <13634519+navarone-feekery@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
5 participants
Summary
ConnectorClientSideDefinitionandConnectorServerSideDefinitionto the sharedkbn-search-connectorspackageThis is necessary to allow the improved connector flow from ESS to be usable in ES3, as the components will live in this shared package and cannot access the
ConnectorDefinitiontypes.This PR does not change how Serverless accesses the types, which is still done through importing
getConnectorTypesfunction fromx-pack/plugins/search_connectors/common/lib/connector_types.ts, which is unchanged.I will update serverless in another PR.