Address some of the no_group_crossing dependencies#198261
Merged
gsoldevila merged 16 commits intoelastic:mainfrom Nov 6, 2024
Merged
Address some of the no_group_crossing dependencies#198261gsoldevila merged 16 commits intoelastic:mainfrom
no_group_crossing dependencies#198261gsoldevila merged 16 commits intoelastic:mainfrom
Conversation
gsoldevila
added
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Dosant
approved these changes
Oct 30, 2024
delanni
approved these changes
Oct 30, 2024
mattkime
approved these changes
Oct 30, 2024
Contributor
|
PR Project deployment started at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/71 |
sphilipse
reviewed
Oct 31, 2024
Contributor
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/71 |
PhilippeOberti
approved these changes
Oct 31, 2024
miltonhultgren
approved these changes
Nov 5, 2024
sorenlouv
approved these changes
Nov 5, 2024
mgiota
approved these changes
Nov 5, 2024
Contributor
mgiota
left a comment
mgiota
left a comment
There was a problem hiding this comment.
LGTM! I played with o11y table's column headers and actions and works same as before!
gsoldevila
requested review from
maryam-saeidi
and removed request for
maryam-saeidi
sphilipse
approved these changes
Nov 5, 2024
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11705882876 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Nov 6, 2024
### Summary This PR relocates some plugins and packages that are incorrectly categorised, aiming at reducing inter-solution dependencies. It also fixes some incorrect import statements that introduce unnecessary dependencies with other components. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co> (cherry picked from commit 730f4c9) # Conflicts: # .eslintrc.js # src/plugins/ai_assistant_management/selection/kibana.jsonc # x-pack/packages/kbn-ai-assistant/kibana.jsonc # x-pack/plugins/dashboard_enhanced/kibana.jsonc # x-pack/plugins/observability_solution/observability_ai_assistant/kibana.jsonc # x-pack/plugins/screenshotting/kibana.jsonc
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
gsoldevila
added a commit
that referenced
this pull request
Nov 8, 2024
…199165) # Backport This will backport the following commits from `main` to `8.x`: - [Address some of the `no_group_crossing` dependencies (#198261)](#198261) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-11-06T14:44:35Z","message":"Address some of the `no_group_crossing` dependencies (#198261)\n\n### Summary\r\n\r\nThis PR relocates some plugins and packages that are incorrectly\r\ncategorised, aiming at reducing inter-solution dependencies. It also\r\nfixes some incorrect import statements that introduce unnecessary\r\ndependencies with other components.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"730f4c9d2a5119a9f30e9b94ccb28ec418af270a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability","Team:obs-ux-management"],"number":198261,"url":"https://github.com/elastic/kibana/pull/198261","mergeCommit":{"message":"Address some of the `no_group_crossing` dependencies (#198261)\n\n### Summary\r\n\r\nThis PR relocates some plugins and packages that are incorrectly\r\ncategorised, aiming at reducing inter-solution dependencies. It also\r\nfixes some incorrect import statements that introduce unnecessary\r\ndependencies with other components.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"730f4c9d2a5119a9f30e9b94ccb28ec418af270a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198261","number":198261,"mergeCommit":{"message":"Address some of the `no_group_crossing` dependencies (#198261)\n\n### Summary\r\n\r\nThis PR relocates some plugins and packages that are incorrectly\r\ncategorised, aiming at reducing inter-solution dependencies. It also\r\nfixes some incorrect import statements that introduce unnecessary\r\ndependencies with other components.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"730f4c9d2a5119a9f30e9b94ccb28ec418af270a"}}]}] BACKPORT-->
kibanamachine
added
v8.17.0
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR relocates some plugins and packages that are incorrectly categorised, aiming at reducing inter-solution dependencies. It also fixes some incorrect import statements that introduce unnecessary dependencies with other components.