[Dataset quality] Extracting totalDocs form degradedDocs request#198757
Merged
yngrdyn merged 20 commits intoelastic:mainfrom Nov 6, 2024
Merged
[Dataset quality] Extracting totalDocs form degradedDocs request#198757yngrdyn merged 20 commits intoelastic:mainfrom
yngrdyn merged 20 commits intoelastic:mainfrom
Conversation
yngrdyn
commented
Nov 4, 2024
|
|
||
| export type DataStreamStat = rt.TypeOf<typeof dataStreamStatRt>; | ||
|
|
||
| export const dataStreamDocsStatRt = rt.type({ |
Contributor
Author
There was a problem hiding this comment.
Note
This type is now generic, can be reused by totalDocs and later by failedDocs. There is no need to create one type per each.
x-pack/plugins/observability_solution/dataset_quality/server/routes/data_streams/routes.ts
Show resolved
Hide resolved
...ity_solution/dataset_quality/public/services/data_streams_stats/data_streams_stats_client.ts
Outdated
Show resolved
Hide resolved
...ty_solution/dataset_quality/public/state_machines/dataset_quality_controller/src/defaults.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/public/utils/generate_datasets.ts
Outdated
Show resolved
Hide resolved
yngrdyn
force-pushed
the
183-dataset-quality-failure-docs-api
branch
from
bc15979 to
b7c775b
Compare
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
yngrdyn
added
backport:prev-minor
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dmlemeshko
approved these changes
Nov 5, 2024
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
x-pack/test/api_integration/deployment_agnostic changes LGTM
…rdyn/kibana into 183-dataset-quality-failure-docs-api
...ity_solution/dataset_quality/public/services/data_streams_stats/data_streams_stats_client.ts
Outdated
Show resolved
Hide resolved
...lution/dataset_quality/public/state_machines/dataset_quality_controller/src/notifications.ts
Outdated
Show resolved
Hide resolved
mohamedhamed-ahmed
approved these changes
Nov 6, 2024
Contributor
mohamedhamed-ahmed
left a comment
mohamedhamed-ahmed
left a comment
There was a problem hiding this comment.
LGTM!! Great Work here
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @yngrdyn |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11707814704 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
…stic#198757) Relates to elastic/logs-dev#183 ## Summary This PR aims to split out `total_docs` from `degraded_docs` request. This number is no longer relevant only for degraded docs. This PR is a preparation step for supporting `failed_docs`. ### 🎥 Demo https://github.com/user-attachments/assets/7a826715-64e2-4799-8b54-934698df56e2 #### When no documents are found in the selected timerange https://github.com/user-attachments/assets/de974125-cf45-42d3-932f-32e43b282eb2 #### Filtering datasets https://github.com/user-attachments/assets/398fc7db-1e38-4998-9ecb-10e8644f812d ### TODO - [ ] Test in MKI before merging (cherry picked from commit 3e0ec51)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
#198757) (#199177) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] Extracting totalDocs form degradedDocs request (#198757)](#198757) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2024-11-06T16:29:09Z","message":"[Dataset quality] Extracting totalDocs form degradedDocs request (#198757)\n\nRelates to https://github.com/elastic/logs-dev/issues/183\r\n\r\n## Summary\r\nThis PR aims to split out `total_docs` from `degraded_docs` request.\r\nThis number is no longer relevant only for degraded docs. This PR is a\r\npreparation step for supporting `failed_docs`.\r\n\r\n### 🎥 Demo \r\n\r\nhttps://github.com/user-attachments/assets/7a826715-64e2-4799-8b54-934698df56e2\r\n\r\n#### When no documents are found in the selected timerange\r\n\r\nhttps://github.com/user-attachments/assets/de974125-cf45-42d3-932f-32e43b282eb2\r\n\r\n#### Filtering datasets\r\n\r\nhttps://github.com/user-attachments/assets/398fc7db-1e38-4998-9ecb-10e8644f812d\r\n\r\n### TODO\r\n\r\n- [ ] Test in MKI before merging","sha":"3e0ec510fab85d3b7346eb88b8a3bed0dc5b73f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"[Dataset quality] Extracting totalDocs form degradedDocs request","number":198757,"url":"https://github.com/elastic/kibana/pull/198757","mergeCommit":{"message":"[Dataset quality] Extracting totalDocs form degradedDocs request (#198757)\n\nRelates to https://github.com/elastic/logs-dev/issues/183\r\n\r\n## Summary\r\nThis PR aims to split out `total_docs` from `degraded_docs` request.\r\nThis number is no longer relevant only for degraded docs. This PR is a\r\npreparation step for supporting `failed_docs`.\r\n\r\n### 🎥 Demo \r\n\r\nhttps://github.com/user-attachments/assets/7a826715-64e2-4799-8b54-934698df56e2\r\n\r\n#### When no documents are found in the selected timerange\r\n\r\nhttps://github.com/user-attachments/assets/de974125-cf45-42d3-932f-32e43b282eb2\r\n\r\n#### Filtering datasets\r\n\r\nhttps://github.com/user-attachments/assets/398fc7db-1e38-4998-9ecb-10e8644f812d\r\n\r\n### TODO\r\n\r\n- [ ] Test in MKI before merging","sha":"3e0ec510fab85d3b7346eb88b8a3bed0dc5b73f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198757","number":198757,"mergeCommit":{"message":"[Dataset quality] Extracting totalDocs form degradedDocs request (#198757)\n\nRelates to https://github.com/elastic/logs-dev/issues/183\r\n\r\n## Summary\r\nThis PR aims to split out `total_docs` from `degraded_docs` request.\r\nThis number is no longer relevant only for degraded docs. This PR is a\r\npreparation step for supporting `failed_docs`.\r\n\r\n### 🎥 Demo \r\n\r\nhttps://github.com/user-attachments/assets/7a826715-64e2-4799-8b54-934698df56e2\r\n\r\n#### When no documents are found in the selected timerange\r\n\r\nhttps://github.com/user-attachments/assets/de974125-cf45-42d3-932f-32e43b282eb2\r\n\r\n#### Filtering datasets\r\n\r\nhttps://github.com/user-attachments/assets/398fc7db-1e38-4998-9ecb-10e8644f812d\r\n\r\n### TODO\r\n\r\n- [ ] Test in MKI before merging","sha":"3e0ec510fab85d3b7346eb88b8a3bed0dc5b73f5"}}]}] BACKPORT--> --------- Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/elastic/logs-dev/issues/183
Summary
This PR aims to split out
total_docsfromdegraded_docsrequest. This number is no longer relevant only for degraded docs. This PR is a preparation step for supportingfailed_docs.🎥 Demo
Screen.Recording.2024-11-05.at.22.55.13.mov
When no documents are found in the selected timerange
Screen.Recording.2024-11-05.at.23.11.43.mov
Filtering datasets
Screen.Recording.2024-11-05.at.23.13.20.mov
TODO