test: add missing await for connector table disappearance#175430

Merged

delanni merged 2 commits intoelastic:mainfrom

delanni:add-missing-await

Jan 24, 2024

Contributor

delanni commented Jan 24, 2024

Summary

There's been a few recent failures in this test:
https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd
https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637

I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the Unhandled Promise rejection detected: kind of errors, since we'll now wait for the expression.

cc: @saarikabhasi


          test: add missing await for connector table disappearance

898f9f9

delanni requested a review from saarikabhasi

January 24, 2024 13:29

delanni added release_note:fix release_note:skip auto-backport and removed release_note:fix labels

delanni commented

View reviewed changes

x-pack/test_serverless/functional/page_objects/svl_search_connectors_page.ts Outdated Show resolved Hide resolved

saarikabhasi approved these changes

View reviewed changes

Member

saarikabhasi left a comment •

edited

Loading

changes LGTM.

Quick question: is there a better way to test these FTR tests to avoid the failures like this in future?

Reason I am asking is, I did not see these errors when I was testing locally, with my PR CIs, and MKI tests. and I am worried if I have missed any aspect of testing here. Thanks in advance!


          Update x-pack/test_serverless/functional/page_objects/svl_search_conn…

1d02f1a

…ectors_page.ts

Contributor Author

delanni commented Jan 24, 2024

@saarikabhasi - the only thing I can think of is the flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner

You can set up your proposed changes, then run several retries on the same case, to see if it still occasionally happens or is quite reliably stable.

delanni enabled auto-merge (squash)

January 24, 2024 15:58

kibana-ci commented Jan 24, 2024

💚 Build Succeeded

Buildkite Build
Commit: 1d02f1a

Metrics [docs]

✅ unchanged

History

💛 Build #188975 was flaky 898f9f9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

delanni merged commit 8b7ceea into elastic:main

delanni mentioned this pull request

[Ops] More resilient test failure collection #175423

Closed

jloleysens added a commit that referenced this pull request


          Merge branch 'main' into versioned-router-and-oas

f5151f6

* main: (520 commits)
  Update Kibana code editor dependencies (#171720)
  [SLOs] Hide view in app in slo alerts table in slo details page (#175441)
  [api-docs] 2024-01-25 Daily api_docs build (#175502)
  [DOCS] Add buildkite links to doc preview comments (#175463)
  skip flaky suite (#175443)
  [Security Solution][Timeline] refactor timeline modal save timeline button (#175343)
  [RAM] Stack Management::Rules loses user selections when navigating back (#174954)
  [Security Solution][Timeline] refactor timeline modal attach to case button (#175163)
  Upgrade EUI to v92.1.1 (#174955)
  [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634)
  [Cloud Security] Rules Combo Box filters Custom component (#175175)
  skip flaky suite (#175407)
  [Security Solution][Timeline] refactor timeline modal open timeline button (#175335)
  [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348)
  [Console] disable access to embedded console without dev tools capability (#175321)
  fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809)
  [Security Solution] Data quality dashboard persistence (#173185)
  [RAM][Observability] Add alert fields table to Observability flyout (#174685)
  test: add missing await for connector table disappearance (#175430)
  [RAM][Maintenance Window] Fix maintenance window FE types and transforms  (#173888)
  ...

kibanamachine added the backport missing label

Contributor

kibanamachine commented Jan 26, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request


          test: add missing await for connector table disappearance (elastic#17…

ff8ee8d

…5430)

## Summary
There's been a few recent failures in this test:

https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd

https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637

I don't know if this small addition will make any difference in the test
timing out, but it will probably avoid the `Unhandled Promise rejection
detected:` kind of errors, since we'll now wait for the expression.

cc: @saarikabhasi

Contributor

kibanamachine commented Feb 18, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

5 similar comments

Contributor

kibanamachine commented Jul 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

Contributor

kibanamachine commented Sep 5, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

Contributor

kibanamachine commented Sep 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 175430 locally

jbudz added the backport:skip label

kibanamachine removed the backport missing label

delanni deleted the add-missing-await branch

November 11, 2025 10:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport backport:skip release_note:skip