Skip to content

[Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings.#170634

Merged
kpollich merged 3 commits intoelastic:mainfrom
gitstart:ELS-187
Jan 24, 2024
Merged

[Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings.#170634
kpollich merged 3 commits intoelastic:mainfrom
gitstart:ELS-187

Conversation

@gitstart
Copy link
Contributor

@gitstart gitstart commented Nov 6, 2023

What does this PR do?

  • It fixes the consistency of displaying the "Beta" label in the proxies under the Fleet Server settings page.

Issue References

Screenshot Demo

Before:

image

Fix:

image


This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

…xy under Fleet settings.

Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-187 - [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. Nov 6, 2023
@gitstart gitstart marked this pull request as ready for review November 6, 2023 12:42
@gitstart gitstart requested a review from a team as a code owner November 6, 2023 12:42
@kpollich
Copy link
Member

kpollich commented Nov 6, 2023

buildkite test this

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich added the release_note:skip Skip the PR/issue when compiling release notes label Nov 6, 2023
@kpollich
Copy link
Member

kpollich commented Nov 6, 2023

buildkite test this

@kpollich
Copy link
Member

kpollich commented Nov 6, 2023

FYI the screenshots in the description are 404's.

@kpollich kpollich enabled auto-merge (squash) November 6, 2023 15:36
auto-merge was automatically disabled November 7, 2023 05:06

Merge queue setting changed

@kpollich
Copy link
Member

@elasticmachine merge upstream

@kpollich
Copy link
Member

/ci

@kpollich
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@kpollich kpollich enabled auto-merge (squash) January 24, 2024 19:04
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / Actions and Triggers app logs list "after all" hook for "should not show the logs space switch when multiple spaces exist but only one is accessible"
  • [job] [logs] FTR Configs #32 / Actions and Triggers app logs list should not show the logs space switch when multiple spaces exist but only one is accessible
  • [job] [logs] FTR Configs #18 / Controls Time Slider Control create, edit, and delete "after all" hook for "deletes an existing control"
  • [job] [logs] FTR Configs #18 / Controls Time Slider Control create, edit, and delete changes to time slice can be discarded
  • [job] [logs] FTR Configs #96 / dashboard app - group 1 create and add embeddables add new visualization link adds new visualization via the top nav link
  • [job] [logs] FTR Configs #95 / dashboard app - group 3 bwc shared urls 6.0 urls loads a saved dashboard with query via dashboard_no_match
  • [job] [logs] FTR Configs #87 / dashboard app - group 5 share dashboard snapshot share "after all" hook in "snapshot share"
  • [job] [logs] FTR Configs #87 / dashboard app - group 5 share dashboard snapshot share test local state should have "panels" in app state when a panel has been modified
  • [job] [logs] FTR Configs #75 / dashboard app - group 6 dashboard view edit mode existing dashboard opens in last used view mode
  • [job] [logs] FTR Configs #46 / dashboard dashboard maps by value adding a map by value can add a map by value
  • [job] [logs] FTR Configs #3 / Discover discover async search navigation to context cleans the session
  • [job] [logs] FTR Configs #41 / discover discover field visualize button should allow changing dimensions
  • [job] [logs] FTR Configs #30 / discover/embeddable discover saved search embeddable should replace a panel with a saved search
  • [job] [logs] FTR Configs #31 / discover/embeddable discover saved search embeddable should replace a panel with a saved search
  • [job] [logs] FTR Configs #52 / discover/embeddable discover saved search embeddable should replace a panel with a saved search
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group1 discover test resizable layout panels should allow resizing the sidebar layout panels
  • [job] [logs] FTR Configs #33 / discover/group1 discover test resizable layout panels should allow resizing the sidebar layout panels
  • [job] [logs] FTR Configs #39 / discover/group1 discover test resizable layout panels should allow resizing the sidebar layout panels
  • [job] [logs] FTR Configs #57 / discover/group1 discover test resizable layout panels should allow resizing the sidebar layout panels
  • [job] [logs] FTR Configs #27 / discover/group2 discover data grid doc table expand a document row should expand the detail row when the toggle arrow is clicked
  • [job] [logs] FTR Configs #76 / discover/group3 discover unsaved changes badge should not show the badge after pinning the first filter but after disabling a filter
  • [job] [logs] FTR Configs #29 / lens app - Agg based Vis Open in Lens Pie should convert terms to slice by
  • [job] [logs] FTR Configs #22 / lens app - group 1 lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #53 / lens app - group 1 lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #21 / lens app - group 2 lens query context Navigation search when opening from empty visualization to existing one preserves time range
  • [job] [logs] FTR Configs #91 / lens app - group 3 lens add-to-dashboards tests should allow new lens be added by value to an existing dashboard
  • [job] [logs] FTR Configs #34 / lens app - group 4 lens color palette tests should carry over palette to the pie chart
  • [job] [logs] FTR Configs #20 / lens app - group 5 lens drag and drop tests dropping between layers should move formula to empty dimension
  • [job] [logs] FTR Configs #9 / lens app - group 6 lens metric does carry custom formatting when transitioning from other visualization
  • [job] [logs] FTR Configs #36 / lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by value TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #8 / lens serverless - group 1 lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #13 / lens serverless - group 1 lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #43 / lens serverless - group 1 lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #77 / machine learning - anomaly detection anomaly explorer with farequote based multi metric job Anomaly Charts as embeddable "before each" hook for "attaches an embeddable to a case"
  • [job] [logs] FTR Configs #12 / machine learning - data visualizer data drift from data view creation mode from data view creation mode allows analyzing data drift without saving
  • [job] [logs] FTR Configs #42 / management scripted fields creating and using Painless string scripted fields should create scripted field
  • [job] [logs] FTR Configs #19 / maps app documents source search hits layer query should apply layer query to fit to bounds
  • [job] [logs] FTR Configs #38 / maps app geojson vector layer - es geo grid source geo_point geoprecision - requests should not rerequest when pan changes do not move map view area outside of buffer
  • [job] [logs] FTR Configs #68 / maps app tile_map visualization should render tile_map with map embeddable
  • [job] [logs] FTR Configs #2 / Monitoring app beats listing "before all" hook for "cluster status bar shows correct information"
  • [job] [logs] FTR Configs #54 / Options list control Allow expensive queries setting is off "after all" hook for "Can search options list for available options - does not find partial match"
  • [job] [logs] FTR Configs #54 / Options list control Allow expensive queries setting is off Can search options list for available options - exact match, case insensitive
  • [job] [logs] FTR Configs #64 / Sanity checks lens app lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #77 / Sanity checks lens app lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #80 / Sanity checks lens app lens smokescreen tests should transition from metric to table to metric
  • [job] [logs] FTR Configs #5 / Visualizations - Group 3 lens app - TSVB Open in Lens Metric should convert metric agg with params
  • [job] [logs] FTR Configs #7 / Visualizations - Group 3 lens app - TSVB Open in Lens Metric should convert metric agg with params
  • [job] [logs] FTR Configs #89 / Visualizations - Group 3 lens app - TSVB Open in Lens Metric should convert metric agg with params
  • [job] [logs] FTR Configs #73 / visualize app Add to Dashboard adding a existing metric to an existing dashboard by value
  • [job] [logs] FTR Configs #67 / visualize app visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting
  • [job] [logs] FTR Configs #75 / X-Pack Accessibility Tests - Group 2 Lens Accessibility change chart type via suggestions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +414.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich merged commit 0dd0664 into elastic:main Jan 24, 2024
@kibanamachine kibanamachine added v8.13.0 backport:skip This PR does not require backporting labels Jan 24, 2024
jloleysens added a commit that referenced this pull request Jan 25, 2024
* main: (520 commits)
  Update Kibana code editor dependencies (#171720)
  [SLOs] Hide view in app in slo alerts table in slo details page (#175441)
  [api-docs] 2024-01-25 Daily api_docs build (#175502)
  [DOCS] Add buildkite links to doc preview comments (#175463)
  skip flaky suite (#175443)
  [Security Solution][Timeline] refactor timeline modal save timeline button (#175343)
  [RAM] Stack Management::Rules loses user selections when navigating back (#174954)
  [Security Solution][Timeline] refactor timeline modal attach to case button (#175163)
  Upgrade EUI to v92.1.1 (#174955)
  [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634)
  [Cloud Security] Rules Combo Box filters Custom component (#175175)
  skip flaky suite (#175407)
  [Security Solution][Timeline] refactor timeline modal open timeline button (#175335)
  [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348)
  [Console] disable access to embedded console without dev tools capability (#175321)
  fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809)
  [Security Solution] Data quality dashboard persistence (#173185)
  [RAM][Observability] Add alert fields table to Observability flyout (#174685)
  test: add missing await for connector table disappearance (#175430)
  [RAM][Maintenance Window] Fix maintenance window FE types and transforms  (#173888)
  ...
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…er Fleet settings. (elastic#170634)

## What does this PR do?
* It fixes the consistency of displaying the "Beta" label in the proxies
under the Fleet Server settings page.
 
 ## Issue References
 * Closes elastic#168333
 
 ## Screenshot Demo
 ##### Before:

![image](https://github.com/GitStartHQ/client-kibana-oss/assets/50892465/f411779f-760b-4bc1-a6f1-17da5586ad53)

 ##### Fix:

![image](https://github.com/GitStartHQ/client-kibana-oss/assets/50892465/8dffe98c-fb39-48dd-badf-37be2dbdb863)

___
 
This code was written and reviewed by GitStart Community. Growing future
engineers, one PR at a time.

---------

Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings.

5 participants