Skip to content

fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Reporting plugin#174809

Merged
tsullivan merged 8 commits intoelastic:mainfrom
hainenber:use-fips-compliant-id-generator-libs-for-reporting-plugin
Jan 24, 2024
Merged

fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Reporting plugin#174809
tsullivan merged 8 commits intoelastic:mainfrom
hainenber:use-fips-compliant-id-generator-libs-for-reporting-plugin

Conversation

@hainenber
Copy link
Copy Markdown
Contributor

@hainenber hainenber commented Jan 13, 2024

Summary

Closes #174798

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

For maintainers

@hainenber hainenber requested a review from a team as a code owner January 13, 2024 08:25
@hainenber hainenber requested a review from a team as a code owner January 13, 2024 09:09
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Jan 17, 2024
@tsullivan
Copy link
Copy Markdown
Member

buildkite build this

@tsullivan tsullivan self-requested a review January 17, 2024 22:43
@tsullivan
Copy link
Copy Markdown
Member

buildkite build this

Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you so much for handling this!

@eokoneyo
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Copy Markdown
Contributor

buildkite build this

@eokoneyo eokoneyo added the zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Jan 24, 2024
@eokoneyo
Copy link
Copy Markdown
Contributor

@elasticmachine run elasticsearch-ci/docs

@eokoneyo
Copy link
Copy Markdown
Contributor

buildkite test this

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 715 713 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 445.1KB 450.4KB +5.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
reporting 4 3 -1

Total ESLint disabled count

id before after diff
reporting 4 3 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan added Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// and removed zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Jan 24, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Jan 24, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@tsullivan tsullivan assigned tsullivan and unassigned tsullivan Jan 24, 2024
@tsullivan tsullivan merged commit cd90773 into elastic:main Jan 24, 2024
@kibanamachine kibanamachine added v8.13.0 backport:skip This PR does not require backporting labels Jan 24, 2024
jloleysens added a commit that referenced this pull request Jan 25, 2024
* main: (520 commits)
  Update Kibana code editor dependencies (#171720)
  [SLOs] Hide view in app in slo alerts table in slo details page (#175441)
  [api-docs] 2024-01-25 Daily api_docs build (#175502)
  [DOCS] Add buildkite links to doc preview comments (#175463)
  skip flaky suite (#175443)
  [Security Solution][Timeline] refactor timeline modal save timeline button (#175343)
  [RAM] Stack Management::Rules loses user selections when navigating back (#174954)
  [Security Solution][Timeline] refactor timeline modal attach to case button (#175163)
  Upgrade EUI to v92.1.1 (#174955)
  [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634)
  [Cloud Security] Rules Combo Box filters Custom component (#175175)
  skip flaky suite (#175407)
  [Security Solution][Timeline] refactor timeline modal open timeline button (#175335)
  [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348)
  [Console] disable access to embedded console without dev tools capability (#175321)
  fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809)
  [Security Solution] Data quality dashboard persistence (#173185)
  [RAM][Observability] Add alert fields table to Observability flyout (#174685)
  test: add missing await for connector table disappearance (#175430)
  [RAM][Maintenance Window] Fix maintenance window FE types and transforms  (#173888)
  ...
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…porting plugin (elastic#174809)

## Summary
Closes elastic#174798 


### Checklist

Delete any items that are not applicable to this PR.



### Risk Matrix

Delete this section if it is not applicable to this PR.


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update library used to generate IDs in the Report constructor to be FIPS compliant

7 participants