Skip to content

[Security Solution][Timeline] refactor timeline modal attach to case button#175163

Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:timeline-cleanup-6
Jan 24, 2024
Merged

[Security Solution][Timeline] refactor timeline modal attach to case button#175163
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:timeline-cleanup-6

Conversation

@PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Jan 18, 2024

Summary

This PR is part of a set of 3-4 small PRs that aim at cleaning up the flyout folder under timeline. It focuses on refactoring and cleaning the add_to_case_button component, renamed to attah_to_case_button and moved to a new modal folder (timeline is not a flyout anymore).

The next PRs will concentrate on the other action components (new, open, save...)

No UI or behavior changes should be introduced by the PR!

Checklist

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.13.0 labels Jan 18, 2024
@PhilippeOberti PhilippeOberti marked this pull request as ready for review January 23, 2024 15:54
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner January 23, 2024 15:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti changed the title [Security Solution][Timeline] refactor flyout folder [Security Solution][Timeline] refactor timeline modal attach to case button Jan 23, 2024
Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense:)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.2MB 11.2MB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 19f01ae into elastic:main Jan 24, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jan 24, 2024
@PhilippeOberti PhilippeOberti deleted the timeline-cleanup-6 branch January 24, 2024 22:24
jloleysens added a commit that referenced this pull request Jan 25, 2024
* main: (520 commits)
  Update Kibana code editor dependencies (#171720)
  [SLOs] Hide view in app in slo alerts table in slo details page (#175441)
  [api-docs] 2024-01-25 Daily api_docs build (#175502)
  [DOCS] Add buildkite links to doc preview comments (#175463)
  skip flaky suite (#175443)
  [Security Solution][Timeline] refactor timeline modal save timeline button (#175343)
  [RAM] Stack Management::Rules loses user selections when navigating back (#174954)
  [Security Solution][Timeline] refactor timeline modal attach to case button (#175163)
  Upgrade EUI to v92.1.1 (#174955)
  [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634)
  [Cloud Security] Rules Combo Box filters Custom component (#175175)
  skip flaky suite (#175407)
  [Security Solution][Timeline] refactor timeline modal open timeline button (#175335)
  [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348)
  [Console] disable access to embedded console without dev tools capability (#175321)
  fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809)
  [Security Solution] Data quality dashboard persistence (#173185)
  [RAM][Observability] Add alert fields table to Observability flyout (#174685)
  test: add missing await for connector table disappearance (#175430)
  [RAM][Maintenance Window] Fix maintenance window FE types and transforms  (#173888)
  ...
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants