[RAM][Observability] Add alert fields table to Observability flyout by umbopepato · Pull Request #174685 · elastic/kibana

umbopepato · 2024-01-11T13:38:56Z

Summary

Adds the alert fields table from #172830 to Observability alert flyouts (triggered by the View alert details action).

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2024-01-11T13:38:58Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-01-11T13:39:02Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

…elds-table-o11y

maryam-saeidi

Tested locally and worked as expected 💯 Just added some clarifying questions.

Btw, in smaller screen, we don't have enough space for the field name but I am not sure how having a wider width for the first column will impact bigger screens:

I've tested this logic in:

Rule details page
Hosts page
APM service page

maryam-saeidi · 2024-01-23T13:58:51Z

x-pack/plugins/observability/public/components/alerts_flyout/alerts_flyout.tsx

@@ -41,16 +44,16 @@ export function AlertsFlyout({
  if (!alertData) {
    alertData = decoratedAlerts?.find((a) => a.fields[ALERT_UUID] === selectedAlertId) as TopAlert;


Not related to this PR but this logic seems to be related to the parent component instead of here, it is a bit confusing why we have are passing both alerts and alert to this component. 🤔

I too noticed this, it seems like the intention was to support both retrieving the alert form the list fetched by the table and receive a single one too even though the first option seems unused as of now

x-pack/plugins/observability/public/pages/cases/components/cases.tsx

maryam-saeidi · 2024-01-23T15:57:47Z

x-pack/plugins/observability/public/hooks/use_fetch_alert_detail.ts

 }

-export const useFetchAlertDetail = (id: string): [boolean, TopAlert | null] => {
+export interface AlertDetail {


nit:

Suggested change

export interface AlertDetail {

export interface AlertData { // Or maybe AlertInstance

formatted: TopAlert;

raw: EcsFieldsResponse;

}

Much better! 👍

…elds-table-o11y

maryam-saeidi

LGTM, thanks for the improvement ❤️

…elds-table-o11y

kibana-ci · 2024-01-24T17:10:21Z

💚 Build Succeeded

Buildkite Build
Commit: 08ffa7c

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/alerts-ui-shared`	92	90	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	634.5KB	638.5KB	+4.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	106.2KB	106.3KB	+80.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/alerts-ui-shared`	94	95	+1

History

💔 Build #188981 failed 18499cfceae0c606bb13e5b7af559a9018220f07
💔 Build #188932 failed 4bf1b6a
💛 Build #188834 was flaky 2d6c2e6
💛 Build #188463 was flaky e6e28f3
💔 Build #188449 failed 8a44f1483b3230eda1ee52924dd08c1a3d3ec862

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* main: (520 commits) Update Kibana code editor dependencies (#171720) [SLOs] Hide view in app in slo alerts table in slo details page (#175441) [api-docs] 2024-01-25 Daily api_docs build (#175502) [DOCS] Add buildkite links to doc preview comments (#175463) skip flaky suite (#175443) [Security Solution][Timeline] refactor timeline modal save timeline button (#175343) [RAM] Stack Management::Rules loses user selections when navigating back (#174954) [Security Solution][Timeline] refactor timeline modal attach to case button (#175163) Upgrade EUI to v92.1.1 (#174955) [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634) [Cloud Security] Rules Combo Box filters Custom component (#175175) skip flaky suite (#175407) [Security Solution][Timeline] refactor timeline modal open timeline button (#175335) [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348) [Console] disable access to embedded console without dev tools capability (#175321) fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809) [Security Solution] Data quality dashboard persistence (#173185) [RAM][Observability] Add alert fields table to Observability flyout (#174685) test: add missing await for connector table disappearance (#175430) [RAM][Maintenance Window] Fix maintenance window FE types and transforms (#173888) ...

…lastic#174685) ## Summary Adds the alert fields table from elastic#172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>

Add alert fields table to Observability flyout

fa9782e

umbopepato added release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.13.0 labels Jan 11, 2024

umbopepato requested a review from a team as a code owner January 11, 2024 13:38

botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jan 11, 2024

umbopepato added 5 commits January 15, 2024 17:09

Fix alert object type in o11y cases standalone flyout

4dd2e0b

Merge branch 'main' of github.com:elastic/kibana into 174517-alert-fi…

b9f925f

…elds-table-o11y

Fix failing o11y alert detail page test

c46ea98

Merge branch 'main' of github.com:elastic/kibana into 174517-alert-fi…

d837410

…elds-table-o11y

Fix failing o11y alert flyout tests

2c00a16

umbopepato requested a review from a team as a code owner January 18, 2024 13:36

umbopepato force-pushed the 174517-alert-fields-table-o11y branch from 640e946 to 4d18719 Compare January 22, 2024 10:09

Add fields filering option to alert fields table

2f3a7e4

umbopepato force-pushed the 174517-alert-fields-table-o11y branch from 993896f to 8a44f14 Compare January 22, 2024 11:20

Merge branch 'main' of github.com:elastic/kibana into 174517-alert-fi…

e6e28f3

…elds-table-o11y

umbopepato force-pushed the 174517-alert-fields-table-o11y branch from 8a44f14 to e6e28f3 Compare January 22, 2024 12:38

maryam-saeidi self-requested a review January 23, 2024 14:04

maryam-saeidi reviewed Jan 23, 2024

View reviewed changes

XavierM approved these changes Jan 23, 2024

View reviewed changes

XavierM and others added 3 commits January 23, 2024 15:49

Merge branch 'main' into 174517-alert-fields-table-o11y

2d6c2e6

Improve o11y alert fields table

e3ebe9b

Merge branch 'main' of github.com:elastic/kibana into 174517-alert-fi…

4bf1b6a

…elds-table-o11y

maryam-saeidi approved these changes Jan 24, 2024

View reviewed changes

umbopepato added 2 commits January 24, 2024 16:56

Fix failing o11y alert flyout tests

c29b268

Merge branch 'main' of github.com:elastic/kibana into 174517-alert-fi…

08ffa7c

…elds-table-o11y

umbopepato force-pushed the 174517-alert-fields-table-o11y branch from 18499cf to 08ffa7c Compare January 24, 2024 15:57

umbopepato merged commit 256d12e into elastic:main Jan 24, 2024

kibanamachine added the backport:skip This PR does not require backporting label Jan 24, 2024

This was referenced Jan 25, 2024

[Alert details page] Error loading alert details page #175525

Closed

[Burn rate alert details page] Charts are not loading #175648

Closed

benakansara mentioned this pull request Jan 30, 2024

[Alert details page] [Log] [APM] Error loading alert details pages #175922

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM][Observability] Add alert fields table to Observability flyout#174685

[RAM][Observability] Add alert fields table to Observability flyout#174685
umbopepato merged 13 commits intoelastic:mainfrom
umbopepato:174517-alert-fields-table-o11y

umbopepato commented Jan 11, 2024 •

edited

Loading

Uh oh!

elasticmachine commented Jan 11, 2024

Uh oh!

elasticmachine commented Jan 11, 2024

Uh oh!

maryam-saeidi left a comment •

edited

Loading

Uh oh!

maryam-saeidi Jan 23, 2024

Uh oh!

umbopepato Jan 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

maryam-saeidi Jan 23, 2024

Uh oh!

umbopepato Jan 24, 2024

Uh oh!

maryam-saeidi left a comment

Uh oh!

kibana-ci commented Jan 24, 2024

API count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -41,16 +44,16 @@ export function AlertsFlyout({
		if (!alertData) {
		alertData = decoratedAlerts?.find((a) => a.fields[ALERT_UUID] === selectedAlertId) as TopAlert;

-export interface AlertDetail {
+export interface AlertData { // Or maybe AlertInstance
+  formatted: TopAlert;
+  raw: EcsFieldsResponse;
+}

Conversation

umbopepato commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jan 11, 2024

Uh oh!

elasticmachine commented Jan 11, 2024

Uh oh!

maryam-saeidi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maryam-saeidi Jan 23, 2024

Choose a reason for hiding this comment

Uh oh!

umbopepato Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maryam-saeidi Jan 23, 2024

Choose a reason for hiding this comment

Uh oh!

umbopepato Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

maryam-saeidi left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jan 24, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

umbopepato commented Jan 11, 2024 •

edited

Loading

maryam-saeidi left a comment •

edited

Loading

umbopepato Jan 24, 2024 •

edited

Loading