Skip to content

[Ops] More resilient test failure collection#175423

Closed
delanni wants to merge 2 commits intoelastic:mainfrom
delanni:increase-resiliency-in-failure-report
Closed

[Ops] More resilient test failure collection#175423
delanni wants to merge 2 commits intoelastic:mainfrom
delanni:increase-resiliency-in-failure-report

Conversation

@delanni
Copy link
Copy Markdown
Contributor

@delanni delanni commented Jan 24, 2024

Summary

See: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3ab8-240d-44b2-975a-9cbfa09d3177

If I interpret the results right, some FTR runs fail on the JUnit result collection step, thus not allowing any further steps to run from the post-command actions, this prevents the annotation and screenshot uploading from happening.

This PR adds a more resilient execution of post-command actions, collecting the resulting exit code from several steps before exiting.

@delanni delanni added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jan 24, 2024
@delanni
Copy link
Copy Markdown
Contributor Author

delanni commented Jan 24, 2024

/ci

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni marked this pull request as ready for review January 24, 2024 16:04
@delanni delanni requested a review from a team as a code owner January 24, 2024 16:04
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Copy Markdown
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to trying it, but are we sure the junit reports are created? It seems we're terminating early due to a few missing awaits causing unhandled promises at

pageObjects.svlSearchConnectorsPage.connectorOverviewPage.getConnectorFromConnectorTable(

@delanni
Copy link
Copy Markdown
Contributor Author

delanni commented Jan 25, 2024

You're probably right, the reports are not created at that state. My attempt with this PR was to still add the error annotation, and upload any other artifacts that might have been created during the test runs, but now I see that the tagging logic needs the JUnit/Html reports to produce the annotation from. I'll not merge this, I don't want to mess with the error codes at this point, not to prevent any retries or similar.

I think that error was coming from a leakage that I tried to fix here: #175430

@delanni delanni closed this Jan 25, 2024
@delanni delanni deleted the increase-resiliency-in-failure-report branch November 11, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants