[RAM] Add fields table to rule details page alert flyout by umbopepato · Pull Request #172830 · elastic/kibana

umbopepato · 2023-12-07T14:50:47Z

Summary

Adds a table visualization of alert fields to the rule details page alert flyout.

elasticmachine · 2023-12-08T10:04:02Z

Pinging @elastic/response-ops (Team:ResponseOps)

umbopepato · 2023-12-11T08:09:44Z

/ci

…lerts-table-flyout

…pato/kibana into improve-stack-alerts-table-flyout

…lerts-table-flyout

…fix'

…pato/kibana into improve-stack-alerts-table-flyout

…lerts-table-flyout

…pato/kibana into improve-stack-alerts-table-flyout

XavierM · 2023-12-19T20:53:55Z

packages/kbn-alerts-ui-shared/src/alert_fields_table/index.tsx

+    <EuiInMemoryTable
+      items={Object.entries(alert).map(([key, value]) => ({ key, value: value?.[0] }))}
+      itemId="key"
+      columns={[


we can create a const for the columns prop

XavierM · 2023-12-19T20:54:39Z

packages/kbn-alerts-ui-shared/src/alert_fields_table/index.tsx

@@ -0,0 +1,105 @@
+/*


can we have some basic unit test to test for the search and pagination?

XavierM · 2023-12-19T21:23:26Z

..._actions_ui/public/application/sections/alerts_table/alerts_flyout/default_alerts_flyout.tsx

-import { get } from 'lodash';
-import React from 'react';
-import { type EuiDataGridColumn, EuiDescriptionList, EuiPanel, EuiTitle } from '@elastic/eui';
+import React, { useCallback, useMemo, useState } from 'react';


can we add basic test for tabs?

…lerts-table-flyout

XavierM

Awesome, to have this done!

kibana-ci · 2024-01-08T11:13:19Z

💚 Build Succeeded

Buildkite Build
Commit: 21b8d03

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`alerting`	151	153	+2
`observability`	580	581	+1
`securitySolution`	4861	4862	+1
`triggersActionsUi`	657	658	+1
total			+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/alerting-types`	29	33	+4
`@kbn/alerts-ui-shared`	82	92	+10
total			+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alerting`	88.7KB	89.0KB	+310.0B
`observability`	600.4KB	600.7KB	+304.0B
`securitySolution`	11.4MB	11.4MB	+298.0B
`triggersActionsUi`	1.4MB	1.4MB	+900.0B
total			+1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.9KB	106.2KB	+1.3KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/alerting-types`	29	33	+4
`@kbn/alerts-ui-shared`	83	94	+11
total			+15

History

💚 Build #184961 succeeded 8359e4e
💛 Build #184930 was flaky 2af979d
💛 Build #184250 was flaky 51b86d2
💔 Build #184241 failed c8ac956
💔 Build #184214 failed fb59d79
💔 Build #184009 failed cec803439fb3953a91bf65dd674a1725003a1ef1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-01-08T15:56:37Z

💔 All backports failed

Status	Branch	Result
❌	8.12	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 172830

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-01-09T21:49:12Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172830 locally

) ## Summary Adds a table visualization of alert fields to the rule details page alert flyout. <img width="1504" alt="image" src="https://github.com/elastic/kibana/assets/18363145/50dae2f9-ad34-4563-8388-2777ecc1ca15"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>

kibanamachine · 2024-01-11T21:48:39Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172830 locally

kibanamachine · 2024-01-12T21:48:54Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172830 locally

…174685) ## Summary Adds the alert fields table from #172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>

…lastic#174685) ## Summary Adds the alert fields table from elastic#172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>

Add fields table to stack alerts flyout

643d523

umbopepato force-pushed the improve-stack-alerts-table-flyout branch from 8a8cf27 to 643d523 Compare December 8, 2023 09:51

umbopepato added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// release_note:feature Makes this part of the condensed release notes v8.13.0 v8.12.1 and removed v8.13.0 labels Dec 8, 2023

umbopepato marked this pull request as ready for review December 8, 2023 10:03

umbopepato requested a review from a team as a code owner December 8, 2023 10:03

umbopepato added v8.12.0 and removed v8.12.1 labels Dec 8, 2023

Merge branch 'main' into improve-stack-alerts-table-flyout

fca23b5

umbopepato added 6 commits December 11, 2023 09:45

Merge branch 'main' of github.com:elastic/kibana into improve-stack-a…

3e90553

…lerts-table-flyout

Simplify stack alert flyout tabs styling

59a1a56

Merge branch 'improve-stack-alerts-table-flyout' of github.com:umbope…

8765e46

…pato/kibana into improve-stack-alerts-table-flyout

Merge branch 'main' of github.com:elastic/kibana into improve-stack-a…

37b06ad

…lerts-table-flyout

Move alert fields table to alerts-ui-shared package

b5e6277

Remove circular dependency

e59fa58

umbopepato force-pushed the improve-stack-alerts-table-flyout branch from cec8034 to e59fa58 Compare December 19, 2023 11:28

kibanamachine and others added 6 commits December 19, 2023 11:34

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

fb59d79

…fix'

Fix wrong translation namespaces after move to package

5fc4de1

Merge branch 'improve-stack-alerts-table-flyout' of github.com:umbope…

ada8f90

…pato/kibana into improve-stack-alerts-table-flyout

Merge branch 'main' of github.com:elastic/kibana into improve-stack-a…

c8ac956

…lerts-table-flyout

Fix wrong translation namespaces after move to package

ccaa178

Merge branch 'improve-stack-alerts-table-flyout' of github.com:umbope…

51b86d2

…pato/kibana into improve-stack-alerts-table-flyout

XavierM reviewed Dec 19, 2023

View reviewed changes

umbopepato added 2 commits December 22, 2023 14:05

Add alert fields table tests

46191cb

Merge branch 'main' of github.com:elastic/kibana into improve-stack-a…

2af979d

…lerts-table-flyout

umbopepato force-pushed the improve-stack-alerts-table-flyout branch from e46c973 to 2af979d Compare December 22, 2023 13:05

XavierM approved these changes Dec 22, 2023

View reviewed changes

XavierM and others added 2 commits December 22, 2023 10:51

Merge branch 'main' into improve-stack-alerts-table-flyout

8359e4e

Merge branch 'main' into improve-stack-alerts-table-flyout

21b8d03

umbopepato merged commit 926039f into elastic:main Jan 8, 2024

kibanamachine added the v8.13.0 label Jan 8, 2024

umbopepato mentioned this pull request Jan 9, 2024

[RAM][Observability] Enable fields table in o11y alert flyout #174517

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 9, 2024

umbopepato mentioned this pull request Jan 11, 2024

[RAM][Observability] Add alert fields table to Observability flyout #174685

Merged

2 tasks

umbopepato removed the v8.12.0 label Jan 17, 2024

kibanamachine added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] Add fields table to rule details page alert flyout#172830

[RAM] Add fields table to rule details page alert flyout#172830
umbopepato merged 18 commits intoelastic:mainfrom
umbopepato:improve-stack-alerts-table-flyout

umbopepato commented Dec 7, 2023 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Dec 8, 2023

Uh oh!

umbopepato commented Dec 11, 2023

Uh oh!

XavierM Dec 19, 2023

Uh oh!

XavierM Dec 19, 2023 •

edited

Loading

Uh oh!

XavierM Dec 19, 2023

Uh oh!

XavierM left a comment

Uh oh!

kibana-ci commented Jan 8, 2024

API count

Uh oh!

kibanamachine commented Jan 8, 2024

Uh oh!

kibanamachine commented Jan 9, 2024

Uh oh!

kibanamachine commented Jan 11, 2024

Uh oh!

kibanamachine commented Jan 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

umbopepato commented Dec 7, 2023 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Dec 8, 2023

Uh oh!

umbopepato commented Dec 11, 2023

Uh oh!

XavierM Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

XavierM Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XavierM Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jan 8, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

kibanamachine commented Jan 8, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jan 9, 2024

Uh oh!

kibanamachine commented Jan 11, 2024

Uh oh!

kibanamachine commented Jan 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

umbopepato commented Dec 7, 2023 •

edited by kibanamachine

Loading

XavierM Dec 19, 2023 •

edited

Loading