[RAM] Change truncated 'run action every' to visible 'run every'#156753
Merged
Zacqary merged 1 commit intoelastic:mainfrom May 22, 2023
Merged
[RAM] Change truncated 'run action every' to visible 'run every'#156753Zacqary merged 1 commit intoelastic:mainfrom
Zacqary merged 1 commit intoelastic:mainfrom
Conversation
Zacqary
added
release_note:fix
Feature:Alerting/RulesManagement
Zacqary
added
the
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
jcger
approved these changes
May 5, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 22, 2023
…stic#156753) ## Summary elastic#155804 introduced this bug: <img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM" src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png"> After: <img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM" src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png"> (cherry picked from commit 8a9fb98)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 22, 2023
#156753) (#158206) # Backport This will backport the following commits from `main` to `8.8`: - [[RAM] Change truncated 'run action every' to visible 'run every' (#156753)](#156753) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Zacqary Adam Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-22T16:29:02Z","message":"[RAM] Change truncated 'run action every' to visible 'run every' (#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.9.0","v8.8.1"],"number":156753,"url":"https://github.com/elastic/kibana/pull/156753","mergeCommit":{"message":"[RAM] Change truncated 'run action every' to visible 'run every' (#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156753","number":156753,"mergeCommit":{"message":"[RAM] Change truncated 'run action every' to visible 'run every' (#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
![https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img](https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img){kind=link}
![https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.9.0","v8.8.1"],"number":156753,"url":"https://github.com/elastic/kibana/pull/156753","mergeCommit":{"message":"[RAM]](https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.9.0","v8.8.1"],"number":156753,"url":"https://github.com/elastic/kibana/pull/156753","mergeCommit":{"message":"[RAM]){kind=link}
![https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156753","number":156753,"mergeCommit":{"message":"[RAM]](https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156753","number":156753,"mergeCommit":{"message":"[RAM]){kind=link}
![https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED](https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED){kind=link}
…stic#156753) ## Summary elastic#155804 introduced this bug: <img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM" src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png"> After: <img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM" src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#155804 introduced this bug:
After: