Skip to content

Fix flaky combobox tests on role management screen #155711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomheymann merged 1 commit into from
Apr 26, 2023
Merged

Fix flaky combobox tests on role management screen #155711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/security/doc_level_security_roles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['security', 'common', 'header', 'discover', 'settings']);
const kibanaServer = getService('kibanaServer');

// Failing: See https://github.com/elastic/kibana/issues/155447
describe.skip('dls', function () {
describe('dls', function () {
before('initialize tests', async () => {
await kibanaServer.savedObjects.cleanStandardList();
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/security/dlstest');
Expand Down
27 changes: 15 additions & 12 deletions x-pack/test/functional/page_objects/security_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import { adminTestUser } from '@kbn/test';
import { AuthenticatedUser, Role } from '@kbn/security-plugin/common/model';
import type { UserFormValues } from '@kbn/security-plugin/public/management/users/edit_user/user_form';
import { Key } from 'selenium-webdriver';
import { FtrService } from '../ftr_provider_context';

interface LoginOptions {
Expand Down Expand Up @@ -359,14 +360,12 @@ export class SecurityPageObject extends FtrService {
}

async addPrivilegeToRole(privilege: string) {
this.log.debug(`Adding privilege ${privilege} to role`);
const privilegeInput = await this.retry.try(() =>
this.find.byCssSelector('[data-test-subj="privilegesInput0"] input')
);
await privilegeInput.type(privilege);

const btn = await this.find.byButtonText(privilege);
await btn.click();
this.log.debug(`Adding privilege "${privilege}" to role`);
const privilegesField = await this.testSubjects.find('privilegesInput0');
const privilegesInput = await privilegesField.findByTagName('input');
await privilegesInput.type(privilege);
await privilegesInput.pressKeys(Key.ENTER); // Add typed privilege to combo box
await privilegesInput.pressKeys(Key.ESCAPE); // Close dropdown menu to avoid hiding elements from test runner
}

async assignRoleToUser(role: string) {
Expand Down Expand Up @@ -586,23 +585,27 @@ export class SecurityPageObject extends FtrService {
}

await this.testSubjects.click('addSpacePrivilegeButton');
await this.testSubjects.click('spaceSelectorComboBox');
const spaceSelectorComboBox = await this.testSubjects.find('spaceSelectorComboBox');
await spaceSelectorComboBox.click();

const globalSpaceOption = await this.find.byCssSelector(`#spaceOption_\\*`);
await globalSpaceOption.click();

// Close dropdown menu to avoid hiding elements from test runner
const spaceSelectorInput = await spaceSelectorComboBox.findByTagName('input');
await spaceSelectorInput.pressKeys(Key.ESCAPE);

await this.testSubjects.click('basePrivilege_all');
await this.testSubjects.click('createSpacePrivilegeButton');

const addPrivilege = (privileges: string[]) => {
const addPrivileges = (privileges: string[]) => {
return privileges.reduce((promise: Promise<any>, privilegeName: string) => {
return promise
.then(() => self.addPrivilegeToRole(privilegeName))
.then(() => this.common.sleep(250));
}, Promise.resolve());
};

await addPrivilege(roleObj.elasticsearch.indices[0].privileges);
await addPrivileges(roleObj.elasticsearch.indices[0].privileges);

const addGrantedField = async (fields: string[]) => {
for (const entry of fields) {
Expand Down