[Lens] Close settings popover on click#141272
Merged
flash1293 merged 1 commit intoelastic:mainfrom Sep 22, 2022
Merged
Conversation
flash1293
added
release_note:fix
Team:Visualizations
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
reviewed
Sep 22, 2022
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
I cannot reproduce the bug on master with the steps provided in the issue:
- turn off auto apply with an empty chart
- Drag in a field
- Open the settings popover
- turn on auto apply
- Chart renders, top nav updates, top nav crashes
Could you provide a short video where it happens? Maybe I am missing something.
mbondyra
approved these changes
Sep 22, 2022
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
Reproduced after syncing with Joe and dragging the @timestamp field from Logs instead. The bug is fixed 👌🏼
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
alexwizp
added a commit
that referenced
this pull request
Aug 27, 2025
…nnouncement for switch button (#232983) Closes: #215327 **Description** When activating an element, users should receive a clear state-change announcement so they understand it has been successfully activated. **Changes Made** For accessibility reasons, the modal dialog is no longer closed automatically after the "Auto-apply visualization changes" action. - This effectively reverts the changes introduced in #141272. **Notes for Reviewers** - I tested the scenario mentioned in [this comment](#141203 (comment)). - The behavior described there is no longer relevant, so we don’t need to preserve that workaround. **Screen** https://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 27, 2025
…nnouncement for switch button (elastic#232983) Closes: elastic#215327 **Description** When activating an element, users should receive a clear state-change announcement so they understand it has been successfully activated. **Changes Made** For accessibility reasons, the modal dialog is no longer closed automatically after the "Auto-apply visualization changes" action. - This effectively reverts the changes introduced in elastic#141272. **Notes for Reviewers** - I tested the scenario mentioned in [this comment](elastic#141203 (comment)). - The behavior described there is no longer relevant, so we don’t need to preserve that workaround. **Screen** https://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d (cherry picked from commit c329b83)
kibanamachine
added a commit
that referenced
this pull request
Aug 27, 2025
…ange announcement for switch button (#232983) (#233148) # Backport This will backport the following commits from `main` to `9.1`: - [fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983)](#232983) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-27T15:49:13Z","message":"fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983)\n\nCloses: #215327\n\n**Description**\nWhen activating an element, users should receive a clear state-change\nannouncement so they understand it has been successfully activated.\n\n**Changes Made**\nFor accessibility reasons, the modal dialog is no longer closed\nautomatically after the \"Auto-apply visualization changes\" action.\n - This effectively reverts the changes introduced in #141272.\n\n**Notes for Reviewers**\n- I tested the scenario mentioned in [this\ncomment](https://github.com/elastic/kibana/issues/141203#issuecomment-1253509012).\n- The behavior described there is no longer relevant, so we don’t need\nto preserve that workaround.\n\n**Screen**\n\n\nhttps://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d","sha":"c329b83d75b5a9acab2924705b00e7a8e99381e9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button","number":232983,"url":"https://github.com/elastic/kibana/pull/232983","mergeCommit":{"message":"fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983)\n\nCloses: #215327\n\n**Description**\nWhen activating an element, users should receive a clear state-change\nannouncement so they understand it has been successfully activated.\n\n**Changes Made**\nFor accessibility reasons, the modal dialog is no longer closed\nautomatically after the \"Auto-apply visualization changes\" action.\n - This effectively reverts the changes introduced in #141272.\n\n**Notes for Reviewers**\n- I tested the scenario mentioned in [this\ncomment](https://github.com/elastic/kibana/issues/141203#issuecomment-1253509012).\n- The behavior described there is no longer relevant, so we don’t need\nto preserve that workaround.\n\n**Screen**\n\n\nhttps://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d","sha":"c329b83d75b5a9acab2924705b00e7a8e99381e9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232983","number":232983,"mergeCommit":{"message":"fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983)\n\nCloses: #215327\n\n**Description**\nWhen activating an element, users should receive a clear state-change\nannouncement so they understand it has been successfully activated.\n\n**Changes Made**\nFor accessibility reasons, the modal dialog is no longer closed\nautomatically after the \"Auto-apply visualization changes\" action.\n - This effectively reverts the changes introduced in #141272.\n\n**Notes for Reviewers**\n- I tested the scenario mentioned in [this\ncomment](https://github.com/elastic/kibana/issues/141203#issuecomment-1253509012).\n- The behavior described there is no longer relevant, so we don’t need\nto preserve that workaround.\n\n**Screen**\n\n\nhttps://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d","sha":"c329b83d75b5a9acab2924705b00e7a8e99381e9"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Aug 30, 2025
…nnouncement for switch button (elastic#232983) Closes: elastic#215327 **Description** When activating an element, users should receive a clear state-change announcement so they understand it has been successfully activated. **Changes Made** For accessibility reasons, the modal dialog is no longer closed automatically after the "Auto-apply visualization changes" action. - This effectively reverts the changes introduced in elastic#141272. **Notes for Reviewers** - I tested the scenario mentioned in [this comment](elastic#141203 (comment)). - The behavior described there is no longer relevant, so we don’t need to preserve that workaround. **Screen** https://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Sep 2, 2025
…nnouncement for switch button (elastic#232983) Closes: elastic#215327 **Description** When activating an element, users should receive a clear state-change announcement so they understand it has been successfully activated. **Changes Made** For accessibility reasons, the modal dialog is no longer closed automatically after the "Auto-apply visualization changes" action. - This effectively reverts the changes introduced in elastic#141272. **Notes for Reviewers** - I tested the scenario mentioned in [this comment](elastic#141203 (comment)). - The behavior described there is no longer relevant, so we don’t need to preserve that workaround. **Screen** https://github.com/user-attachments/assets/69eef4ed-2426-449e-a872-8ed38f89303d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141203 by employing the workaround I mentioned in the issue.
I will create a feature request for the app services team to provide a proper way to do this separately.