Skip to content

[Response Ops][Alerting] Defining default action params on connector type#141226

Merged
ymao1 merged 4 commits intoelastic:mainfrom
ymao1:alerting/default-action-params
Sep 22, 2022
Merged

[Response Ops][Alerting] Defining default action params on connector type#141226
ymao1 merged 4 commits intoelastic:mainfrom
ymao1:alerting/default-action-params

Conversation

@ymao1
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 commented Sep 21, 2022 •
edited
Loading

Towards #90931

Summary

Decoupling default action parameters so that we can move the connector types UI code to the stack_connectors plugin. Currently Pagerduty and XMatters connectors define some default action parameters that are auto-populated for users when they add actions to their rules. These definitions were stored in a separate file and the way they were passed to the ActionTypeForm component made it difficult to untangle the connector code from the triggers_actions_ui framework code. This PR moves those definitions to the connector type definition.

To Verify

  1. Create a Pagerduty connector
  2. Create a rule and add a Pagerduty action. See that the dedupeKey and event action on the action form are auto-populated. Switch the action group to Recovered and see that the event action auto-changes from Trigger to Resolve
  3. Create an Xmatters connector
  4. Create a rule and add an Xmatters action. Save the rule and then inspect the rule saved object. See that the Xmatters action is auto-populated with parameters.

@ymao1 ymao1 changed the title Defining default action params on connector type [Response Ops][Alerting] Defining default action params on connector type Sep 21, 2022
@ymao1 ymao1 self-assigned this Sep 21, 2022
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Sep 21, 2022
@ymao1 ymao1 marked this pull request as ready for review September 21, 2022 13:39
@ymao1 ymao1 requested a review from a team as a code owner September 21, 2022 13:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 21, 2022

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 added the v8.6.0 label Sep 21, 2022
ersin-erdal
ersin-erdal approved these changes Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Sep 22, 2022

@elasticmachine merge upstream

doakalexi
doakalexi approved these changes Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Sep 22, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 22, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 620 619 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.1MB 1.1MB -10.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 93.6KB 98.9KB +5.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit ebb8455 into elastic:main Sep 22, 2022
@ymao1 ymao1 deleted the alerting/default-action-params branch September 22, 2022 13:59
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 22, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 22, 2022
@jloleysens
Merge branch 'main' into files-upload-use-self-destruct-flag
f178af8 
* main: (33 commits)
  Fix Next and Previous button on step screenshot carousel. (elastic#141422)
  [journeys] add a short delay after loading data (elastic#141437)
  skip failing test suite (elastic#140797)
  skip failing test suite (elastic#138776)
  Documents saved objects bulk delete API (elastic#141164)
  [Response Ops][Alerting] Defining default action params on connector type (elastic#141226)
  [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213)
  [APM] Fix search bar suggestions (elastic#141101)
  close popover on click (elastic#141272)
  [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276)
  [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239)
  [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228)
  [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288)
  Shameless copy of the retryTransientEsErrors from fleet (elastic#141246)
  [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735)
  Changing triggers actions ui routes to internal (elastic#141149)
  skip flaky test suit elastic#141356
  [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043)
  [dashboard controls] skip failing test on cloud (elastic#141291)
  [Synthetics] unskip edit_monitor api integration tests (elastic#141277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

@doakalexi doakalexi doakalexi approved these changes

Assignees

@ymao1 ymao1

Labels

backport:skip This PR does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.6.0

Projects

No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ymao1 @elasticmachine @kibana-ci @ersin-erdal @doakalexi @kibanamachine