[SharedUX] Removing TODOs from KibanaPageTemplate#141043
Merged
majagrubic merged 12 commits intoelastic:mainfrom Sep 22, 2022
Merged
[SharedUX] Removing TODOs from KibanaPageTemplate#141043majagrubic merged 12 commits intoelastic:mainfrom
majagrubic merged 12 commits intoelastic:mainfrom
Conversation
added 8 commits
September 19, 2022 16:12
… into eui-pagetemplate
majagrubic
added
release_note:skip
added 2 commits
September 20, 2022 21:05
rshen91
approved these changes
Sep 21, 2022
Contributor
rshen91
left a comment
rshen91
left a comment
There was a problem hiding this comment.
These changes look great to me - tested locally
|
|
||
| export const WithSolutionNavStyles = (euiTheme: EuiThemeComputed<{}>) => { | ||
| return css` | ||
| flex: 0 1 0%; |
clintandrewhall
approved these changes
Sep 22, 2022
Contributor
clintandrewhall
left a comment
clintandrewhall
left a comment
There was a problem hiding this comment.
Thanks for doing this!
packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx
Outdated
Show resolved
Hide resolved
packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,20 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
I need to remember to do this. I always forget...!
| import { css } from '@emotion/react'; | ||
| import { euiCanAnimate, EuiThemeComputed } from '@elastic/eui'; | ||
|
|
||
| export const WithSolutionNavStyles = (euiTheme: EuiThemeComputed<{}>) => { |
Contributor
There was a problem hiding this comment.
nit: I don't think this should start with a capital... it's not a React component, or a class.
Contributor
Author
There was a problem hiding this comment.
It is the convention we had used so far, eg:
https://github.com/elastic/kibana/blob/main/packages/shared-ux/button_toolbar/src/buttons/icon_button_group/icon_button_group.styles.ts#L11
Contributor
Author
There was a problem hiding this comment.
Happy to change it, but would prefer if we stayed consistent
Contributor
Author
There was a problem hiding this comment.
I will merge this now, but lmk if you think it needs to be changed.
…_inner.tsx Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #140118
This PR addresses some of the TODOs that were left in the code when migrating from
kibana_reactto ashared-uxpackage. Some changes:with_solution_navscss file and rewriting code in emotionkibanaChromeinpage_template_innerChecklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listFor maintainers