chore(slo): Shameless copy of the retryTransientEsErrors from fleet#141246
Merged
kdelemme merged 1 commit intoelastic:mainfrom Sep 22, 2022
Merged
chore(slo): Shameless copy of the retryTransientEsErrors from fleet#141246kdelemme merged 1 commit intoelastic:mainfrom
kdelemme merged 1 commit intoelastic:mainfrom
Conversation
kdelemme
added
release_note:skip
Contributor
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @kdelemme |
maryam-saeidi
approved these changes
Sep 22, 2022
Member
maryam-saeidi
left a comment
maryam-saeidi
left a comment
There was a problem hiding this comment.
Copying was done perfectly 😄 (I just check the code, not sure if I need to test something locally)
Did you face an issue that you find this solution for it or is it a preventative measure?
Contributor
Author
No I haven't got any issue like this, but I agreed with @fkanout when he suggested to add this. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Resolves #141082
Copied 🙈 the transient error retry service from Fleet to our plugin, and integrate it into our transform manager service.
💬 I've added only one retry test scenario using the transform service because each test takes 1s, and the retry service is already tested thoroughly.