Skip to content

[Response Ops] [Alerting] Change triggers_actions_ui routes to internal#141149

Merged
ymao1 merged 2 commits intoelastic:mainfrom
ymao1:alerting/internal-triggers-actions-ui-routes
Sep 22, 2022
Merged

[Response Ops] [Alerting] Change triggers_actions_ui routes to internal#141149
ymao1 merged 2 commits intoelastic:mainfrom
ymao1:alerting/internal-triggers-actions-ui-routes

Conversation

@ymao1
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 commented Sep 20, 2022

Summary

While working on another issue, I noticed that all the triggers_actions_ui routes were prefixed with /api. Since these are all internal facing routes, we should be using /internal so that we can make changes as necessary.

@ymao1 ymao1 changed the title Changing triggers actions ui routes to internal [Response Ops] [Alerting] Change triggers_actions_ui routes to internal Sep 21, 2022
@ymao1 ymao1 self-assigned this Sep 21, 2022
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Sep 21, 2022
@ymao1 ymao1 marked this pull request as ready for review September 21, 2022 12:11
@ymao1 ymao1 requested a review from a team as a code owner September 21, 2022 12:11
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 added the v8.6.0 label Sep 21, 2022
Copy link
Copy Markdown
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Sep 22, 2022

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 101.1KB 101.1KB +5.0B
triggersActionsUi 1.1MB 1.1MB +25.0B
total +30.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 93.6KB 93.7KB +5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit 81e973b into elastic:main Sep 22, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 22, 2022
@ymao1 ymao1 deleted the alerting/internal-triggers-actions-ui-routes branch September 22, 2022 13:01
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 22, 2022
* main: (33 commits)
  Fix Next and Previous button on step screenshot carousel. (elastic#141422)
  [journeys] add a short delay after loading data (elastic#141437)
  skip failing test suite (elastic#140797)
  skip failing test suite (elastic#138776)
  Documents saved objects bulk delete API (elastic#141164)
  [Response Ops][Alerting] Defining default action params on connector type (elastic#141226)
  [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213)
  [APM] Fix search bar suggestions (elastic#141101)
  close popover on click (elastic#141272)
  [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276)
  [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239)
  [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228)
  [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288)
  Shameless copy of the retryTransientEsErrors from fleet (elastic#141246)
  [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735)
  Changing triggers actions ui routes to internal (elastic#141149)
  skip flaky test suit elastic#141356
  [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043)
  [dashboard controls] skip failing test on cloud (elastic#141291)
  [Synthetics] unskip edit_monitor api integration tests (elastic#141277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.6.0

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

6 participants