[Security Solution][Fix]-Issue with disabled dataProvider#140735
Merged
logeekal merged 12 commits intoelastic:mainfrom Sep 22, 2022
Merged
[Security Solution][Fix]-Issue with disabled dataProvider#140735logeekal merged 12 commits intoelastic:mainfrom
logeekal merged 12 commits intoelastic:mainfrom
Conversation
logeekal
added
release_note:skip
Contributor
Author
Files by Code Ownerelastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
jamster10
approved these changes
Sep 15, 2022
Contributor
jamster10
left a comment
jamster10
left a comment
There was a problem hiding this comment.
Good on Explore side 👌
x-pack/plugins/security_solution/public/common/components/top_n/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/timelines/public/components/t_grid/helpers.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
Files by Code Ownerelastic/awp-viz
elastic/security-detections-response-alerts
elastic/security-detections-response-rules
elastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
marshallmain
approved these changes
Sep 19, 2022
Contributor
marshallmain
left a comment
marshallmain
left a comment
There was a problem hiding this comment.
Alerts area changes LGTM, only a couple files changed 👍
xcrzx
approved these changes
Sep 21, 2022
maximpn
approved these changes
Sep 22, 2022
Contributor
maximpn
left a comment
maximpn
left a comment
There was a problem hiding this comment.
Rules Area LGTM, there are just minor changes
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
michaelolo24
approved these changes
Sep 22, 2022
Contributor
michaelolo24
left a comment
michaelolo24
left a comment
There was a problem hiding this comment.
Thanks for making the changes! LGTM 🚀
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2022
…0735) Fixes : elastic#129958 When the data provider was disabled, the final query getting created is not syntactically correct and throws a syntax error as show in the screenshot below:  (cherry picked from commit ec1fe0a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 22, 2022
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2022
…141424) Fixes : #129958 When the data provider was disabled, the final query getting created is not syntactically correct and throws a syntax error as show in the screenshot below:  (cherry picked from commit ec1fe0a) Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes : #129958
When the data provider was disabled, the final query getting created is not syntactically correct and throws a syntax error as show in the screenshot below:
Checklist
Delete any items that are not applicable to this PR.
For maintainers